Skip to contentSkip to conversation

scsi: lpfc: NVME Target: Base modifications

bug report Dan Carpenter 2 participants 2 messages Feb 27, 2017 – Mar 4, 2017 SCSI

lore
Share & tools
lore
#0 lore raw

Hello James Smart,

This is a semi-automatic email about new static checker warnings.

The patch f358dd0ca26c: "scsi: lpfc: NVME Target: Base modifications" from Feb 12, 2017, leads to the following Smatch complaint:

drivers/scsi/lpfc/lpfc_mem.c:650 lpfc_sli4_nvmet_alloc()

	 warn: variable dereferenced before check 'dma_buf->iocbq' (see line 649)

drivers/scsi/lpfc/lpfc_mem.c
648 dma_buf->iocbq = lpfc_sli_get_iocbq(phba);

   649		dma_buf->iocbq->iocb_flag = LPFC_IO_NVMET;
                ^^^^^^^^^^^^^^^^^^^^^^^^^

Dereference.

   650		if (!dma_buf->iocbq) {
                     ^^^^^^^^^^^^^^

Check.

   651			kfree(dma_buf->context);
   652			pci_pool_free(phba->lpfc_drb_pool, dma_buf->dbuf.virt,

regards,
dan carpenter

#1 lore raw
Quoted 8 lines · Dan Carpenter

Hello James Smart,

This is a semi-automatic email about new static checker warnings.

The patch f358dd0ca26c: "scsi: lpfc: NVME Target: Base modifications" from Feb 12, 2017, leads to the following Smatch complaint:

Thanks. Issues were addressed by patch from Colin King, and pushed in the lpfc patch set just posted. see http://marc.info/?l=linux-scsi&m=148864866415099&w=2

-- james