Skip to contentSkip to conversation

staging: dgnc: replace usleep_range with udelay

PATCH Superseded Aishwarya Pant 2 participants 2 messages Feb 27, 2017 – Mar 1, 2017 Staging

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Aishwarya Pant

author
#0 lore raw

PATCH 1/1 staging: dgnc: replace usleep_range with udelay

Replace usleep_range by udelay in function cls_flush_uart_write as it called under a channel lock

Signed-off-by Aishwarya Pant <[email protected]>
---
 drivers/staging/dgnc/dgnc_cls.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/dgnc/dgnc_cls.c +1 -1
index c20ffdd..f116ce1 100644
@@ -609,7 +609,7 @@ static void cls_flush_uart_write(struct channel_t *ch)
 
 	writeb((UART_FCR_ENABLE_FIFO | UART_FCR_CLEAR_XMIT),
 	       &ch->ch_cls_uart->isr_fcr);
-	usleep_range(10, 20);
+	udelay(10);
 
 	ch->ch_flags |= (CH_TX_FIFO_EMPTY | CH_TX_FIFO_LWM);
 }
Signature · 1 line
2.7.4
maintainer
#1 lore raw
Quoted 13 lines · Aishwarya Pant

Replace usleep_range by udelay in function cls_flush_uart_write as it called under a channel lock

Signed-off-by Aishwarya Pant <[email protected]>
---
 drivers/staging/dgnc/dgnc_cls.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/dgnc/dgnc_cls.c +0 -0
index c20ffdd..f116ce1 100644

drivers/staging/dgnc/dgnc_cls.c static void cls_flush_uart_write(struct channel_t *ch) · line 612

Quoted 5 lines
drivers/staging/dgnc/dgnc_cls.c +1 -1
@@ -609,7 +609,7 @@ static void cls_flush_uart_write(struct channel_t *ch)
 
 	writeb((UART_FCR_ENABLE_FIFO | UART_FCR_CLEAR_XMIT),
 	       &ch->ch_cls_uart->isr_fcr);
-	usleep_range(10, 20);
+	udelay(10);

Please comment why you can not use usleep_range() here, otherwise someone else will come along and change it later.

thanks,

greg k-h