app/testpmd: Fix typos
PATCH 1/1 app/testpmd: Fix typos
fixes trivial typos in app/test-pmd/cmdline.c, app/test-pmd/icmpecho.c, app/test-pmd/testpmd.c
--- app/test-pmd/cmdline.c | 4 ++-- app/test-pmd/icmpecho.c | 4 ++-- app/test-pmd/testpmd.c | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-)
app/test-pmd/cmdline.c +2 -2
@@ -5443,7 +5443,7 @@ cmd_link_flow_ctrl_set_parsed(void *parsed_result,printf ("bad flow contrl parameter, return code = %d \n" , ret); } -/* *** SETUP ETHERNET PIRORITY FLOW CONTROL *** */ +/* *** SETUP ETHERNET PRIORITY FLOW CONTROL *** */ struct cmd_priority_flow_ctrl_set_result {cmdline_fixed_string_t set;cmdline_fixed_string_t pfc_ctrl;
@@ -7497,7 +7497,7 @@ cmdline_parse_inst_t cmd_set_mirror_mask = { }, }; -/* *** CONFIGURE VM MIRROR UDLINK/DOWNLINK RULE *** */ +/* *** CONFIGURE VM MIRROR UPLINK/DOWNLINK RULE *** */ struct cmd_set_mirror_link_result {cmdline_fixed_string_t set;cmdline_fixed_string_t port;
app/test-pmd/icmpecho.c +2 -2
@@ -200,7 +200,7 @@ ip_proto_name(uint16_t ip_proto)"OSPFIGP" ,/**< OSPFIGP */ "SRPC" ,/**< Strite RPC protocol */ -"LARP" ,/**< Locus Address Resoloution */ +"LARP" ,/**< Locus Address Resolution */ "MTP" ,/**< Multicast Transport */ "AX25" ,/**< AX.25 Frames */ "4IN4", /**< IP encapsulated in IP */
@@ -297,7 +297,7 @@ ipv4_hdr_cksum(struct ipv4_hdr *ip_h) (((rte_be_to_cpu_32 ((ipv4_addr)) >>24 ) &0x000000FF ) ==0xE0 )/* -* Receive a burst of packets, lookup for ICMP echo requets, and, if any, +* Receive a burst of packets, lookup for ICMP echo requests, and, if any, * send back ICMP echo replies. */ static void
app/test-pmd/testpmd.c +2 -2
@@ -111,7 +111,7 @@ uint8_t mp_anon = 0;/* * Record the Ethernet address of peer target ports to which packets are * forwarded. -* Must be instanciated with the ethernet addresses of peer traffic generator +* Must be instantiated with the ethernet addresses of peer traffic generator * ports. */ struct ether_addr peer_eth_addrs[RTE_MAX_ETHPORTS ];
@@ -1913,7 +1913,7 @@ get_eth_dcb_conf(struct rte_eth_conf *eth_conf,struct rte_eth_vmdq_dcb_tx_conf *vmdq_tx_conf = ð_conf->tx_adv_conf.vmdq_dcb_tx_conf; -/* VMDQ+DCB RX and TX configrations */ +/* VMDQ+DCB RX and TX configurations */ vmdq_rx_conf->enable_default_pool =0 ; vmdq_rx_conf->default_pool =0 ; vmdq_rx_conf->nb_queue_pools =
Signature · 1 line
2.11.0
Quoted 8 lines
-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of Nirmoy Das
Sent: Monday, February 27, 2017 7:24 PM
To: [email protected]
Cc: Nirmoy Das <[email protected]>
Subject: [dpdk-dev] [PATCH] app/testpmd: Fix typos
Quoted 4 lines
fixes trivial typos in
app/test-pmd/cmdline.c,app/test-pmd/icmpecho.c,app/test-pmd/testpmd.cSigned-off-by Nirmoy Das <[email protected]>
Hi Nirmoy,
Thanks for that.
Just a small heads-up since this is your first patch. The subject line should be lowercase (apart from known abbreviations) and there is no need to list the files in the body since git will record that anyway. Have a look at the contribution guidelines for some more pointers:
http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-subject-line
Apart from that, thanks for the patch.
Thomas Monjalon
Applied2017-02-28 17:20, Mcnamara, John:
Quoted 15 lines
Quoted 4 lines
fixes trivial typos in
app/test-pmd/cmdline.c,app/test-pmd/icmpecho.c,app/test-pmd/testpmd.cSigned-off-by Nirmoy Das <[email protected]>Hi Nirmoy,
Thanks for that.
Just a small heads-up since this is your first patch. The subject line should be lowercase (apart from known abbreviations) and there is no need to list the files in the body since git will record that anyway. Have a look at the contribution guidelines for some more pointers:
Quoted 5 lines
http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-subject-line
Apart from that, thanks for the patch.
Acked-by John McNamara <[email protected]>
Applied, thanks
Nirmoy, we are looking for reviewers with a good english reading ;)