test-appliance: yet another file permissions fix
PATCH 1/1 test-appliance: yet another file permissions fix
From: Eric Biggers <[email protected]>
Several directories in the kvm-xfstests appliance were still not being given the correct file permissions, since they were rsync'ed directly into the mounted root filesystem with the '-a' option. Unfortunately it seems we can't express "go+u-w" with rsync options (it's not accepted by --chmod), but we can copy the files through 'tar' instead, similar to what is done elsewhere.
(I didn't notice this earlier because it is kvm-xfstests specific, and it only broke a couple tests such as generic/128.)
--- kvm-xfstests/test-appliance/gen-image | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
kvm-xfstests/test-appliance/gen-image +2 -1
@@ -111,7 +111,8 @@ fi update_xfstests() { tar -C $ROOTDIR/root -xf ../../xfstests.tar.gz - rsync --exclude-from kvm-exclude-files -avH files/* $ROOTDIR + tar -X kvm-exclude-files -C files \ + --owner=root --group=root --mode=go+u-w -c . | tar -C $ROOTDIR -x rsync -avH ../../xfstests/git-versions $ROOTDIR/root/xfstests chown -R root:root $ROOTDIR/root chmod -R go+u-w $ROOTDIR/root
Signature · 1 line
2.11.0.483.g087da7b7c-goog
Theodore Ts'o
AppliedQuoted 9 lines · Eric Biggers
From: Eric Biggers <[email protected]>
Several directories in the kvm-xfstests appliance were still not being given the correct file permissions, since they were rsync'ed directly into the mounted root filesystem with the '-a' option. Unfortunately it seems we can't express "go+u-w" with rsync options (it's not accepted by --chmod), but we can copy the files through 'tar' instead, similar to what is done elsewhere.
Quoted 4 lines
(I didn't notice this earlier because it is kvm-xfstests specific, and it only broke a couple tests such as generic/128.)
Signed-off-by Eric Biggers <[email protected]>
Thanks, applied.
- Ted