video: fbdev: pmag-aa-fb: remove incorrect __exit markups

PATCH In review Dmitry Torokhov 3 participants 3 messages Mar 1, 2017 – Mar 23, 2017 Framebuffer layer

Share & tools

Dmitry Torokhov

author

2017-03-01 23:31 UTC #0 lore raw

PATCH 1/1 video: fbdev: pmag-aa-fb: remove incorrect __exit markups

Even if bus is not hot-pluggable, devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind attributes.

Signed-off-by Dmitry Torokhov <[email protected]>

---
 drivers/video/fbdev/pmag-aa-fb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/video/fbdev/pmag-aa-fb.c +2 -2

index ffe2dd482f84..39922f072db4 100644
@@ -247,7 +247,7 @@ static int pmagaafb_probe(struct device *dev)
 	return err;
 }
 
-static int __exit pmagaafb_remove(struct device *dev)
+static int pmagaafb_remove(struct device *dev)
 {
 	struct tc_dev *tdev = to_tc_dev(dev);
 	struct fb_info *info = dev_get_drvdata(dev);

@@ -280,7 +280,7 @@ static struct tc_driver pmagaafb_driver = {
 		.name	= "pmagaafb",
 		.bus	= &tc_bus_type,
 		.probe	= pmagaafb_probe,
-		.remove	= __exit_p(pmagaafb_remove),
+		.remove	= pmagaafb_remove,
 	},
 };

Signature · 5 lines

2.12.0.rc1.440.g5b76565f74-goog


-- 
Dmitry

Bartlomiej Zolnierkiewicz

2017-03-20 16:49 UTC #1 lore raw

Quoted 7 lines · Dmitry Torokhov

Even if bus is not hot-pluggable, devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind attributes.
Signed-off-by Dmitry Torokhov <[email protected]>

Patch queued for 4.12, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Maciej W. Rozycki

2017-03-23 11:48 UTC #2 lore raw

Quoted 9 lines · Bartlomiej Zolnierkiewicz

Quoted 7 lines
Even if bus is not hot-pluggable, devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind attributes.
Signed-off-by Dmitry Torokhov <[email protected]>
Patch queued for 4.12, thanks.

Thanks!

Maciej