Skip to contentSkip to conversation

aacraid: Fix typo in blink status

PATCH Applied Raghava Aditya Renukunta 3 participants 3 messages Mar 3, 2017 – Mar 7, 2017

Subsystems (2)
SCSI Aacraid SCSI RAID driver
lore
Share & tools
lore

Raghava Aditya Renukunta

author
#0 lore raw

PATCH 1/1 aacraid: Fix typo in blink status

The return status of the adapter check on KERNEL_PANIC is supposed to be the upper 16 bits of the OMR status register.

Fixes c421530bf848604e (scsi: aacraid: Reorder Adpater status check)
Reported-by Dan Carpenter <[email protected]>
Signed-off-by Raghava Aditya Renukunta <[email protected]>
---
 drivers/scsi/aacraid/src.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/aacraid/src.c +1 -1
index 2e5338d..7b0410e 100644
@@ -468,7 +468,7 @@ static int aac_src_check_health(struct aac_dev *dev)
 	return -1;
 
 err_blink:
-	return (status > 16) & 0xFF;
+	return (status >> 16) & 0xFF;
 }
 
 static inline u32 aac_get_vector(struct aac_dev *dev)
Signature · 1 line
1.8.3.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines

Subject: [PATCH] aacraid: Fix typo in blink status

The return status of the adapter check on KERNEL_PANIC is supposed to be the upper 16 bits of the OMR status register.

Quoted 7 lines
Fixes c421530bf848604e (scsi: aacraid: Reorder Adpater status check)
Reported-by Dan Carpenter <[email protected]>
Signed-off-by Raghava Aditya Renukunta

<[email protected]>

---
 drivers/scsi/aacraid/src.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by Dave Carroll <[email protected]>
Applied
#2 lore raw
In reply to Raghava Aditya Renukunta
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Raghava" == Raghava Aditya Renukunta <[email protected]> writes:

Raghava> The return status of the adapter check on KERNEL_PANIC is Raghava> supposed to be the upper 16 bits of the OMR status register.

Applied to 4.11/scsi-fixes.

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering