staging:rtl8192u: Check memory allocation
PATCH v3 1/1 staging:rtl8192u: Check memory allocation
Check if the allocation is not successful and
return the error code -ENOMEM.
---
Changes in v2:
- use a goto pattern to handle the allocation fails
- use exiting a function to free the memory in case of fail
- move the free function above the initialization
Changes in v3:
- free the r8192_priv structure in case one of the urb allocation fails
- break the loop when an uninitialized pointer is reached
drivers/staging/rtl8192u/r8192U_core.c | 120 +++++++++++++++++++-------------- 1 file changed, 70 insertions(+), 50 deletions(-)
drivers/staging/rtl8192u/r8192U_core.c +70 -50
@@ -1677,11 +1677,68 @@ short rtl8192_tx(struct net_device *dev, struct sk_buff *skb)return -1 ; } +#ifdef THOMAS_BEACON +static void rtl8192_usb_deleteendpoints (struct net_device *dev) +{ +int i; +struct r8192_priv *priv =ieee80211_priv (dev); + +if (priv->rx_urb) { +for (i =0 ; i < (MAX_RX_URB +1 ); i++) { +usb_kill_urb (priv->rx_urb[i]); +usb_free_urb (priv->rx_urb[i]); + } +kfree (priv->rx_urb); + priv->rx_urb =NULL ; + } +kfree (priv->oldaddr); + priv->oldaddr =NULL ; + +kfree (priv->pp_rxskb); + priv->pp_rxskb =NULL ; +} +#else +void rtl8192_usb_deleteendpoints (struct net_device *dev) +{ +int i; +struct r8192_priv *priv =ieee80211_priv (dev); + +#ifndef JACKSON_NEW_RX + +if (priv->rx_urb) { +for (i =0 ; i < (MAX_RX_URB +1 ); i++) { +if (!priv->rx_urb[i]) +break ; +usb_kill_urb (priv->rx_urb[i]); +if (!riv->rx_urb[i]->transfer_buffer) +break ; +kfree (priv->rx_urb[i]->transfer_buffer); +usb_free_urb (priv->rx_urb[i]); + } + +if (i < (MAX_RX_URB +1 )) +usb_free_urb (priv->rx_urb[i]); +kfree (priv->rx_urb); + priv->rx_urb =NULL ; + } +#else +kfree (priv->rx_urb); + priv->rx_urb =NULL ; +kfree (priv->oldaddr); + priv->oldaddr =NULL ; + +kfree (priv->pp_rxskb); + priv->pp_rxskb =0 ; + +#endif +} +#endif +static short rtl8192_usb_initendpoints (struct net_device *dev) {struct r8192_priv *priv =ieee80211_priv (dev); - priv->rx_urb =kmalloc (sizeof (struct urb *) * (MAX_RX_URB +1 ), + priv->rx_urb =kzalloc (sizeof (struct urb *) * (MAX_RX_URB +1 ),GFP_KERNEL );if (!priv->rx_urb)return -ENOMEM ;
@@ -1689,9 +1746,13 @@ static short rtl8192_usb_initendpoints(struct net_device *dev)#ifndef JACKSON_NEW_RX for (i =0 ; i < (MAX_RX_URB +1 ); i++) { priv->rx_urb[i] =usb_alloc_urb (0 ,GFP_KERNEL ); +if (!priv->rx_urb[i]) + goto exit; priv->rx_urb[i]->transfer_buffer = -kmalloc (RX_URB_SIZE ,GFP_KERNEL ); +kzalloc (RX_URB_SIZE ,GFP_KERNEL ); +if (!priv->rx_urb[i]->transfer_buffer) + goto exit; priv->rx_urb[i]->transfer_buffer_length =RX_URB_SIZE ; }
@@ -1704,6 +1765,9 @@ static short rtl8192_usb_initendpoints(struct net_device *dev) priv->rx_urb[16 ] =usb_alloc_urb (0 ,GFP_KERNEL ); priv->oldaddr =kmalloc (16 ,GFP_KERNEL ); +if (!priv->oldaddr) + goto exit; + oldaddr = priv->oldaddr; align = ((long )oldaddr) &3 ;if (align) {
@@ -1732,57 +1796,13 @@ static short rtl8192_usb_initendpoints(struct net_device *dev)netdev_dbg (dev,"End of initendpoints\n" );return 0 ; -} - -#ifdef THOMAS_BEACON -static void rtl8192_usb_deleteendpoints (struct net_device *dev) -{ -int i; -struct r8192_priv *priv =ieee80211_priv (dev); - -if (priv->rx_urb) { -for (i =0 ; i < (MAX_RX_URB +1 ); i++) { -usb_kill_urb (priv->rx_urb[i]); -usb_free_urb (priv->rx_urb[i]); - } -kfree (priv->rx_urb); - priv->rx_urb =NULL ; - } -kfree (priv->oldaddr); - priv->oldaddr =NULL ; - -kfree (priv->pp_rxskb); - priv->pp_rxskb =NULL ; -} -#else -void rtl8192_usb_deleteendpoints (struct net_device *dev) -{ -int i; -struct r8192_priv *priv =ieee80211_priv (dev); -#ifndef JACKSON_NEW_RX - -if (priv->rx_urb) { -for (i =0 ; i < (MAX_RX_URB +1 ); i++) { -usb_kill_urb (priv->rx_urb[i]); -kfree (priv->rx_urb[i]->transfer_buffer); -usb_free_urb (priv->rx_urb[i]); - } -kfree (priv->rx_urb); - priv->rx_urb =NULL ; - } -#else +exit: +rtl8192_usb_deleteendpoints (dev);kfree (priv->rx_urb); - priv->rx_urb =NULL ; -kfree (priv->oldaddr); - priv->oldaddr =NULL ; - -kfree (priv->pp_rxskb); - priv->pp_rxskb =0 ; - -#endif +DMESGE ("Endpoint Alloc Failure" ); +return -ENOMEM ; } -#endif static void rtl8192_update_ratr_table (struct net_device *dev);static void rtl8192_link_change (struct net_device *dev)
Signature · 1 line
2.7.4
Quoted 69 lines · Georgiana Rodica Chelu
Check if the allocation is not successful and
return the error code-ENOMEM.Signed-off-by Georgiana Rodica Chelu <[email protected]>---
Changes in v2:
- use a goto pattern to handle the allocation fails
- use exiting a function to free the memory in case of fail
- move the free function above the initializationChanges in v3:
- free ther8192_privstructure in case one of the urb allocation fails
- break the loop when an uninitialized pointer is reacheddrivers/staging/rtl8192u/r8192U_core.c | 120 +++++++++++++++++++-------------- 1 file changed, 70 insertions(+), 50 deletions(-)drivers/staging/rtl8192u/r8192U_core.c +42
-0@@ -1677,11 +1677,68 @@ short rtl8192_tx(struct net_device *dev, struct sk_buff *skb)return -1 ; } +#ifdef THOMAS_BEACON +static void rtl8192_usb_deleteendpoints (struct net_device *dev) +{ +int i; +struct r8192_priv *priv =ieee80211_priv (dev); + +if (priv->rx_urb) { +for (i =0 ; i < (MAX_RX_URB +1 ); i++) { +usb_kill_urb (priv->rx_urb[i]); +usb_free_urb (priv->rx_urb[i]); + } +kfree (priv->rx_urb); + priv->rx_urb =NULL ; + } +kfree (priv->oldaddr); + priv->oldaddr =NULL ; + +kfree (priv->pp_rxskb); + priv->pp_rxskb =NULL ; +} +#else +void rtl8192_usb_deleteendpoints (struct net_device *dev) +{ +int i; +struct r8192_priv *priv =ieee80211_priv (dev); + +#ifndef JACKSON_NEW_RX + +if (priv->rx_urb) { +for (i =0 ; i < (MAX_RX_URB +1 ); i++) { +if (!priv->rx_urb[i]) +break ; +usb_kill_urb (priv->rx_urb[i]); +if (!riv->rx_urb[i]->transfer_buffer) +break ; +kfree (priv->rx_urb[i]->transfer_buffer); +usb_free_urb (priv->rx_urb[i]); + } + +if (i < (MAX_RX_URB +1 )) +usb_free_urb (priv->rx_urb[i]); +kfree (priv->rx_urb);
drivers/staging/rtl8192u/r8192U_core.c short rtl8192_tx(struct net_device *dev, struct sk_buff *skb) · line 1731
Quoted 10 lines
drivers/staging/rtl8192u/r8192U_core.c +10
-0+ priv->rx_urb = NULL; + } +#else +kfree (priv->rx_urb); + priv->rx_urb =NULL ; +kfree (priv->oldaddr); + priv->oldaddr =NULL ; + +kfree (priv->pp_rxskb); + priv->pp_rxskb =0 ;
It's odd to kfree something, implying that there is a pointer, and then set the same thing to 0 (rather than NULL).
Quoted 15 lines
drivers/staging/rtl8192u/r8192U_core.c +6
-1+ +#endif +} +#endif +static short rtl8192_usb_initendpoints (struct net_device *dev) {struct r8192_priv *priv =ieee80211_priv (dev); - priv->rx_urb =kmalloc (sizeof (struct urb *) * (MAX_RX_URB +1 ), + priv->rx_urb =kzalloc (sizeof (struct urb *) * (MAX_RX_URB +1 ),GFP_KERNEL );if (!priv->rx_urb)return -ENOMEM ;
drivers/staging/rtl8192u/r8192U_core.c static short rtl8192_usb_initendpoints(struct net_device *dev) · line 1753
Quoted 9 lines
drivers/staging/rtl8192u/r8192U_core.c +3
-1@@ -1689,9 +1746,13 @@ static short rtl8192_usb_initendpoints(struct net_device *dev)#ifndef JACKSON_NEW_RX for (i =0 ; i < (MAX_RX_URB +1 ); i++) { priv->rx_urb[i] =usb_alloc_urb (0 ,GFP_KERNEL ); +if (!priv->rx_urb[i]) + goto exit; priv->rx_urb[i]->transfer_buffer = -kmalloc (RX_URB_SIZE ,GFP_KERNEL ); +kzalloc (RX_URB_SIZE ,GFP_KERNEL );
I don't think this one has to be kzalloc. No one is looking in the uninitialized parts of it.
Quoted 53 lines
drivers/staging/rtl8192u/r8192U_core.c +5
-33+if (!priv->rx_urb[i]->transfer_buffer) + goto exit; priv->rx_urb[i]->transfer_buffer_length =RX_URB_SIZE ; }@@ -1704,6 +1765,9 @@ static short rtl8192_usb_initendpoints(struct net_device *dev) priv->rx_urb[16 ] =usb_alloc_urb (0 ,GFP_KERNEL ); priv->oldaddr =kmalloc (16 ,GFP_KERNEL ); +if (!priv->oldaddr) + goto exit; + oldaddr = priv->oldaddr; align = ((long )oldaddr) &3 ;if (align) {@@ -1732,57 +1796,13 @@ static short rtl8192_usb_initendpoints(struct net_device *dev)netdev_dbg (dev,"End of initendpoints\n" );return 0 ; -} - -#ifdef THOMAS_BEACON -static void rtl8192_usb_deleteendpoints (struct net_device *dev) -{ -int i; -struct r8192_priv *priv =ieee80211_priv (dev); - -if (priv->rx_urb) { -for (i =0 ; i < (MAX_RX_URB +1 ); i++) { -usb_kill_urb (priv->rx_urb[i]); -usb_free_urb (priv->rx_urb[i]); - } -kfree (priv->rx_urb); - priv->rx_urb =NULL ; - } -kfree (priv->oldaddr); - priv->oldaddr =NULL ; - -kfree (priv->pp_rxskb); - priv->pp_rxskb =NULL ; -} -#else -void rtl8192_usb_deleteendpoints (struct net_device *dev) -{ -int i; -struct r8192_priv *priv =ieee80211_priv (dev); -#ifndef JACKSON_NEW_RX - -if (priv->rx_urb) { -for (i =0 ; i < (MAX_RX_URB +1 ); i++) { -usb_kill_urb (priv->rx_urb[i]); -kfree (priv->rx_urb[i]->transfer_buffer);
drivers/staging/rtl8192u/r8192U_core.c static short rtl8192_usb_initendpoints(struct net_device *dev) · line 1776
Quoted 10 lines
drivers/staging/rtl8192u/r8192U_core.c +2
-7- usb_free_urb(priv->rx_urb[i]); - } -kfree (priv->rx_urb); - priv->rx_urb =NULL ; - } -#else +exit: +rtl8192_usb_deleteendpoints (dev);kfree (priv->rx_urb); - priv->rx_urb =NULL ;
It looks suspicious to keep the kfree but drop the NULL initization. I have the impression that the kfree should go to, but perhaps this is just an artifact of the diff algorithm, and the kfree is doing filling a different purpose in the transformed code than in the original code.
julia
Quoted 24 lines
drivers/staging/rtl8192u/r8192U_core.c +2
-9-kfree (priv->oldaddr); - priv->oldaddr =NULL ; - -kfree (priv->pp_rxskb); - priv->pp_rxskb =0 ; - -#endif +DMESGE ("Endpoint Alloc Failure" ); +return -ENOMEM ; } -#endif static void rtl8192_update_ratr_table (struct net_device *dev);static void rtl8192_link_change (struct net_device *dev) --2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170302214748.GA9824%40fireworks.
For more options, visit https://groups.google.com/d/optout.
I compared my local file with the git patch and it seems that something went wrong.
I would not expect something like this.
This is how the two functions (rtl8192_usb_initendpoints and rtl8192_usb_deleteendpoints)
from my local file look like: http://pastebin.com/9SJaYkdi .
Maybe I should create two commits. The first commit moves the delete function above
the init one, and the second commit makes my changes on checking the memory allocation.
What do you think?
Georgiana
Quoted 224 lines · Julia Lawall
Quoted 4 lines · Georgiana Rodica Chelu
Check if the allocation is not successful and
return the error code-ENOMEM.Signed-off-by Georgiana Rodica Chelu <[email protected]<javascript:>>
Quoted 7 lines
---
Changes in v2:
- use a goto pattern to handle the allocation fails
- use exiting a function to free the memory in case of fail
- move the free function above the initializationQuoted 6 lines
Changes in v3:
- free ther8192_privstructure in case one of the urb allocation fails
- break the loop when an uninitialized pointer is reacheddrivers/staging/rtl8192u/r8192U_core.c | 120+++++++++++++++++++--------------
Review
Quoted 3 lines
1 file changed, 70 insertions(+), 50 deletions(-)(quoted diff) +0
-0
b/drivers/staging/rtl8192u/r8192U_core.cdrivers/staging/rtl8192u/r8192U_core.c short rtl8192_tx(struct net_device *dev, struct
Quoted 4 lines
index b631990..11210e3 100644
drivers/staging/rtl8192u/r8192U_core.c +0
-0@@ -1677,11 +1677,68 @@ short rtl8192_tx(struct net_device *dev, struct
sk_buff*skb)Quoted 45 lines
drivers/staging/rtl8192u/r8192U_core.c +42
-0return -1 ; } +#ifdef THOMAS_BEACON +static void rtl8192_usb_deleteendpoints (struct net_device *dev) +{ +int i; +struct r8192_priv *priv =ieee80211_priv (dev); + +if (priv->rx_urb) { +for (i =0 ; i < (MAX_RX_URB +1 ); i++) { +usb_kill_urb (priv->rx_urb[i]); +usb_free_urb (priv->rx_urb[i]); + } +kfree (priv->rx_urb); + priv->rx_urb =NULL ; + } +kfree (priv->oldaddr); + priv->oldaddr =NULL ; + +kfree (priv->pp_rxskb); + priv->pp_rxskb =NULL ; +} +#else +void rtl8192_usb_deleteendpoints (struct net_device *dev) +{ +int i; +struct r8192_priv *priv =ieee80211_priv (dev); + +#ifndef JACKSON_NEW_RX + +if (priv->rx_urb) { +for (i =0 ; i < (MAX_RX_URB +1 ); i++) { +if (!priv->rx_urb[i]) +break ; +usb_kill_urb (priv->rx_urb[i]); +if (!riv->rx_urb[i]->transfer_buffer) +break ; +kfree (priv->rx_urb[i]->transfer_buffer); +usb_free_urb (priv->rx_urb[i]); + } + +if (i < (MAX_RX_URB +1 )) +usb_free_urb (priv->rx_urb[i]); +kfree (priv->rx_urb);drivers/staging/rtl8192u/r8192U_core.c short rtl8192_tx(struct net_device *dev, struct sk_buff *skb) · line 1731
Quoted 10 lines
drivers/staging/rtl8192u/r8192U_core.c +10
-0+ priv->rx_urb = NULL; + } +#else + kfree(priv->rx_urb); + priv->rx_urb =NULL ; +kfree (priv->oldaddr); + priv->oldaddr =NULL ; + +kfree (priv->pp_rxskb); + priv->pp_rxskb =0 ;It's odd to kfree something, implying that there is a pointer, and then set the same thing to 0 (rather than NULL).
drivers/staging/rtl8192u/r8192U_core.c static short rtl8192_usb_initendpoints(struct
Quoted 15 lines
drivers/staging/rtl8192u/r8192U_core.c +6
-1+ +#endif +} +#endif + static short rtl8192_usb_initendpoints(struct net_device *dev) {struct r8192_priv *priv =ieee80211_priv (dev); - priv->rx_urb =kmalloc (sizeof (struct urb *) * (MAX_RX_URB +1 ), + priv->rx_urb =kzalloc (sizeof (struct urb *) * (MAX_RX_URB +1 ),GFP_KERNEL );if (!priv->rx_urb)return -ENOMEM ;@@ -1689,9 +1746,13 @@ static short rtl8192_usb_initendpoints(struct
net_device*dev)drivers/staging/rtl8192u/r8192U_core.c static short rtl8192_usb_initendpoints(struct net_device *dev) · line 1753
Quoted 9 lines
drivers/staging/rtl8192u/r8192U_core.c +3
-1#ifndef JACKSON_NEW_RX for (i =0 ; i < (MAX_RX_URB +1 ); i++) { priv->rx_urb[i] =usb_alloc_urb (0 ,GFP_KERNEL ); +if (!priv->rx_urb[i]) + goto exit; priv->rx_urb[i]->transfer_buffer = -kmalloc (RX_URB_SIZE ,GFP_KERNEL ); +kzalloc (RX_URB_SIZE ,GFP_KERNEL );I don't think this one has to be kzalloc. No one is looking in the uninitialized parts of it.
drivers/staging/rtl8192u/r8192U_core.c static short rtl8192_usb_initendpoints(struct
Quoted 6 lines
drivers/staging/rtl8192u/r8192U_core.c +2
-0+if (!priv->rx_urb[i]->transfer_buffer) + goto exit; priv->rx_urb[i]->transfer_buffer_length =RX_URB_SIZE ; }@@ -1704,6 +1765,9 @@ static short rtl8192_usb_initendpoints(struct
net_device*dev)drivers/staging/rtl8192u/r8192U_core.c static short rtl8192_usb_initendpoints(struct
Quoted 10 lines
drivers/staging/rtl8192u/r8192U_core.c +3
-0priv->rx_urb[16 ] =usb_alloc_urb (0 ,GFP_KERNEL ); priv->oldaddr =kmalloc (16 ,GFP_KERNEL ); +if (!priv->oldaddr) + goto exit; + oldaddr = priv->oldaddr; align = ((long )oldaddr) &3 ;if (align) {@@ -1732,57 +1796,13 @@ static short rtl8192_usb_initendpoints(struct
net_device*dev)Quoted 37 lines
drivers/staging/rtl8192u/r8192U_core.c +0
-33netdev_dbg (dev,"End of initendpoints\n" );return 0 ; -} - -#ifdef THOMAS_BEACON -static void rtl8192_usb_deleteendpoints (struct net_device *dev) -{ -int i; -struct r8192_priv *priv =ieee80211_priv (dev); - -if (priv->rx_urb) { -for (i =0 ; i < (MAX_RX_URB +1 ); i++) { -usb_kill_urb (priv->rx_urb[i]); -usb_free_urb (priv->rx_urb[i]); - } -kfree (priv->rx_urb); - priv->rx_urb =NULL ; - } -kfree (priv->oldaddr); - priv->oldaddr =NULL ; - -kfree (priv->pp_rxskb); - priv->pp_rxskb =NULL ; -} -#else -void rtl8192_usb_deleteendpoints (struct net_device *dev) -{ -int i; -struct r8192_priv *priv =ieee80211_priv (dev); -#ifndef JACKSON_NEW_RX - -if (priv->rx_urb) { -for (i =0 ; i < (MAX_RX_URB +1 ); i++) { -usb_kill_urb (priv->rx_urb[i]); -kfree (priv->rx_urb[i]->transfer_buffer);drivers/staging/rtl8192u/r8192U_core.c static short rtl8192_usb_initendpoints(struct net_device *dev) · line 1776
Quoted 10 lines
drivers/staging/rtl8192u/r8192U_core.c +2
-7- usb_free_urb(priv->rx_urb[i]); - } -kfree (priv->rx_urb); - priv->rx_urb =NULL ; - } -#else +exit: +rtl8192_usb_deleteendpoints (dev);kfree (priv->rx_urb); - priv->rx_urb =NULL ;It looks suspicious to keep the kfree but drop the NULL initization. I have the impression that the kfree should go to, but perhaps this is just an artifact of the diff algorithm, and the kfree is doing filling a different purpose in the transformed code than in the original code.
julia
Quoted 15 lines
drivers/staging/rtl8192u/r8192U_core.c +2
-9-kfree (priv->oldaddr); - priv->oldaddr =NULL ; - -kfree (priv->pp_rxskb); - priv->pp_rxskb =0 ; - -#endif +DMESGE ("Endpoint Alloc Failure" ); +return -ENOMEM ; } -#endif static void rtl8192_update_ratr_table (struct net_device *dev);static void rtl8192_link_change (struct net_device *dev) --Quoted 4 lines
2.7.4
Signature · 1 line
You received this message because you are subscribed to the GoogleGroups "outreachy-kernel" group.
Quoted 1 line
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected] <javascript:>.
Quoted 1 line
To post to this group, send email to [email protected]
<javascript:>.
Quoted 1 line
To view this discussion on the web visit
https://groups.google.com/d/msgid/outreachy-kernel/20170302214748.GA9824%40fireworks.
Quoted 2 lines
For more options, visit https://groups.google.com/d/optout.
Quoted 8 lines · Georgiana Chelu
I compared my local file with the git patch and it seems that something went wrong.
I would not expect something like this.This is how the two functions (
rtl8192_usb_initendpointsandrtl8192_usb_deleteendpoints)
from my local file look like: http://pastebin.com/9SJaYkdi .
Quoted 7 lines
Maybe I should create two commits. The first commit moves the delete function above
the init one, and the second commit makes my changes on checking the memory allocation.What do you think?
Don't top post :) I'm guessing that this refers to the kfree issue, but it would be clearer if this comment were next to the code that it is referring to.
In your paste, you have a kfree on line 123 just below a call to rtl8192_usb_deleteendpoints, and that function also appears to free the same value, if it is not NULL.
Also, I wonder why you don't use the rtl8192_usb_deleteendpoints function in the case that the final kcalloc fails (lines 108-116 in the paste.
julia
Quoted 256 lines
Georgiana
On Friday, 3 March 2017 21:50:07 UTC+2, Julia Lawall wrote:
On Thu, 2 Mar 2017, Georgiana Rodica Chelu wrote: > Check if the allocation is not successful and > return the error code -ENOMEM. > > Signed-off-by: Georgiana Rodica Chelu <[email protected]> > --- > > Changes in v2: > - use a goto pattern to handle the allocation fails > - use exiting a function to free the memory in case of fail > - move the free function above the initialization > > Changes in v3: > - free the r8192_priv structure in case one of the urb > allocation fails > - break the loop when an uninitialized pointer is reached > > drivers/staging/rtl8192u/r8192U_core.c | 120 +++++++++++++++++++-------------- > 1 file changed, 70 insertions(+), 50 deletions(-) > > diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c > index b631990..11210e3 100644 > --- a/drivers/staging/rtl8192u/r8192U_core.c > +++ b/drivers/staging/rtl8192u/r8192U_core.c > @@ -1677,11 +1677,68 @@ short rtl8192_tx(struct net_device *dev, struct sk_buff *skb) > return -1; > } > > +#ifdef THOMAS_BEACON > +static void rtl8192_usb_deleteendpoints(struct net_device *dev) > +{ > + int i; > + struct r8192_priv *priv = ieee80211_priv(dev); > + > + if (priv->rx_urb) { > + for (i = 0; i < (MAX_RX_URB + 1); i++) { > + usb_kill_urb(priv->rx_urb[i]); > + usb_free_urb(priv->rx_urb[i]); > + } > + kfree(priv->rx_urb); > + priv->rx_urb = NULL; > + } > + kfree(priv->oldaddr); > + priv->oldaddr = NULL; > + > + kfree(priv->pp_rxskb); > + priv->pp_rxskb = NULL; > +} > +#else > +void rtl8192_usb_deleteendpoints(struct net_device *dev) > +{ > + int i; > + struct r8192_priv *priv = ieee80211_priv(dev); > + > +#ifndef JACKSON_NEW_RX > + > + if (priv->rx_urb) { > + for (i = 0; i < (MAX_RX_URB + 1); i++) { > + if(!priv->rx_urb[i]) > + break; > + usb_kill_urb(priv->rx_urb[i]); > + if(!riv->rx_urb[i]->transfer_buffer) > + break; > + kfree(priv->rx_urb[i]->transfer_buffer); > + usb_free_urb(priv->rx_urb[i]); > + } > + > + if(i < (MAX_RX_URB + 1)) > + usb_free_urb(priv->rx_urb[i]); > + kfree(priv->rx_urb); > + priv->rx_urb = NULL; > + } > +#else > + kfree(priv->rx_urb); > + priv->rx_urb = NULL; > + kfree(priv->oldaddr); > + priv->oldaddr = NULL; > + > + kfree(priv->pp_rxskb); > + priv->pp_rxskb = 0; It's odd to kfree something, implying that there is a pointer, and then set the same thing to 0 (rather than NULL). > + > +#endif > +} > +#endif > + > static short rtl8192_usb_initendpoints(struct net_device *dev) > { > struct r8192_priv *priv = ieee80211_priv(dev); > > - priv->rx_urb = kmalloc(sizeof(struct urb *) * (MAX_RX_URB + 1), > + priv->rx_urb = kzalloc(sizeof(struct urb *) * (MAX_RX_URB + 1), > GFP_KERNEL); > if (!priv->rx_urb) > return -ENOMEM; > @@ -1689,9 +1746,13 @@ static short rtl8192_usb_initendpoints(struct net_device *dev) > #ifndef JACKSON_NEW_RX > for (i = 0; i < (MAX_RX_URB + 1); i++) { > priv->rx_urb[i] = usb_alloc_urb(0, GFP_KERNEL); > + if(!priv->rx_urb[i]) > + goto exit; > > priv->rx_urb[i]->transfer_buffer = > - kmalloc(RX_URB_SIZE, GFP_KERNEL); > + kzalloc(RX_URB_SIZE, GFP_KERNEL); I don't think this one has to be kzalloc. No one is looking in the uninitialized parts of it. > + if(!priv->rx_urb[i]->transfer_buffer) > + goto exit; > > priv->rx_urb[i]->transfer_buffer_length = RX_URB_SIZE; > } > @@ -1704,6 +1765,9 @@ static short rtl8192_usb_initendpoints(struct net_device *dev) > > priv->rx_urb[16] = usb_alloc_urb(0, GFP_KERNEL); > priv->oldaddr = kmalloc(16, GFP_KERNEL); > + if(!priv->oldaddr) > + goto exit; > + > oldaddr = priv->oldaddr; > align = ((long)oldaddr) & 3; > if (align) { > @@ -1732,57 +1796,13 @@ static short rtl8192_usb_initendpoints(struct net_device *dev) > > netdev_dbg(dev, "End of initendpoints\n"); > return 0; > -} > - > -#ifdef THOMAS_BEACON > -static void rtl8192_usb_deleteendpoints(struct net_device *dev) > -{ > - int i; > - struct r8192_priv *priv = ieee80211_priv(dev); > - > - if (priv->rx_urb) { > - for (i = 0; i < (MAX_RX_URB + 1); i++) { > - usb_kill_urb(priv->rx_urb[i]); > - usb_free_urb(priv->rx_urb[i]); > - } > - kfree(priv->rx_urb); > - priv->rx_urb = NULL; > - } > - kfree(priv->oldaddr); > - priv->oldaddr = NULL; > - > - kfree(priv->pp_rxskb); > - priv->pp_rxskb = NULL; > -} > -#else > -void rtl8192_usb_deleteendpoints(struct net_device *dev) > -{ > - int i; > - struct r8192_priv *priv = ieee80211_priv(dev); > > -#ifndef JACKSON_NEW_RX > - > - if (priv->rx_urb) { > - for (i = 0; i < (MAX_RX_URB + 1); i++) { > - usb_kill_urb(priv->rx_urb[i]); > - kfree(priv->rx_urb[i]->transfer_buffer); > - usb_free_urb(priv->rx_urb[i]); > - } > - kfree(priv->rx_urb); > - priv->rx_urb = NULL; > - } > -#else > +exit: > + rtl8192_usb_deleteendpoints(dev); > kfree(priv->rx_urb); > - priv->rx_urb = NULL; It looks suspicious to keep the kfree but drop the NULL initization. I have the impression that the kfree should go to, but perhaps this is just an artifact of the diff algorithm, and the kfree is doing filling a different purpose in the transformed code than in the original code. julia > - kfree(priv->oldaddr); > - priv->oldaddr = NULL; > - > - kfree(priv->pp_rxskb); > - priv->pp_rxskb = 0; > - > -#endif > + DMESGE("Endpoint Alloc Failure"); > + return -ENOMEM; > } > -#endif > > static void rtl8192_update_ratr_table(struct net_device *dev); > static void rtl8192_link_change(struct net_device *dev) > -- > 2.7.4 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. > To post to this group, send email to [email protected]. > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/20170302214748.GA9824%40 fireworks. > For more options, visit https://groups.google.com/d/optout. >--
You received this message because you are subscribed to the Google Groups
"outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/c35613c8-a4c0-41c5-852e- 56f226f81a24%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Quoted 18 lines · Julia Lawall
Quoted 14 lines · Georgiana Chelu
I compared my local file with the git patch and it seems that something went wrong.
I would not expect something like this.This is how the two functions (
rtl8192_usb_initendpointsandrtl8192_usb_deleteendpoints)
from my local file look like: http://pastebin.com/9SJaYkdi .Maybe I should create two commits. The first commit moves the delete function above
the init one, and the second commit makes my changes on checking the memory allocation.
Quoted 6 lines
Quoted 1 line
What do you think?
Don't top post :) I'm guessing that this refers to the kfree issue, but it would be clearer if this comment were next to the code that it is referring to.
Hi Julia,
Thank you for your advice. I will improve my online communication.
Quoted 4 lines
In your paste, you have a kfree on line 123 just below a call to
rtl8192_usb_deleteendpoints, and that function also appears to free the same value, if it is not NULL.
Yes, you are right. I missed that I have already freed the priv->rx_urb.
Quoted 3 lines
Also, I wonder why you don't use the
rtl8192_usb_deleteendpointsfunction in the case that the final kcalloc fails (lines 108-116 in the paste.
I will make the changes and send a new patch.
Also, to make sure that git does not mess the patch, should I create two patches? The first that moves the delete function above the init one and the second that handles properly the check for memory allocation?
Regards,
Georgiana
Quoted 258 lines
julia
Quoted 256 lines
Georgiana
On Friday, 3 March 2017 21:50:07 UTC+2, Julia Lawall wrote:
On Thu, 2 Mar 2017, Georgiana Rodica Chelu wrote: > Check if the allocation is not successful and > return the error code -ENOMEM. > > Signed-off-by: Georgiana Rodica Chelu <[email protected]> > --- > > Changes in v2: > - use a goto pattern to handle the allocation fails > - use exiting a function to free the memory in case of fail > - move the free function above the initialization > > Changes in v3: > - free the r8192_priv structure in case one of the urb > allocation fails > - break the loop when an uninitialized pointer is reached > > drivers/staging/rtl8192u/r8192U_core.c | 120 +++++++++++++++++++-------------- > 1 file changed, 70 insertions(+), 50 deletions(-) > > diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c > index b631990..11210e3 100644 > --- a/drivers/staging/rtl8192u/r8192U_core.c > +++ b/drivers/staging/rtl8192u/r8192U_core.c > @@ -1677,11 +1677,68 @@ short rtl8192_tx(struct net_device *dev, struct sk_buff *skb) > return -1; > } > > +#ifdef THOMAS_BEACON > +static void rtl8192_usb_deleteendpoints(struct net_device *dev) > +{ > + int i; > + struct r8192_priv *priv = ieee80211_priv(dev); > + > + if (priv->rx_urb) { > + for (i = 0; i < (MAX_RX_URB + 1); i++) { > + usb_kill_urb(priv->rx_urb[i]); > + usb_free_urb(priv->rx_urb[i]); > + } > + kfree(priv->rx_urb); > + priv->rx_urb = NULL; > + } > + kfree(priv->oldaddr); > + priv->oldaddr = NULL; > + > + kfree(priv->pp_rxskb); > + priv->pp_rxskb = NULL; > +} > +#else > +void rtl8192_usb_deleteendpoints(struct net_device *dev) > +{ > + int i; > + struct r8192_priv *priv = ieee80211_priv(dev); > + > +#ifndef JACKSON_NEW_RX > + > + if (priv->rx_urb) { > + for (i = 0; i < (MAX_RX_URB + 1); i++) { > + if(!priv->rx_urb[i]) > + break; > + usb_kill_urb(priv->rx_urb[i]); > + if(!riv->rx_urb[i]->transfer_buffer) > + break; > + kfree(priv->rx_urb[i]->transfer_buffer); > + usb_free_urb(priv->rx_urb[i]); > + } > + > + if(i < (MAX_RX_URB + 1)) > + usb_free_urb(priv->rx_urb[i]); > + kfree(priv->rx_urb); > + priv->rx_urb = NULL; > + } > +#else > + kfree(priv->rx_urb); > + priv->rx_urb = NULL; > + kfree(priv->oldaddr); > + priv->oldaddr = NULL; > + > + kfree(priv->pp_rxskb); > + priv->pp_rxskb = 0; It's odd to kfree something, implying that there is a pointer, and then set the same thing to 0 (rather than NULL). > + > +#endif > +} > +#endif > + > static short rtl8192_usb_initendpoints(struct net_device *dev) > { > struct r8192_priv *priv = ieee80211_priv(dev); > > - priv->rx_urb = kmalloc(sizeof(struct urb *) * (MAX_RX_URB + 1), > + priv->rx_urb = kzalloc(sizeof(struct urb *) * (MAX_RX_URB + 1), > GFP_KERNEL); > if (!priv->rx_urb) > return -ENOMEM; > @@ -1689,9 +1746,13 @@ static short rtl8192_usb_initendpoints(struct net_device *dev) > #ifndef JACKSON_NEW_RX > for (i = 0; i < (MAX_RX_URB + 1); i++) { > priv->rx_urb[i] = usb_alloc_urb(0, GFP_KERNEL); > + if(!priv->rx_urb[i]) > + goto exit; > > priv->rx_urb[i]->transfer_buffer = > - kmalloc(RX_URB_SIZE, GFP_KERNEL); > + kzalloc(RX_URB_SIZE, GFP_KERNEL); I don't think this one has to be kzalloc. No one is looking in the uninitialized parts of it. > + if(!priv->rx_urb[i]->transfer_buffer) > + goto exit; > > priv->rx_urb[i]->transfer_buffer_length = RX_URB_SIZE; > } > @@ -1704,6 +1765,9 @@ static short rtl8192_usb_initendpoints(struct net_device *dev) > > priv->rx_urb[16] = usb_alloc_urb(0, GFP_KERNEL); > priv->oldaddr = kmalloc(16, GFP_KERNEL); > + if(!priv->oldaddr) > + goto exit; > + > oldaddr = priv->oldaddr; > align = ((long)oldaddr) & 3; > if (align) { > @@ -1732,57 +1796,13 @@ static short rtl8192_usb_initendpoints(struct net_device *dev) > > netdev_dbg(dev, "End of initendpoints\n"); > return 0; > -} > - > -#ifdef THOMAS_BEACON > -static void rtl8192_usb_deleteendpoints(struct net_device *dev) > -{ > - int i; > - struct r8192_priv *priv = ieee80211_priv(dev); > - > - if (priv->rx_urb) { > - for (i = 0; i < (MAX_RX_URB + 1); i++) { > - usb_kill_urb(priv->rx_urb[i]); > - usb_free_urb(priv->rx_urb[i]); > - } > - kfree(priv->rx_urb); > - priv->rx_urb = NULL; > - } > - kfree(priv->oldaddr); > - priv->oldaddr = NULL; > - > - kfree(priv->pp_rxskb); > - priv->pp_rxskb = NULL; > -} > -#else > -void rtl8192_usb_deleteendpoints(struct net_device *dev) > -{ > - int i; > - struct r8192_priv *priv = ieee80211_priv(dev); > > -#ifndef JACKSON_NEW_RX > - > - if (priv->rx_urb) { > - for (i = 0; i < (MAX_RX_URB + 1); i++) { > - usb_kill_urb(priv->rx_urb[i]); > - kfree(priv->rx_urb[i]->transfer_buffer); > - usb_free_urb(priv->rx_urb[i]); > - } > - kfree(priv->rx_urb); > - priv->rx_urb = NULL; > - } > -#else > +exit: > + rtl8192_usb_deleteendpoints(dev); > kfree(priv->rx_urb); > - priv->rx_urb = NULL; It looks suspicious to keep the kfree but drop the NULL initization. I have the impression that the kfree should go to, but perhaps this is just an artifact of the diff algorithm, and the kfree is doing filling a different purpose in the transformed code than in the original code. julia > - kfree(priv->oldaddr); > - priv->oldaddr = NULL; > - > - kfree(priv->pp_rxskb); > - priv->pp_rxskb = 0; > - > -#endif > + DMESGE("Endpoint Alloc Failure"); > + return -ENOMEM; > } > -#endif > > static void rtl8192_update_ratr_table(struct net_device *dev); > static void rtl8192_link_change(struct net_device *dev) > -- > 2.7.4 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. > To post to this group, send email to [email protected]. > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/20170302214748.GA9824%40 fireworks. > For more options, visit https://groups.google.com/d/optout. >--
You received this message because you are subscribed to the Google Groups
"outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/c35613c8-a4c0-41c5-852e- 56f226f81a24%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Quoted 41 lines · Georgiana Chelu
Quoted 18 lines · Julia Lawall
Quoted 14 lines · Georgiana Chelu
I compared my local file with the git patch and it seems that something went wrong.
I would not expect something like this.This is how the two functions (
rtl8192_usb_initendpointsandrtl8192_usb_deleteendpoints)
from my local file look like: http://pastebin.com/9SJaYkdi .Maybe I should create two commits. The first commit moves the delete function above
the init one, and the second commit makes my changes on checking the memory allocation.Quoted 6 lines
Quoted 1 line
What do you think?
Don't top post :) I'm guessing that this refers to the kfree issue, but it would be clearer if this comment were next to the code that it is referring to.
Hi Julia,
Thank you for your advice. I will improve my online communication.
Quoted 4 lines
In your paste, you have a kfree on line 123 just below a call to
rtl8192_usb_deleteendpoints, and that function also appears to free the same value, if it is not NULL.Yes, you are right. I missed that I have already freed the
priv->rx_urb.Quoted 3 lines
Also, I wonder why you don't use the
rtl8192_usb_deleteendpointsfunction in the case that the final kcalloc fails (lines 108-116 in the paste.
Quoted 5 lines
I will make the changes and send a new patch.
Also, to make sure that git does not mess the patch, should I create two patches? The first that moves the delete function above the init one and the second that handles properly the check for memory allocation?
Indeed, diff is not always good at dealing with code moves. So it could be a good idea to split them. The commit message could be something like "Move the functions in preparation for using them from the XXX function".
julia
Quoted 271 lines
Regards,
GeorgianaQuoted 258 lines
julia
Quoted 256 lines
Georgiana
On Friday, 3 March 2017 21:50:07 UTC+2, Julia Lawall wrote:
On Thu, 2 Mar 2017, Georgiana Rodica Chelu wrote: > Check if the allocation is not successful and > return the error code -ENOMEM. > > Signed-off-by: Georgiana Rodica Chelu <[email protected]> > --- > > Changes in v2: > - use a goto pattern to handle the allocation fails > - use exiting a function to free the memory in case of fail > - move the free function above the initialization > > Changes in v3: > - free the r8192_priv structure in case one of the urb > allocation fails > - break the loop when an uninitialized pointer is reached > > drivers/staging/rtl8192u/r8192U_core.c | 120 +++++++++++++++++++-------------- > 1 file changed, 70 insertions(+), 50 deletions(-) > > diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c > index b631990..11210e3 100644 > --- a/drivers/staging/rtl8192u/r8192U_core.c > +++ b/drivers/staging/rtl8192u/r8192U_core.c > @@ -1677,11 +1677,68 @@ short rtl8192_tx(struct net_device *dev, struct sk_buff *skb) > return -1; > } > > +#ifdef THOMAS_BEACON > +static void rtl8192_usb_deleteendpoints(struct net_device *dev) > +{ > + int i; > + struct r8192_priv *priv = ieee80211_priv(dev); > + > + if (priv->rx_urb) { > + for (i = 0; i < (MAX_RX_URB + 1); i++) { > + usb_kill_urb(priv->rx_urb[i]); > + usb_free_urb(priv->rx_urb[i]); > + } > + kfree(priv->rx_urb); > + priv->rx_urb = NULL; > + } > + kfree(priv->oldaddr); > + priv->oldaddr = NULL; > + > + kfree(priv->pp_rxskb); > + priv->pp_rxskb = NULL; > +} > +#else > +void rtl8192_usb_deleteendpoints(struct net_device *dev) > +{ > + int i; > + struct r8192_priv *priv = ieee80211_priv(dev); > + > +#ifndef JACKSON_NEW_RX > + > + if (priv->rx_urb) { > + for (i = 0; i < (MAX_RX_URB + 1); i++) { > + if(!priv->rx_urb[i]) > + break; > + usb_kill_urb(priv->rx_urb[i]); > + if(!riv->rx_urb[i]->transfer_buffer) > + break; > + kfree(priv->rx_urb[i]->transfer_buffer); > + usb_free_urb(priv->rx_urb[i]); > + } > + > + if(i < (MAX_RX_URB + 1)) > + usb_free_urb(priv->rx_urb[i]); > + kfree(priv->rx_urb); > + priv->rx_urb = NULL; > + } > +#else > + kfree(priv->rx_urb); > + priv->rx_urb = NULL; > + kfree(priv->oldaddr); > + priv->oldaddr = NULL; > + > + kfree(priv->pp_rxskb); > + priv->pp_rxskb = 0; It's odd to kfree something, implying that there is a pointer, and then set the same thing to 0 (rather than NULL). > + > +#endif > +} > +#endif > + > static short rtl8192_usb_initendpoints(struct net_device *dev) > { > struct r8192_priv *priv = ieee80211_priv(dev); > > - priv->rx_urb = kmalloc(sizeof(struct urb *) * (MAX_RX_URB + 1), > + priv->rx_urb = kzalloc(sizeof(struct urb *) * (MAX_RX_URB + 1), > GFP_KERNEL); > if (!priv->rx_urb) > return -ENOMEM; > @@ -1689,9 +1746,13 @@ static short rtl8192_usb_initendpoints(struct net_device *dev) > #ifndef JACKSON_NEW_RX > for (i = 0; i < (MAX_RX_URB + 1); i++) { > priv->rx_urb[i] = usb_alloc_urb(0, GFP_KERNEL); > + if(!priv->rx_urb[i]) > + goto exit; > > priv->rx_urb[i]->transfer_buffer = > - kmalloc(RX_URB_SIZE, GFP_KERNEL); > + kzalloc(RX_URB_SIZE, GFP_KERNEL); I don't think this one has to be kzalloc. No one is looking in the uninitialized parts of it. > + if(!priv->rx_urb[i]->transfer_buffer) > + goto exit; > > priv->rx_urb[i]->transfer_buffer_length = RX_URB_SIZE; > } > @@ -1704,6 +1765,9 @@ static short rtl8192_usb_initendpoints(struct net_device *dev) > > priv->rx_urb[16] = usb_alloc_urb(0, GFP_KERNEL); > priv->oldaddr = kmalloc(16, GFP_KERNEL); > + if(!priv->oldaddr) > + goto exit; > + > oldaddr = priv->oldaddr; > align = ((long)oldaddr) & 3; > if (align) { > @@ -1732,57 +1796,13 @@ static short rtl8192_usb_initendpoints(struct net_device *dev) > > netdev_dbg(dev, "End of initendpoints\n"); > return 0; > -} > - > -#ifdef THOMAS_BEACON > -static void rtl8192_usb_deleteendpoints(struct net_device *dev) > -{ > - int i; > - struct r8192_priv *priv = ieee80211_priv(dev); > - > - if (priv->rx_urb) { > - for (i = 0; i < (MAX_RX_URB + 1); i++) { > - usb_kill_urb(priv->rx_urb[i]); > - usb_free_urb(priv->rx_urb[i]); > - } > - kfree(priv->rx_urb); > - priv->rx_urb = NULL; > - } > - kfree(priv->oldaddr); > - priv->oldaddr = NULL; > - > - kfree(priv->pp_rxskb); > - priv->pp_rxskb = NULL; > -} > -#else > -void rtl8192_usb_deleteendpoints(struct net_device *dev) > -{ > - int i; > - struct r8192_priv *priv = ieee80211_priv(dev); > > -#ifndef JACKSON_NEW_RX > - > - if (priv->rx_urb) { > - for (i = 0; i < (MAX_RX_URB + 1); i++) { > - usb_kill_urb(priv->rx_urb[i]); > - kfree(priv->rx_urb[i]->transfer_buffer); > - usb_free_urb(priv->rx_urb[i]); > - } > - kfree(priv->rx_urb); > - priv->rx_urb = NULL; > - } > -#else > +exit: > + rtl8192_usb_deleteendpoints(dev); > kfree(priv->rx_urb); > - priv->rx_urb = NULL; It looks suspicious to keep the kfree but drop the NULL initization. I have the impression that the kfree should go to, but perhaps this is just an artifact of the diff algorithm, and the kfree is doing filling a different purpose in the transformed code than in the original code. julia > - kfree(priv->oldaddr); > - priv->oldaddr = NULL; > - > - kfree(priv->pp_rxskb); > - priv->pp_rxskb = 0; > - > -#endif > + DMESGE("Endpoint Alloc Failure"); > + return -ENOMEM; > } > -#endif > > static void rtl8192_update_ratr_table(struct net_device *dev); > static void rtl8192_link_change(struct net_device *dev) > -- > 2.7.4 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. > To post to this group, send email to [email protected]. > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/20170302214748.GA9824%40 fireworks. > For more options, visit https://groups.google.com/d/optout. >--
You received this message because you are subscribed to the Google Groups
"outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/c35613c8-a4c0-41c5-852e- 56f226f81a24%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CALta04yB%3DL4cZN5o45niuDaPNzmPRMd%3DoDeO7Xj5Z660WjiGPQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.