Skip to contentSkip to conversation

phy: fix build error in phy-bcm-nsp-usb3 with COMPILE_TEST

PATCH In review Tobias Regnery 2 participants 2 messages Mar 7, 2017 – Mar 23, 2017 Generic PHY framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 phy: fix build error in phy-bcm-nsp-usb3 with COMPILE_TEST

I see the following build error with COMPILE_TEST on randconfig builds:

divers/built-in.o: In function `nsp_usb3_phy_init':
phy-bcm-nsp-usb3.c:(.text+0x4050): undefined reference to mdiobus_write' phy-bcm-nsp-usb3.c:(.text+0x406c): undefined reference to mdiobus_write' phy-bcm-nsp-usb3.c:(.text+0x4088): undefined reference to mdiobus_write' phy-bcm-nsp-usb3.c:(.text+0x40a4): undefined reference to mdiobus_write' phy-bcm-nsp-usb3.c:(.text+0x40c0): undefined reference to mdiobus_write' drivers/built-in.o:phy-bcm-nsp-usb3.c:(.text+0x40f2): more undefined references to mdiobus_write' follow drivers/built-in.o: In function `mdio_module_init':
phy-bcm-nsp-usb3.c:(.init.text+0x134): undefined reference to mdio_driver_register' drivers/built-in.o: In function mdio_module_exit':
phy-bcm-nsp-usb3.c:(.exit.text+0xcc): undefined reference to `mdio_driver_unregister'

Fix this by adding the correct Kconfig dependency.

---
 drivers/phy/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/phy/Kconfig +1 -1
index dc5277ad1b5a..10e06f0f1dce 100644
@@ -512,7 +512,7 @@ config PHY_MESON8B_USB2
 
 config PHY_NSP_USB3
 	tristate "Broadcom NorthStar plus USB3 PHY driver"
-	depends on OF && (ARCH_BCM_NSP || COMPILE_TEST)
+	depends on OF && OF_MDIO && (ARCH_BCM_NSP || COMPILE_TEST)
 	select GENERIC_PHY
 	default ARCH_BCM_NSP
 	help
Signature · 1 line
2.11.0
#1 lore raw
Quoted 14 lines · Tobias Regnery

I see the following build error with COMPILE_TEST on randconfig builds:

divers/built-in.o: In function `nsp_usb3_phy_init':
phy-bcm-nsp-usb3.c:(.text+0x4050): undefined reference to mdiobus_write' phy-bcm-nsp-usb3.c:(.text+0x406c): undefined reference to mdiobus_write' phy-bcm-nsp-usb3.c:(.text+0x4088): undefined reference to mdiobus_write' phy-bcm-nsp-usb3.c:(.text+0x40a4): undefined reference to mdiobus_write' phy-bcm-nsp-usb3.c:(.text+0x40c0): undefined reference to mdiobus_write' drivers/built-in.o:phy-bcm-nsp-usb3.c:(.text+0x40f2): more undefined references to mdiobus_write' follow drivers/built-in.o: In function `mdio_module_init':
phy-bcm-nsp-usb3.c:(.init.text+0x134): undefined reference to mdio_driver_register' drivers/built-in.o: In function mdio_module_exit':
phy-bcm-nsp-usb3.c:(.exit.text+0xcc): undefined reference to `mdio_driver_unregister'

Quoted 1 line

Fix this by adding the correct Kconfig dependency.

This patch looks fine, but this driver is being reverted in Kishon's "fixes" branch. See
https://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.git/commit/?h=fixes&id=9200c6f177638909dbbaded8aeeeccbd48744400

Thanks,
Jon

Quoted 22 lines
---
 drivers/phy/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/phy/Kconfig +1 -1
index dc5277ad1b5a..10e06f0f1dce 100644
@@ -512,7 +512,7 @@ config PHY_MESON8B_USB2
 
 config PHY_NSP_USB3
 	tristate "Broadcom NorthStar plus USB3 PHY driver"
-	depends on OF && (ARCH_BCM_NSP || COMPILE_TEST)
+	depends on OF && OF_MDIO && (ARCH_BCM_NSP || COMPILE_TEST)
 	select GENERIC_PHY
 	default ARCH_BCM_NSP
 	help
Signature · 1 line
2.11.0