mceusb: fix NULL-deref at probe
Subsystems (3)
PATCH 1/1 mceusb: fix NULL-deref at probe
Make sure to check for the required out endpoint to avoid dereferencing a NULL-pointer in mce_request_packet should a malicious device lack such an endpoint. Note that this path it hit during probe.
Fixes 66e89522aff7 ("V4L/DVB: IR: add mceusb IR receiver driver")
Cc stable <[email protected]> # 2.6.36
Signed-off-by Johan Hovold <[email protected]>
---
Found through inspection, compile tested only.
Johan
drivers/media/rc/mceusb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/media/rc/mceusb.c +2 -2
@@ -1288,8 +1288,8 @@ static int mceusb_dev_probe(struct usb_interface *intf, } } } -if (ep_in ==NULL ) { -dev_dbg (&intf->dev,"inbound and/or endpoint not found" ); +if (!ep_in || !ep_out) { +dev_dbg (&intf->dev,"required endpoints not found\n" );return -ENODEV ; }
Signature · 1 line
2.12.0