checkpatch cleanups
Subsystems (2)
cover checkpatch cleanups
Improve readability by fixing multiple checkpatch.pl issues in speakup driver.
Arushi Singhal (2):
staging: speakup: identation should use tabs
staging: dvb-frontends: removed code in comments.
drivers/media/dvb-frontends/drxk_hard.c | 1 - drivers/staging/speakup/speakup_dtlk.h | 10 +++++----- 2 files changed, 5 insertions(+), 6 deletions(-)
Signature · 1 line
2.11.0
PATCH 1/2 staging: speakup: identation should use tabs
Indentation should always use tabs and never spaces.
--- drivers/staging/speakup/speakup_dtlk.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/staging/speakup/speakup_dtlk.h +5 -5
@@ -24,11 +24,11 @@* usec later. */ #define TTS_ALMOST_FULL 0x08/* mask for AF bit: When set to 1, -* indicates that less than 300 bytes -* are available in the TTS input -* buffer. AF is always 0 in the PCM, -* TGN and CVSD modes. -*/ +* indicates that less than 300 bytes +* are available in the TTS input +* buffer. AF is always 0 in the PCM, +* TGN and CVSD modes. +*/ #define TTS_ALMOST_EMPTY 0x04/* mask for AE bit: When set to 1, * indicates that less than 300 bytes * are remaining in DoubleTalk's input
Signature · 1 line
2.11.0
PATCH 2/2 staging: dvb-frontends: removed code in comments.
In reply to Arushi SinghalCommenting Code Is a Bad Idea.
Comments are their to explain the code and how the code achieves its goal and as codes in the comments does not explain what the code is doing so there is no use of commenting them.
So in this patch codes in the comments are removed.
--- drivers/media/dvb-frontends/drxk_hard.c | 1 - 1 file changed, 1 deletion(-)
drivers/media/dvb-frontends/drxk_hard.c +0 -1
@@ -5283,7 +5283,6 @@ static int qam_set_symbolrate(struct drxk_state *state)/* Select & calculate correct IQM rate */ adc_frequency = (state->m_sys_clock_freq *1000 ) /3 ; ratesel =0 ; -/* printk(KERN_DEBUG "drxk: SR %d\n", state->props.symbol_rate); */ if (state->props.symbol_rate <=1188750 ) ratesel =3 ;else if (state->props.symbol_rate <=2377500 )
Signature · 1 line
2.11.0
Greg KH
maintainerRe: [PATCH 2/2] staging: dvb-frontends: removed code in comments.
Quoted 1 line · Arushi Singhal
Commenting Code Is a Bad Idea.
No, "Commenting code is a good idea". I think you mean "commenting out code is a bad idea", correct?
And no need for putting the sentance in all caps.
thanks,
greg k-h