Skip to contentSkip to conversation

staging: speakup: Comparison to NULL could be written

PATCH In review Arushi Singhal 2 participants 2 messages Mar 10, 2017 – Mar 12, 2017 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: speakup: Comparison to NULL could be written

Fixed coding style for null comparisons in speakup driver to be more consistant with the rest of the kernel coding style.

---
 drivers/staging/speakup/selection.c   | 2 +-
 drivers/staging/speakup/varhandlers.c | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/staging/speakup/selection.c +1 -1
index 3d15eec37163..08f68fc2864e 100644
@@ -175,7 +175,7 @@ static struct speakup_paste_work speakup_paste_work = {
 
 int speakup_paste_selection(struct tty_struct *tty)
 {
-	if (cmpxchg(&speakup_paste_work.tty, NULL, tty) != NULL)
+	if (cmpxchg(&speakup_paste_work.tty, NULL, tty))
 		return -EBUSY;
 
 	tty_kref_get(tty);
drivers/staging/speakup/varhandlers.c +3 -3
index cc984196020f..5910fe0b1365 100644
@@ -98,7 +98,7 @@ void speakup_register_var(struct var_t *var)
 		}
 	}
 	p_header = var_ptrs[var->var_id];
-	if (p_header->data != NULL)
+	if (p_header->data)
 		return;
 	p_header->data = var;
 	switch (p_header->var_type) {
@@ -210,11 +210,11 @@ int spk_set_num_var(int input, struct st_var_header *var, int how)
 		return -ERANGE;
 
 	var_data->u.n.value = val;
-	if (var->var_type == VAR_TIME && p_val != NULL) {
+	if (var->var_type == VAR_TIME && p_val) {
 		*p_val = msecs_to_jiffies(val);
 		return 0;
 	}
-	if (p_val != NULL)
+	if (p_val)
 		*p_val = val;
 	if (var->var_id == PUNC_LEVEL) {
 		spk_punc_mask = spk_punc_masks[val];
Signature · 1 line
2.11.0
#1 lore raw
Quoted 8 lines · Arushi Singhal

Fixed coding style for null comparisons in speakup driver to be more consistant with the rest of the kernel coding style.

---
 drivers/staging/speakup/selection.c   | 2 +-
 drivers/staging/speakup/varhandlers.c | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

I have over 25 patches from you for this driver, and I have no idea what ones I should be applying and in what order. So I've had to delete them all from my queue. Please rebase your series on the latest staging-testing branch and resend, as a single patch series, what you wish to have reviewed and potentially applied.

thanks,

greg k-h