Skip to contentSkip to conversation

ASoC: cs35l35: returning uninitialized in probe()

PATCH In review Dan Carpenter 3 participants 3 messages Mar 13, 2017

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: cs35l35: returning uninitialized in probe()

If cs35l35->pdata.stereo is false then "ret" isn't initialized.

Fixes 6387f866a2cc ("ASoC: Add support for Cirrus Logic CS35L35 Amplifier")
sound/soc/codecs/cs35l35.c +1 -1
index 260ed42c71e9..142ae642eaa1 100644
@@ -964,7 +964,7 @@ static int cs35l35_codec_probe(struct snd_soc_codec *codec)
 		}
 	}
 
-	return ret;
+	return 0;
 }
 
 static struct snd_soc_codec_driver soc_codec_dev_cs35l35 = {
Acked-by on v1 1/1
#1 lore raw
Quoted 11 lines · Dan Carpenter

If cs35l35->pdata.stereo is false then "ret" isn't initialized.

Fixes 6387f866a2cc ("ASoC: Add support for Cirrus Logic CS35L35 Amplifier")
sound/soc/codecs/cs35l35.c +0 -0
index 260ed42c71e9..142ae642eaa1 100644

sound/soc/codecs/cs35l35.c static int cs35l35_codec_probe(struct snd_soc_codec *codec) · line 970

Quoted 8 lines
sound/soc/codecs/cs35l35.c +1 -1
@@ -964,7 +964,7 @@ static int cs35l35_codec_probe(struct snd_soc_codec *codec)
 		}
 	}
 
-	return ret;
+	return 0;
 }
 
 static struct snd_soc_codec_driver soc_codec_dev_cs35l35 = {
maintainer
#2 lore raw

Applied "ASoC: cs35l35: returning uninitialized in probe()" to the asoc tree

In reply to Dan Carpenter

The patch

ASoC: cs35l35: returning uninitialized in probe()

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From bfe41c678d49f440de3ae80b945f7f94d5dbd340 Mon Sep 17 00:00:00 2001

From: Dan Carpenter <[email protected]>
Date: Mon, 13 Mar 2017 15:32:37 +0300
Subject: [PATCH] ASoC: cs35l35: returning uninitialized in probe()

If cs35l35->pdata.stereo is false then "ret" isn't initialized.

Fixes 6387f866a2cc ("ASoC: Add support for Cirrus Logic CS35L35 Amplifier")
---
 sound/soc/codecs/cs35l35.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/cs35l35.c +1 -1
index 6a266516f543..05117fca7e3c 100644
@@ -969,7 +969,7 @@ static int cs35l35_codec_probe(struct snd_soc_codec *codec)
 		}
 	}
 
-	return ret;
+	return 0;
 }
 
 static struct snd_soc_codec_driver soc_codec_dev_cs35l35 = {
Signature · 1 line
2.11.0