Skip to contentSkip to conversation

drm/amdgpu: remove unneeded conversions to bool

PATCH Applied Andrew F. Davis 2 participants 3 messages Mar 15, 2017 – Mar 16, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 drm/amdgpu: remove unneeded conversions to bool

Found with scripts/coccinelle/misc/boolconv.cocci.

---

Changes from v1:
- Rebased on v4.11-rc1
- Added Reviewed-by

 drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c  |  4 ++--
 drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c  |  4 ++--
 drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c |  4 ++--
 drivers/gpu/drm/amd/amdgpu/vi.c        | 16 ++++++++--------
 4 files changed, 14 insertions(+), 14 deletions(-)
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c +2 -2
index 67afc901905c..52f39d8627de 100644
@@ -5839,7 +5839,7 @@ static int gfx_v8_0_set_powergating_state(void *handle,
 					  enum amd_powergating_state state)
 {
 	struct amdgpu_device *adev = (struct amdgpu_device *)handle;
-	bool enable = (state == AMD_PG_STATE_GATE) ? true : false;
+	bool enable = (state == AMD_PG_STATE_GATE);
 
 	switch (adev->asic_type) {
 	case CHIP_CARRIZO:
@@ -6416,7 +6416,7 @@ static int gfx_v8_0_set_clockgating_state(void *handle,
 	case CHIP_CARRIZO:
 	case CHIP_STONEY:
 		gfx_v8_0_update_gfx_clock_gating(adev,
-						 state == AMD_CG_STATE_GATE ? true : false);
+						 state == AMD_CG_STATE_GATE);
 		break;
 	case CHIP_TONGA:
 		gfx_v8_0_tonga_update_gfx_clock_gating(adev, state);
drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c +2 -2
index 7669b3259f35..e570decc2d23 100644
@@ -1430,9 +1430,9 @@ static int gmc_v8_0_set_clockgating_state(void *handle,
 	switch (adev->asic_type) {
 	case CHIP_FIJI:
 		fiji_update_mc_medium_grain_clock_gating(adev,
-				state == AMD_CG_STATE_GATE ? true : false);
+				state == AMD_CG_STATE_GATE);
 		fiji_update_mc_light_sleep(adev,
-				state == AMD_CG_STATE_GATE ? true : false);
+				state == AMD_CG_STATE_GATE);
 		break;
 	default:
 		break;
drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c +2 -2
index 31375bdde6f1..db02bc6a2fa2 100644
@@ -1517,9 +1517,9 @@ static int sdma_v3_0_set_clockgating_state(void *handle,
 	case CHIP_CARRIZO:
 	case CHIP_STONEY:
 		sdma_v3_0_update_sdma_medium_grain_clock_gating(adev,
-				state == AMD_CG_STATE_GATE ? true : false);
+				state == AMD_CG_STATE_GATE);
 		sdma_v3_0_update_sdma_medium_grain_light_sleep(adev,
-				state == AMD_CG_STATE_GATE ? true : false);
+				state == AMD_CG_STATE_GATE);
 		break;
 	default:
 		break;
drivers/gpu/drm/amd/amdgpu/vi.c +8 -8
index 50bdb24ef8d6..8e71b74d5a15 100644
@@ -1394,24 +1394,24 @@ static int vi_common_set_clockgating_state(void *handle,
 	switch (adev->asic_type) {
 	case CHIP_FIJI:
 		vi_update_bif_medium_grain_light_sleep(adev,
-				state == AMD_CG_STATE_GATE ? true : false);
+				state == AMD_CG_STATE_GATE);
 		vi_update_hdp_medium_grain_clock_gating(adev,
-				state == AMD_CG_STATE_GATE ? true : false);
+				state == AMD_CG_STATE_GATE);
 		vi_update_hdp_light_sleep(adev,
-				state == AMD_CG_STATE_GATE ? true : false);
+				state == AMD_CG_STATE_GATE);
 		vi_update_rom_medium_grain_clock_gating(adev,
-				state == AMD_CG_STATE_GATE ? true : false);
+				state == AMD_CG_STATE_GATE);
 		break;
 	case CHIP_CARRIZO:
 	case CHIP_STONEY:
 		vi_update_bif_medium_grain_light_sleep(adev,
-				state == AMD_CG_STATE_GATE ? true : false);
+				state == AMD_CG_STATE_GATE);
 		vi_update_hdp_medium_grain_clock_gating(adev,
-				state == AMD_CG_STATE_GATE ? true : false);
+				state == AMD_CG_STATE_GATE);
 		vi_update_hdp_light_sleep(adev,
-				state == AMD_CG_STATE_GATE ? true : false);
+				state == AMD_CG_STATE_GATE);
 		vi_update_drm_light_sleep(adev,
-				state == AMD_CG_STATE_GATE ? true : false);
+				state == AMD_CG_STATE_GATE);
 		break;
 	case CHIP_TONGA:
 	case CHIP_POLARIS10:
Signature · 1 line
2.11.0
#1 lore raw

PATCH v2 2/2 drm/amd/powerplay: remove unneeded conversions to bool

Found with scripts/coccinelle/misc/boolconv.cocci.

---

Changes from v1:
- Rebased on v4.11-rc1
- Added Reviewed-by

 drivers/gpu/drm/amd/powerplay/amd_powerplay.c         | 2 +-
 drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/powerplay/amd_powerplay.c +1 -1
index 429f18b99323..1d27bd22e0c1 100644
@@ -239,7 +239,7 @@ static int pp_set_powergating_state(void *handle,
 
 	/* Enable/disable GFX per cu powergating through SMU */
 	return hwmgr->hwmgr_func->enable_per_cu_power_gating(hwmgr,
-			state == AMD_PG_STATE_GATE ? true : false);
+			state == AMD_PG_STATE_GATE);
 }
 
 static int pp_suspend(void *handle)
drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c +1 -1
index 0eb8e886bf35..a317a832a33a 100644
@@ -113,7 +113,7 @@ int phm_enable_dynamic_state_management(struct pp_hwmgr *hwmgr)
 				NULL, NULL);
 	}
 
-	enabled = ret == 0 ? true : false;
+	enabled = ret == 0;
 
 	cgs_notify_dpm_enabled(hwmgr->device, enabled);
 
Signature · 1 line
2.11.0
Applied
#2 lore raw
In reply to Andrew F. Davis
Quoted 9 lines · Andrew F. Davis

Found with scripts/coccinelle/misc/boolconv.cocci.

---

Changes from v1:
- Rebased on v4.11-rc1
- Added Reviewed-by

Applied the series. thanks,

Alex

Quoted 101 lines
 drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c  |  4 ++--
 drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c  |  4 ++--
 drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c |  4 ++--
 drivers/gpu/drm/amd/amdgpu/vi.c        | 16 ++++++++--------
 4 files changed, 14 insertions(+), 14 deletions(-)
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c +2 -2
index 67afc901905c..52f39d8627de 100644
@@ -5839,7 +5839,7 @@ static int gfx_v8_0_set_powergating_state(void *handle,
                                          enum amd_powergating_state state)
 {
        struct amdgpu_device *adev = (struct amdgpu_device *)handle;
-       bool enable = (state == AMD_PG_STATE_GATE) ? true : false;
+       bool enable = (state == AMD_PG_STATE_GATE);
 
        switch (adev->asic_type) {
        case CHIP_CARRIZO:
@@ -6416,7 +6416,7 @@ static int gfx_v8_0_set_clockgating_state(void *handle,
        case CHIP_CARRIZO:
        case CHIP_STONEY:
                gfx_v8_0_update_gfx_clock_gating(adev,
-                                                state == AMD_CG_STATE_GATE ? true : false);
+                                                state == AMD_CG_STATE_GATE);
                break;
        case CHIP_TONGA:
                gfx_v8_0_tonga_update_gfx_clock_gating(adev, state);
drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c +2 -2
index 7669b3259f35..e570decc2d23 100644
@@ -1430,9 +1430,9 @@ static int gmc_v8_0_set_clockgating_state(void *handle,
        switch (adev->asic_type) {
        case CHIP_FIJI:
                fiji_update_mc_medium_grain_clock_gating(adev,
-                               state == AMD_CG_STATE_GATE ? true : false);
+                               state == AMD_CG_STATE_GATE);
                fiji_update_mc_light_sleep(adev,
-                               state == AMD_CG_STATE_GATE ? true : false);
+                               state == AMD_CG_STATE_GATE);
                break;
        default:
                break;
drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c +2 -2
index 31375bdde6f1..db02bc6a2fa2 100644
@@ -1517,9 +1517,9 @@ static int sdma_v3_0_set_clockgating_state(void *handle,
        case CHIP_CARRIZO:
        case CHIP_STONEY:
                sdma_v3_0_update_sdma_medium_grain_clock_gating(adev,
-                               state == AMD_CG_STATE_GATE ? true : false);
+                               state == AMD_CG_STATE_GATE);
                sdma_v3_0_update_sdma_medium_grain_light_sleep(adev,
-                               state == AMD_CG_STATE_GATE ? true : false);
+                               state == AMD_CG_STATE_GATE);
                break;
        default:
                break;
drivers/gpu/drm/amd/amdgpu/vi.c +8 -9
index 50bdb24ef8d6..8e71b74d5a15 100644
@@ -1394,24 +1394,24 @@ static int vi_common_set_clockgating_state(void *handle,
        switch (adev->asic_type) {
        case CHIP_FIJI:
                vi_update_bif_medium_grain_light_sleep(adev,
-                               state == AMD_CG_STATE_GATE ? true : false);
+                               state == AMD_CG_STATE_GATE);
                vi_update_hdp_medium_grain_clock_gating(adev,
-                               state == AMD_CG_STATE_GATE ? true : false);
+                               state == AMD_CG_STATE_GATE);
                vi_update_hdp_light_sleep(adev,
-                               state == AMD_CG_STATE_GATE ? true : false);
+                               state == AMD_CG_STATE_GATE);
                vi_update_rom_medium_grain_clock_gating(adev,
-                               state == AMD_CG_STATE_GATE ? true : false);
+                               state == AMD_CG_STATE_GATE);
                break;
        case CHIP_CARRIZO:
        case CHIP_STONEY:
                vi_update_bif_medium_grain_light_sleep(adev,
-                               state == AMD_CG_STATE_GATE ? true : false);
+                               state == AMD_CG_STATE_GATE);
                vi_update_hdp_medium_grain_clock_gating(adev,
-                               state == AMD_CG_STATE_GATE ? true : false);
+                               state == AMD_CG_STATE_GATE);
                vi_update_hdp_light_sleep(adev,
-                               state == AMD_CG_STATE_GATE ? true : false);
+                               state == AMD_CG_STATE_GATE);
                vi_update_drm_light_sleep(adev,
-                               state == AMD_CG_STATE_GATE ? true : false);
+                               state == AMD_CG_STATE_GATE);
                break;
        case CHIP_TONGA:
        case CHIP_POLARIS10:
--

2.11.0

Quoted 4 lines

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel