drm/i915/guc: Correct the request_in tracepoint position
Subsystems (2)
Tvrtko Ursulin
maintainerPATCH 1/1 drm/i915/guc: Correct the request_in tracepoint position
From: Tvrtko Ursulin <[email protected]>
It has to be called after the global seqno has been assigned.
--- drivers/gpu/drm/i915/i915_guc_submission.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_guc_submission.c +1 -1
@@ -597,8 +597,8 @@ static bool i915_guc_dequeue(struct intel_engine_cs *engine)RB_CLEAR_NODE (&rq->priotree.node); rq->priotree.priority =INT_MAX ; -trace_i915_gem_request_in (rq, port - engine->execlist_port);i915_guc_submit (rq); +trace_i915_gem_request_in (rq, port - engine->execlist_port); last = rq; submit = true; }
Signature · 6 lines
2.9.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 7 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
It has to be called after the global seqno has been assigned.
Signed-off-by Tvrtko Ursulin <[email protected]>Fixes 31de73501ac9 ("drm/i915/scheduler: emulate a scheduler for guc")Cc Chris Wilson <[email protected]>
So be it. Your script is ready for the same request to be submitted multiple times with different global_seqno?
-Chris
Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 10 lines · Chris Wilson
Quoted 7 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
It has to be called after the global seqno has been assigned.
Signed-off-by Tvrtko Ursulin <[email protected]>Fixes 31de73501ac9 ("drm/i915/scheduler: emulate a scheduler for guc")Cc Chris Wilson <[email protected]>So be it. Your script is ready for the same request to be submitted
Why so be it? It matches the one in execlists and is logical.
Quoted 1 line
multiple times with different
global_seqno?
Nope, but it survived the zero global seqno unexpectedly well! :)
Quoted 1 line
Reviewed-by Chris Wilson <[email protected]>
Thanks!
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 7 lines · Tvrtko Ursulin
Quoted 5 lines · Chris Wilson
Quoted 4 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
It has to be called after the global seqno has been assigned.
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Signed-off-by Tvrtko Ursulin <[email protected]>Fixes 31de73501ac9 ("drm/i915/scheduler: emulate a scheduler for guc")Cc Chris Wilson <[email protected]>So be it. Your script is ready for the same request to be submitted
Why so be it? It matches the one in execlists and is logical.
Just the staircasing, that's all.
-Chris
Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915/guc: Correct the request_in tracepoint position
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: drm/i915/guc: Correct the request_in tracepoint position
URL : https://patchwork.freedesktop.org/series/21538/
State : success
== Summary ==
Series 21538v1 drm/i915/guc: Correct the request_in tracepoint position
https://patchwork.freedesktop.org/api/1.0/series/21538/revisions/1/mbox/
Test gem_exec_suspend:
Subgroup basic-s4-devices:
pass -> DMESG-WARN (fi-bxt-t5700) fdo#100125fdo#100125 https://bugs.freedesktop.org/show_bug.cgi?id=100125
fi-bdw-5557u total:278 pass:267 dwarn:0 dfail:0 fail:0 skip:11 time: 460s fi-bsw-n3050 total:278 pass:239 dwarn:0 dfail:0 fail:0 skip:39 time: 574s fi-bxt-j4205 total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time: 532s fi-bxt-t5700 total:278 pass:257 dwarn:1 dfail:0 fail:0 skip:20 time: 559s fi-byt-j1900 total:278 pass:251 dwarn:0 dfail:0 fail:0 skip:27 time: 498s fi-byt-n2820 total:278 pass:247 dwarn:0 dfail:0 fail:0 skip:31 time: 495s fi-hsw-4770 total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time: 433s fi-hsw-4770r total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time: 437s fi-ilk-650 total:278 pass:228 dwarn:0 dfail:0 fail:0 skip:50 time: 438s fi-ivb-3520m total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time: 515s fi-ivb-3770 total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time: 494s fi-kbl-7500u total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time: 482s fi-skl-6260u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time: 477s fi-skl-6700hq total:278 pass:261 dwarn:0 dfail:0 fail:0 skip:17 time: 595s fi-skl-6700k total:278 pass:256 dwarn:4 dfail:0 fail:0 skip:18 time: 484s fi-skl-6770hq total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time: 515s fi-snb-2520m total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time: 552s fi-snb-2600 total:278 pass:248 dwarn:0 dfail:0 fail:1 skip:29 time: 425s
3f1ca80b4b2cd698202fc8121029bdc094bf7d7f drm-tip: 2017y-03m-20d-10h-48m-39s UTC integration manifest b69cfd8 drm/i915/guc: Correct the request_in tracepoint position
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4228/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✓ Fi.CI.BAT: success for drm/i915/guc: Correct the request_in tracepoint position
Quoted 36 lines · Patchwork
== Series Details ==
Series: drm/i915/guc: Correct the
request_intracepoint position
URL : https://patchwork.freedesktop.org/series/21538/
State : success== Summary ==
Series 21538v1 drm/i915/guc: Correct the
request_intracepoint position
https://patchwork.freedesktop.org/api/1.0/series/21538/revisions/1/mbox/Test
gem_exec_suspend:Subgroup basic-s4-devices: pass -> DMESG-WARN (fi-bxt-t5700) fdo#100125fdo#100125 https://bugs.freedesktop.org/show_bug.cgi?id=100125
fi-bdw-5557u total:278 pass:267 dwarn:0 dfail:0 fail:0 skip:11 time: 460s fi-bsw-n3050 total:278 pass:239 dwarn:0 dfail:0 fail:0 skip:39 time: 574s fi-bxt-j4205 total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time: 532s fi-bxt-t5700 total:278 pass:257 dwarn:1 dfail:0 fail:0 skip:20 time: 559s fi-byt-j1900 total:278 pass:251 dwarn:0 dfail:0 fail:0 skip:27 time: 498s fi-byt-n2820 total:278 pass:247 dwarn:0 dfail:0 fail:0 skip:31 time: 495s fi-hsw-4770 total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time: 433s fi-hsw-4770r total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time: 437s fi-ilk-650 total:278 pass:228 dwarn:0 dfail:0 fail:0 skip:50 time: 438s fi-ivb-3520m total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time: 515s fi-ivb-3770 total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time: 494s fi-kbl-7500u total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time: 482s fi-skl-6260u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time: 477s fi-skl-6700hq total:278 pass:261 dwarn:0 dfail:0 fail:0 skip:17 time: 595s fi-skl-6700k total:278 pass:256 dwarn:4 dfail:0 fail:0 skip:18 time: 484s fi-skl-6770hq total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time: 515s fi-snb-2520m total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time: 552s fi-snb-2600 total:278 pass:248 dwarn:0 dfail:0 fail:1 skip:29 time: 425s
Quoted 2 lines
3f1ca80b4b2cd698202fc8121029bdc094bf7d7fdrm-tip: 2017y-03m-20d-10h-48m-39s UTC integration manifest b69cfd8 drm/i915/guc: Correct therequest_intracepoint position
Pushed, thanks for the review!
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx