Skip to contentSkip to conversation

i2c-designware: increase timeout of semaphore transfer

PATCH In review Oliver Neukum 4 participants 4 messages Mar 20, 2017 – Mar 22, 2017

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i2c-designware: increase timeout of semaphore transfer

Our testing shows the semaphore failing to be transferred on CherryTrail in about 0.5% of all cases. The existing timeout needs to be lengthened to accomodate the worst cases.

V2: Rebased on https://cgit.freedesktop.org/drm-intel/commit/?h=topic/designware-baytrail

---
 drivers/i2c/busses/i2c-designware-baytrail.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/i2c-designware-baytrail.c +1 -1
index 1749a0f..c0e7c88 100644
@@ -22,7 +22,7 @@
 
 #include "i2c-designware-core.h"
 
-#define SEMAPHORE_TIMEOUT	100
+#define SEMAPHORE_TIMEOUT	500
 #define PUNIT_SEMAPHORE		0x7
 #define PUNIT_SEMAPHORE_CHT	0x10e
 #define PUNIT_SEMAPHORE_BIT	BIT(0)
Signature · 1 line
2.10.2
Reviewed-by on v1 1/1
#1 lore raw

Hi,

Quoted 7 lines · Oliver Neukum

Our testing shows the semaphore failing to be transferred on CherryTrail in about 0.5% of all cases. The existing timeout needs to be lengthened to accomodate the worst cases.

V2: Rebased on https://cgit.freedesktop.org/drm-intel/commit/?h=topic/designware-baytrail

Looks good to me:

Regards,

Hans

Quoted 18 lines
---
 drivers/i2c/busses/i2c-designware-baytrail.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/i2c-designware-baytrail.c +1 -1
index 1749a0f..c0e7c88 100644
@@ -22,7 +22,7 @@
 
 #include "i2c-designware-core.h"
 
-#define SEMAPHORE_TIMEOUT	100
+#define SEMAPHORE_TIMEOUT	500
 #define PUNIT_SEMAPHORE		0x7
 #define PUNIT_SEMAPHORE_CHT	0x10e
 #define PUNIT_SEMAPHORE_BIT	BIT(0)
Acked-by
#2 lore raw
Quoted 11 lines · Hans de Goede

Hi,

Quoted 8 lines · Oliver Neukum

Our testing shows the semaphore failing to be transferred on CherryTrail in about 0.5% of all cases. The existing timeout needs to be lengthened to accomodate the worst cases.

V2: Rebased on
https://cgit.freedesktop.org/drm-intel/commit/?h=topic/designware-baytrail

Quoted 6 lines
Quoted 1 line

Looks good to me:

#3 lore raw
In reply to Oliver Neukum
Quoted 7 lines · Oliver Neukum

Our testing shows the semaphore failing to be transferred on CherryTrail in about 0.5% of all cases. The existing timeout needs to be lengthened to accomodate the worst cases.

V2: Rebased on https://cgit.freedesktop.org/drm-intel/commit/?h=topic/designware-baytrail

Fixed this checkpatch issue:

WARNING: 'accomodate' may be misspelled - perhaps 'accommodate'?

and applied to for-next, thanks!