i2c-designware: increase timeout of semaphore transfer
Subsystems (3)
PATCH 1/1 i2c-designware: increase timeout of semaphore transfer
Our testing shows the semaphore failing to be transferred on CherryTrail in about 0.5% of all cases. The existing timeout needs to be lengthened to accomodate the worst cases.
V2: Rebased on https://cgit.freedesktop.org/drm-intel/commit/?h=topic/designware-baytrail
--- drivers/i2c/busses/i2c-designware-baytrail.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/i2c-designware-baytrail.c +1 -1
@@ -22,7 +22,7 @@#include "i2c-designware-core.h" -#define SEMAPHORE_TIMEOUT 100 +#define SEMAPHORE_TIMEOUT 500#define PUNIT_SEMAPHORE 0x7#define PUNIT_SEMAPHORE_CHT 0x10e#define PUNIT_SEMAPHORE_BIT BIT(0)
Signature · 1 line
2.10.2
Hi,
Quoted 7 lines · Oliver Neukum
Our testing shows the semaphore failing to be transferred on CherryTrail in about 0.5% of all cases. The existing timeout needs to be lengthened to accomodate the worst cases.
V2: Rebased on https://cgit.freedesktop.org/drm-intel/commit/?h=topic/designware-baytrail
Signed-off-by Oliver Neukum <[email protected]>
Looks good to me:
Regards,
Hans
Quoted 18 lines
--- drivers/i2c/busses/i2c-designware-baytrail.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/i2c/busses/i2c-designware-baytrail.c +1
-1@@ -22,7 +22,7 @@#include "i2c-designware-core.h" -#define SEMAPHORE_TIMEOUT 100 +#define SEMAPHORE_TIMEOUT 500#define PUNIT_SEMAPHORE 0x7#define PUNIT_SEMAPHORE_CHT 0x10e#define PUNIT_SEMAPHORE_BIT BIT(0)
Jarkko Nikula
Acked-byQuoted 11 lines · Hans de Goede
Hi,
Quoted 8 lines · Oliver Neukum
Our testing shows the semaphore failing to be transferred on CherryTrail in about 0.5% of all cases. The existing timeout needs to be lengthened to accomodate the worst cases.
V2: Rebased on
https://cgit.freedesktop.org/drm-intel/commit/?h=topic/designware-baytrail
Quoted 6 lines
Quoted 1 line
Signed-off-by Oliver Neukum <[email protected]>Looks good to me:
Reviewed-by Hans de Goede <[email protected]>
Quoted 7 lines · Oliver Neukum
Our testing shows the semaphore failing to be transferred on CherryTrail in about 0.5% of all cases. The existing timeout needs to be lengthened to accomodate the worst cases.
V2: Rebased on https://cgit.freedesktop.org/drm-intel/commit/?h=topic/designware-baytrail
Signed-off-by Oliver Neukum <[email protected]>
Fixed this checkpatch issue:
WARNING: 'accomodate' may be misspelled - perhaps 'accommodate'?
and applied to for-next, thanks!