block: make nr_iovecs unsigned in bio_alloc_bioset()

PATCH Applied Dan Carpenter 3 participants 3 messages Mar 23, 2017

Subsystems (2)

Block layer Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2017-03-23 10:24 UTC #0 lore raw

PATCH 1/1 block: make nr_iovecs unsigned in bio_alloc_bioset()

There isn't a bug here, but Smatch is not smart enough to know that "nr_iovecs" can't be negative so it complains about underflows. Really, it's slightly cleaner to make this parameter unsigned.

Signed-off-by Dan Carpenter <[email protected]>

include/linux/bio.h +1 -1

index 8e521194f6fc..4931756d86d9 100644
@@ -383,7 +383,7 @@ extern struct bio_set *bioset_create_nobvec(unsigned int, unsigned int);
 extern void bioset_free(struct bio_set *);
 extern mempool_t *biovec_create_pool(int pool_entries);
 
-extern struct bio *bio_alloc_bioset(gfp_t, int, struct bio_set *);
+extern struct bio *bio_alloc_bioset(gfp_t, unsigned int, struct bio_set *);
 extern void bio_put(struct bio *);
 
 extern void __bio_clone_fast(struct bio *, struct bio *);

block/bio.c +2 -1

index e75878f8b14a..6194a8cf2aab 100644
@@ -427,7 +427,8 @@ static void punt_bios_to_rescuer(struct bio_set *bs)
  *   RETURNS:
  *   Pointer to new bio on success, NULL on failure.
  */
-struct bio *bio_alloc_bioset(gfp_t gfp_mask, int nr_iovecs, struct bio_set *bs)
+struct bio *bio_alloc_bioset(gfp_t gfp_mask, unsigned int nr_iovecs,
+			     struct bio_set *bs)
 {
 	gfp_t saved_gfp = gfp_mask;
 	unsigned front_pad;

Christoph Hellwig

Reviewed-by on v1 1/1

2017-03-23 14:07 UTC #1 lore raw

Looks fine,

Reviewed-by Christoph Hellwig <[email protected]>

Jens Axboe

Applied

2017-03-23 14:16 UTC #2 lore raw

In reply to Dan Carpenter

Quoted 3 lines · Dan Carpenter

There isn't a bug here, but Smatch is not smart enough to know that "nr_iovecs" can't be negative so it complains about underflows. Really, it's slightly cleaner to make this parameter unsigned.

Applied, thanks Dan.

Signature · 1 line

Jens Axboe