expect: resolve string formatting issues

PATCH New Alexander Kanavin 1 participant 1 message Mar 23, 2017

lore

Share & tools

lore

Alexander Kanavin

author

2017-03-23 12:00 UTC #0 lore raw

PATCH 1/1 expect: resolve string formatting issues

[YOCTO #9542]

Signed-off-by Alexander Kanavin <[email protected]>

---
 meta/conf/distro/include/security_flags.inc        |  1 -
 .../0001-Resolve-string-formatting-issues.patch    | 29 ++++++++++++++++++++++
 meta/recipes-devtools/expect/expect_5.45.bb        |  1 +
 3 files changed, 30 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-devtools/expect/expect/0001-Resolve-string-formatting-issues.patch

meta/conf/distro/include/security_flags.inc +0 -1

index 5a1ea0de8e9..89fd45b859c 100644
@@ -91,7 +91,6 @@ SECURITY_CFLAGS_pn-zlib = "${SECURITY_NO_PIE_CFLAGS}"
 
 # Recipes which fail to compile when elevating -Wformat-security to an error
 SECURITY_STRINGFORMAT_pn-busybox = ""
-SECURITY_STRINGFORMAT_pn-expect = ""
 SECURITY_STRINGFORMAT_pn-gcc = ""
 SECURITY_STRINGFORMAT_pn-oh-puzzles = ""

meta/recipes-devtools/expect/expect/0001-Resolve-string-formatting-issues.patch new file +29 -0

new file mode 100644
index 00000000000..af1d8c626c2
@@ -0,0 +1,29 @@
+From 107cc370705d8520ba42f1416d89ed3544277c83 Mon Sep 17 00:00:00 2001
+From: Alexander Kanavin <[email protected]>
+Date: Thu, 23 Mar 2017 13:44:41 +0200
+Subject: [PATCH] Resolve string formatting issues.
+
+Upstream-Status: Inappropriate [upstream seems dead]
+Signed-off-by: Alexander Kanavin <[email protected]>
+---
+ exp_clib.c | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/exp_clib.c b/exp_clib.c
+index 172c05e..809200e 100644
+--- a/exp_clib.c
++++ b/exp_clib.c
+@@ -1476,8 +1476,8 @@ expDiagLogU(str)
+      char *str;
+ {
+   if (exp_is_debugging) {
+-    fprintf(stderr,str);
+-    if (exp_logfile) fprintf(exp_logfile,str);
++    fprintf(stderr, "%s", str);
++    if (exp_logfile) fprintf(exp_logfile, "%s", str);
+   }
+ }
+ 
+-- 
+2.11.0
+

meta/recipes-devtools/expect/expect_5.45.bb +1 -0

index ab22a61394e..630f2e46492 100644
@@ -25,6 +25,7 @@ SRC_URI = "${SOURCEFORGE_MIRROR}/expect/Expect/${PV}/${BPN}${PV}.tar.gz \
            file://0002-tcl.m4.patch \
            file://01-example-shebang.patch \
            file://0001-expect-install-scripts-without-using-the-fixline1-tc.patch \
+           file://0001-Resolve-string-formatting-issues.patch \
           "
 SRC_URI[md5sum] = "44e1a4f4c877e9ddc5a542dfa7ecc92b"
 SRC_URI[sha256sum] = "b28dca90428a3b30e650525cdc16255d76bb6ccd65d448be53e620d95d5cc040"

Signature · 1 line

2.11.0