Skip to contentSkip to conversation

CIFS: Fix build failure with smb2

PATCH Applied Tobias Regnery 3 participants 3 messages Mar 30, 2017 – Apr 4, 2017

Subsystems (2)
SMB client (CIFS) Kernel SMB3 server (ksmbd)
lore
Share & tools
lore

Tobias Regnery

author
#0 lore raw

PATCH 1/1 CIFS: Fix build failure with smb2

I saw the following build error during a randconfig build:

fs/cifs/smb2ops.c: In function 'smb2_new_lease_key':
fs/cifs/smb2ops.c:1104:2: error: implicit declaration of function 'generate_random_uuid' [-Werror=implicit-function-declaration]

Explicit include the right header to fix this issue.

Signed-off-by Tobias Regnery <[email protected]>

---
This is against next-20170330

 fs/cifs/smb2ops.c | 1 +
 1 file changed, 1 insertion(+)
fs/cifs/smb2ops.c +1 -0
index c6d14cc44510..c1b70559496c 100644
@@ -21,6 +21,7 @@
 #include <linux/vfs.h>
 #include <linux/falloc.h>
 #include <linux/scatterlist.h>
+#include <linux/uuid.h>
 #include <crypto/aead.h>
 #include "cifsglob.h"
 #include "smb2pdu.h"
Signature · 1 line
2.11.0
Reviewed-by Aurelien Aptel on v1 1/1
#1 lore raw
Quoted 1 line · Tobias Regnery

Explicit include the right header to fix this issue.

uuid.h indeed declares generate_random_uuid(). Looks good to me.

Reviewed-by Aurelien Aptel <aaptel-IBi9RG/[email protected]>
Signature · 4 lines
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
Applied
#2 lore raw

merged into cifs-2.6.git

thx

Quoted 16 lines · Aurélien Aptel
Quoted 1 line · Tobias Regnery

Explicit include the right header to fix this issue.

uuid.h indeed declares generate_random_uuid(). Looks good to me.

Reviewed-by Aurelien Aptel <[email protected]>

--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 3 lines
Thanks,

Steve