Skip to contentSkip to conversation

eudyptula challenge

PATCH New Chewie Lin 2 participants 3 messages Mar 31, 2017 Staging

lore
Share & tools
lore

Chewie Lin

author
#0 lore raw

PATCH 1/1 eudyptula challenge

Hi greg and forest:

I hate to bother but one more, with better changelog.

I'm submitting this patch as part of Eudyptula challenge to fix a coding style problem. Thanks for taking time on this trivial patch.

sl424

Chewie Lin (1):
drivers/staging/vt6656/main_usb.c: checkpatch warning

 drivers/staging/vt6656/main_usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
2.10.0
author
#1 lore raw

PATCH 1/1 drivers/staging/vt6656/main_usb.c: checkpatch warning

Replace string with formatted arguments in the dev_warn() call. It removes the checkpatch warning.

---
 drivers/staging/vt6656/main_usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6656/main_usb.c +1 -1
index 9e074e9..2d9e7af 100644
@@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv)
 	status = usb_reset_device(priv->usb);
 	if (status)
 		dev_warn(&priv->usb->dev,
-			 "usb_device_reset fail status=%d\n", status);
+			 "%s=%d\n", "usb_device_reset fail status", status);
 }
 
 static void vnt_free_int_bufs(struct vnt_private *priv)
Signature · 1 line
2.10.0
#2 lore raw

Re: [PATCH 01/01] drivers/staging/vt6656/main_usb.c: checkpatch warning

Quoted 2 lines · Chewie Lin

Replace string with formatted arguments in the dev_warn() call. It removes the checkpatch warning.

Tell us what the warning was.
and then see if the patch fixes that warning.

Quoted 19 lines
---
 drivers/staging/vt6656/main_usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6656/main_usb.c +1 -1
index 9e074e9..2d9e7af 100644
@@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv)
 	status = usb_reset_device(priv->usb);
 	if (status)
 		dev_warn(&priv->usb->dev,
-			 "usb_device_reset fail status=%d\n", status);
+			 "%s=%d\n", "usb_device_reset fail status", status);
 }
 
 static void vnt_free_int_bufs(struct vnt_private *priv)
Signature · 1 line
~Randy