iio: adc: hx711: constify attribute_group structures
Subsystems (2)
PATCH 1/1 iio: adc: hx711: constify attribute_group structures
Check for attribute_group structures that are only stored in the attrs filed of iio_info structure. As the attrs field of iio_info structures is constant, so these attribute_group structures can also be declared constant.
Done using coccinelle:
@r1 disable optional_qualifier @
identifier i;
position p;
@@
static struct attribute_group i@p = {...};
@ok1@
identifier r1.i;
position p;
struct iio_info x;
@@
x.attrs=&i@p;
@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p
@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
static
+const
struct attribute_group i={...};
@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct attribute_group i;
File size before:
text data bss dec hex filename
3042 480 0 3522 dc2 drivers/iio/adc/hx711.o
File size after:
text data bss dec hex filename
3098 416 0 3514 dba drivers/iio/adc/hx711.o
--- drivers/iio/adc/hx711.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/hx711.c +1 -1
@@ -369,7 +369,7 @@ static struct attribute *hx711_attributes[] = { NULL, }; -static struct attribute_group hx711_attribute_group = { +static const struct attribute_group hx711_attribute_group = { .attrs = hx711_attributes, };
Signature · 1 line
2.7.4
Quoted 42 lines · simran singhal
Check for
attribute_groupstructures that are only stored in the attrs filed ofiio_infostructure. As the attrs field ofiio_infostructures is constant, so theseattribute_groupstructures can also be declared constant.
Done using coccinelle:@r1 disable
optional_qualifier@
identifier i;
position p;
@@
static structattribute_groupi@p = {...};@ok1@
identifier r1.i;
position p;
structiio_infox;
@@
x.attrs=&i@p;@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
static
+const
structattribute_groupi={...};@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
structattribute_groupi;File size before:
text data bss dec hex filename
3042 480 0 3522 dc2drivers/iio/adc/hx711.o
Quoted 5 lines
File size after:
text data bss dec hex filename
3098 416 0 3514 dbadrivers/iio/adc/hx711.oSigned-off-by simran singhal <[email protected]>
Applied.
Quoted 18 lines
--- drivers/iio/adc/hx711.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/iio/adc/hx711.c +1
-1@@ -369,7 +369,7 @@ static struct attribute *hx711_attributes[] = { NULL, }; -static struct attribute_group hx711_attribute_group = { +static const struct attribute_group hx711_attribute_group = { .attrs = hx711_attributes, };