Skip to contentSkip to conversation

drm/amd/powerplay: fix pp_dpm_get_current_power_state()

PATCH Applied Dan Carpenter 2 participants 2 messages Apr 3, 2017

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 drm/amd/powerplay: fix pp_dpm_get_current_power_state()

This switch statement is missing breaks.

Fixes 2a5071056e6a ("drm/amd/powerplay: add global PowerPlay mutex.")
drivers/gpu/drm/amd/powerplay/amd_powerplay.c +3 -0
index dfd4fe6f0578..260b732be7c3 100644
@@ -539,10 +539,13 @@ static enum amd_pm_state_type pp_dpm_get_current_power_state(void *handle)
 	switch (state->classification.ui_label) {
 	case PP_StateUILabel_Battery:
 		pm_type = POWER_STATE_TYPE_BATTERY;
+		break;
 	case PP_StateUILabel_Balanced:
 		pm_type = POWER_STATE_TYPE_BALANCED;
+		break;
 	case PP_StateUILabel_Performance:
 		pm_type = POWER_STATE_TYPE_PERFORMANCE;
+		break;
 	default:
 		if (state->classification.flags & PP_StateClassificationFlag_Boot)
 			pm_type = POWER_STATE_TYPE_INTERNAL_BOOT;

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Applied
#1 lore raw
Quoted 4 lines · Dan Carpenter

This switch statement is missing breaks.

Fixes 2a5071056e6a ("drm/amd/powerplay: add global PowerPlay mutex.")

Applied. thanks!

Quoted 19 lines
drivers/gpu/drm/amd/powerplay/amd_powerplay.c +3 -0
index dfd4fe6f0578..260b732be7c3 100644
@@ -539,10 +539,13 @@ static enum amd_pm_state_type pp_dpm_get_current_power_state(void *handle)
        switch (state->classification.ui_label) {
        case PP_StateUILabel_Battery:
                pm_type = POWER_STATE_TYPE_BATTERY;
+               break;
        case PP_StateUILabel_Balanced:
                pm_type = POWER_STATE_TYPE_BALANCED;
+               break;
        case PP_StateUILabel_Performance:
                pm_type = POWER_STATE_TYPE_PERFORMANCE;
+               break;
        default:
                if (state->classification.flags & PP_StateClassificationFlag_Boot)
                        pm_type = POWER_STATE_TYPE_INTERNAL_BOOT;
Quoted 4 lines

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel