drm/amd/amdgpu: Fix psp_v3_1 compare sram
Subsystems (2)
PATCH 1/2 drm/amd/amdgpu: Fix psp_v3_1 compare sram
Had the wrong sense in the loop
Signed-off-by Tom St Denis <[email protected]>
--- drivers/gpu/drm/amd/amdgpu/psp_v3_1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/psp_v3_1.c +1 -1
@@ -491,7 +491,7 @@ bool psp_v3_1_compare_sram_data(struct psp_context *psp, ucode_size = ucode->ucode_size; ucode_mem = (uint32_t *)ucode->kaddr; -while (!ucode_size) { +while (ucode_size) { fw_sram_reg_val =RREG32 (fw_sram_data_reg_offset);if (*ucode_mem != fw_sram_reg_val)
Signature · 6 lines
2.12.0 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 2/2 drm/amd/amdgpu: Clean up psp reload_quirk()
Signed-off-by Tom St Denis <[email protected]>
--- drivers/gpu/drm/amd/amdgpu/psp_v3_1.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)
drivers/gpu/drm/amd/amdgpu/psp_v3_1.c +4 -8
@@ -508,14 +508,10 @@ bool psp_v3_1_compare_sram_data(struct psp_context *psp,bool psp_v3_1_smu_reload_quirk (struct psp_context *psp) {struct amdgpu_device *adev = psp->adev; -uint32_t reg, reg_val; +uint32_t reg; - reg_val = (smnMP1_FIRMWARE_FLAGS &0xffffffff ) |0x03b00000 ; -WREG32 (SOC15_REG_OFFSET (NBIO ,0 , mmPCIE_INDEX2), reg_val); + reg = smnMP1_FIRMWARE_FLAGS |0x03b00000 ; +WREG32 (SOC15_REG_OFFSET (NBIO ,0 , mmPCIE_INDEX2), reg); reg =RREG32 (SOC15_REG_OFFSET (NBIO ,0 , mmPCIE_DATA2)); -if ((reg &MP1_FIRMWARE_FLAGS__INTERRUPTS_ENABLED_MASK ) >> -MP1_FIRMWARE_FLAGS__INTERRUPTS_ENABLED__SHIFT ) -return true; - -return false; +return (reg &MP1_FIRMWARE_FLAGS__INTERRUPTS_ENABLED_MASK ) ? true : false; }
Signature · 6 lines
2.12.0 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): [email protected]
Alex Deucher
Reviewed-byRe: [PATCH 2/2] drm/amd/amdgpu: Clean up psp reload_quirk()
Quoted 1 line · Tom St Denis
Signed-off-by Tom St Denis <[email protected]>
Series is:
Reviewed-by Alex Deucher <[email protected]>
Quoted 30 lines
--- drivers/gpu/drm/amd/amdgpu/psp_v3_1.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)drivers/gpu/drm/amd/amdgpu/psp_v3_1.c +4
-9@@ -508,14 +508,10 @@ bool psp_v3_1_compare_sram_data(struct psp_context *psp,bool psp_v3_1_smu_reload_quirk (struct psp_context *psp) {struct amdgpu_device *adev = psp->adev; -uint32_t reg, reg_val; +uint32_t reg; - reg_val = (smnMP1_FIRMWARE_FLAGS &0xffffffff ) |0x03b00000 ; -WREG32 (SOC15_REG_OFFSET (NBIO ,0 , mmPCIE_INDEX2), reg_val); + reg = smnMP1_FIRMWARE_FLAGS |0x03b00000 ; +WREG32 (SOC15_REG_OFFSET (NBIO ,0 , mmPCIE_INDEX2), reg); reg =RREG32 (SOC15_REG_OFFSET (NBIO ,0 , mmPCIE_DATA2)); -if ((reg &MP1_FIRMWARE_FLAGS__INTERRUPTS_ENABLED_MASK ) >> -MP1_FIRMWARE_FLAGS__INTERRUPTS_ENABLED__SHIFT ) -return true; - -return false; +return (reg &MP1_FIRMWARE_FLAGS__INTERRUPTS_ENABLED_MASK ) ? true : false; } --2.12.0
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx