Skip to contentSkip to conversation

core/uclass: Print name of device in uclass_find_device_by_seq()

PATCH New Alexandru Gagniuc 2 participants 3 messages Apr 4, 2017 – Apr 13, 2017

lore
Share & tools
lore

Alexandru Gagniuc

author
#0 lore raw

PATCH 1/1 core/uclass: Print name of device in uclass_find_device_by_seq()

uclass_find_device_by_seq() prints seq and req_seq when debugging is enabled, but this information is not very useful by itself. Add the name of he driver to this information. This improves debugging as it shows which devices are being considered.

Signed-off-by Alexandru Gagniuc <[email protected]>
---
 drivers/core/uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/core/uclass.c +1 -1
index 7de3706..fa62800 100644
@@ -250,7 +250,7 @@ int uclass_find_device_by_seq(enum uclass_id id, int seq_or_req_seq,
 		return ret;
 
 	list_for_each_entry(dev, &uc->dev_head, uclass_node) {
-		debug("   - %d %d\n", dev->req_seq, dev->seq);
+		debug("   - %d %d '%s'\n", dev->req_seq, dev->seq, dev->name);
 		if ((find_req_seq ? dev->req_seq : dev->seq) ==
 				seq_or_req_seq) {
 			*devp = dev;
Signature · 1 line
2.9.3
#1 lore raw

PATCH 1/1 core/uclass: Print name of device in uclass_find_device_by_seq()

Quoted 9 lines · Alexandru Gagniuc

uclass_find_device_by_seq() prints seq and req_seq when debugging is enabled, but this information is not very useful by itself. Add the name of he driver to this information. This improves debugging as it shows which devices are being considered.

Signed-off-by Alexandru Gagniuc <[email protected]>
---
 drivers/core/uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by Simon Glass <[email protected]>
#2 lore raw

PATCH 1/1 core/uclass: Print name of device in uclass_find_device_by_seq()

Quoted 6 lines · Simon Glass
Quoted 5 lines · Alexandru Gagniuc

uclass_find_device_by_seq() prints seq and req_seq when debugging is enabled, but this information is not very useful by itself. Add the name of he driver to this information. This improves debugging as it shows which devices are being considered.

Quoted 6 lines
Quoted 4 lines
Signed-off-by Alexandru Gagniuc <[email protected]>
---
 drivers/core/uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by Simon Glass <[email protected]>

Applied to u-boot-dm, thanks!