Skip to contentSkip to conversation

drm: bridge: dw-hdmi: Add a missing break statement

PATCH Applied Dan Carpenter 2 participants 3 messages Apr 6, 2017

Subsystems (4)
DRM drivers DRM misc Kernel janitors DRM drivers for bridge chips
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 drm: bridge: dw-hdmi: Add a missing break statement

There was supposed to be a break before the next case statement.

Fixes def23aa7e982 ("drm: bridge: dw-hdmi: Switch to V4L bus format and encodings")
Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +1 -0
index 84cc949eae2b..8b605039c613 100644
@@ -1318,6 +1318,7 @@ static void hdmi_config_AVI(struct dw_hdmi *hdmi, struct drm_display_mode *mode)
 			frame.colorimetry = HDMI_COLORIMETRY_ITU_601;
 		frame.extended_colorimetry =
 				HDMI_EXTENDED_COLORIMETRY_XV_YCC_601;
+		break;
 	case V4L2_YCBCR_ENC_709:
 		if (hdmi->hdmi_data.enc_in_encoding == V4L2_YCBCR_ENC_XV709)
 			frame.colorimetry = HDMI_COLORIMETRY_EXTENDED;
Acked-by on v1 1/1
#1 lore raw
Quoted 11 lines · Dan Carpenter

There was supposed to be a break before the next case statement.

Fixes def23aa7e982 ("drm: bridge: dw-hdmi: Switch to V4L bus format and encodings")
Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +0 -0
index 84cc949eae2b..8b605039c613 100644

drivers/gpu/drm/bridge/synopsys/dw-hdmi.c static void hdmi_config_AVI(struct dw_hdmi *hdmi, struct drm_display_mode *mode) · line 1324

Quoted 7 lines
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +1 -0
@@ -1318,6 +1318,7 @@ static void hdmi_config_AVI(struct dw_hdmi *hdmi, struct drm_display_mode *mode)
 			frame.colorimetry = HDMI_COLORIMETRY_ITU_601;
 		frame.extended_colorimetry =
 				HDMI_EXTENDED_COLORIMETRY_XV_YCC_601;
+		break;
 	case V4L2_YCBCR_ENC_709:
 		if (hdmi->hdmi_data.enc_in_encoding == V4L2_YCBCR_ENC_XV709)
 			frame.colorimetry = HDMI_COLORIMETRY_EXTENDED;

Thanks for the fix !

Acked-by Neil Armstrong <[email protected]>
Applied
#2 lore raw
Quoted 21 lines · Neil Armstrong
Quoted 10 lines · Dan Carpenter

There was supposed to be a break before the next case statement.

Fixes def23aa7e982 ("drm: bridge: dw-hdmi: Switch to V4L bus format and encodings")
Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +0 -0
index 84cc949eae2b..8b605039c613 100644

drivers/gpu/drm/bridge/synopsys/dw-hdmi.c static void hdmi_config_AVI(struct dw_hdmi *hdmi, struct drm_display_mode *mode) · line 1324

Quoted 7 lines
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +1 -0
@@ -1318,6 +1318,7 @@ static void hdmi_config_AVI(struct dw_hdmi *hdmi, struct drm_display_mode *mode)
 			frame.colorimetry = HDMI_COLORIMETRY_ITU_601;
 		frame.extended_colorimetry >>  				HDMI_EXTENDED_COLORIMETRY_XV_YCC_601;
+		break;
 	case V4L2_YCBCR_ENC_709:
 		if (hdmi->hdmi_data.enc_in_encoding = V4L2_YCBCR_ENC_XV709)
 			frame.colorimetry = HDMI_COLORIMETRY_EXTENDED;

Thanks for the fix !

Quoted 2 lines
Acked-by Neil Armstrong <[email protected]>

Applied to drm-misc-next

Thanks,
Neil