f2fs: use segment number for get_valid_blocks
Subsystems (2)
Jaegeuk Kim
maintainerPATCH 1/4 f2fs: use segment number for get_valid_blocks
This patch fixes to submit a segment number for get_valid_blocks.
--- fs/f2fs/segment.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
fs/f2fs/segment.h +4 -2
@@ -80,6 +80,8 @@ GET_SEGNO_FROM_SEG0(sbi, blk_addr)))#define GET_SECNO (sbi, segno) \ ((segno) / (sbi)->segs_per_sec) +#define GET_SEGNO_FROM_SECNO (sbi, secno) \ + ((secno) * (sbi)->segs_per_sec)#define GET_ZONENO_FROM_SEGNO (sbi, segno) \ (((segno) / (sbi)->segs_per_sec) / (sbi)->secs_per_zone)
@@ -720,8 +722,8 @@ static inline block_t sum_blk_addr(struct f2fs_sb_info *sbi, int base, int type)static inline bool no_fggc_candidate (struct f2fs_sb_info *sbi,unsigned int secno) { -if (get_valid_blocks (sbi, secno, sbi->segs_per_sec) >= - sbi->fggc_threshold) +if (get_valid_blocks (sbi,GET_SEGNO_FROM_SECNO (sbi, secno), + sbi->segs_per_sec) >= sbi->fggc_threshold)return true;return false; }
Signature · 1 line
2.11.0
Jaegeuk Kim
maintainerPATCH 2/4 f2fs: clean up get_valid_blocks with consistent parameter
This patch cleans up get_valid_blocks, which has no functional change.
--- fs/f2fs/debug.c | 2 +- fs/f2fs/gc.c | 8 ++++---- fs/f2fs/segment.c | 8 ++++---- fs/f2fs/segment.h | 8 ++++---- fs/f2fs/super.c | 4 ++-- 5 files changed, 15 insertions(+), 15 deletions(-)
fs/f2fs/debug.c +1 -1
@@ -137,7 +137,7 @@ static void update_sit_info(struct f2fs_sb_info *sbi) blks_per_sec = sbi->segs_per_sec * sbi->blocks_per_seg; hblks_per_sec = blks_per_sec /2 ;for (segno =0 ; segno <MAIN_SEGS (sbi); segno += sbi->segs_per_sec) { - vblocks =get_valid_blocks (sbi, segno, sbi->segs_per_sec); + vblocks =get_valid_blocks (sbi, segno, true); dist =abs (vblocks - hblks_per_sec); bimodal += dist * dist;
fs/f2fs/gc.c +4 -4
@@ -229,7 +229,7 @@ static unsigned int get_cb_cost(struct f2fs_sb_info *sbi, unsigned int segno)for (i =0 ; i < sbi->segs_per_sec; i++) mtime +=get_seg_entry (sbi, start + i)->mtime; - vblocks =get_valid_blocks (sbi, segno, sbi->segs_per_sec); + vblocks =get_valid_blocks (sbi, segno, true); mtime =div_u64 (mtime, sbi->segs_per_sec); vblocks =div_u64 (vblocks, sbi->segs_per_sec);
@@ -252,7 +252,7 @@ static unsigned int get_greedy_cost(struct f2fs_sb_info *sbi, unsigned int segno) {unsigned int valid_blocks = -get_valid_blocks (sbi, segno, sbi->segs_per_sec); +get_valid_blocks (sbi, segno, true);return IS_DATASEG (get_seg_entry (sbi, segno)->type) ? valid_blocks *2 : valid_blocks;
@@ -897,7 +897,7 @@ static int do_garbage_collect(struct f2fs_sb_info *sbi, GET_SUM_BLOCK(sbi, segno));f2fs_put_page (sum_page,0 ); -if (get_valid_blocks (sbi, segno,1 ) ==0 || +if (get_valid_blocks (sbi, segno, false) ==0 || !PageUptodate (sum_page) ||unlikely (f2fs_cp_error (sbi))) goto next;
@@ -931,7 +931,7 @@ static int do_garbage_collect(struct f2fs_sb_info *sbi,blk_finish_plug (&plug);if (gc_type ==FG_GC && -get_valid_blocks (sbi, start_segno, sbi->segs_per_sec) ==0 ) +get_valid_blocks (sbi, start_segno, true) ==0 ) sec_freed =1 ;stat_inc_call_count (sbi->stat_info);
fs/f2fs/segment.c +4 -4
@@ -636,7 +636,7 @@ static void __remove_dirty_segment(struct f2fs_sb_info *sbi, unsigned int segno,if (test_and_clear_bit (segno, dirty_i->dirty_segmap[t])) dirty_i->nr_dirty[t]--; -if (get_valid_blocks (sbi, segno, sbi->segs_per_sec) ==0 ) +if (get_valid_blocks (sbi, segno, true) ==0 )clear_bit (GET_SECNO (sbi, segno), dirty_i->victim_secmap); }
@@ -657,7 +657,7 @@ static void locate_dirty_segment(struct f2fs_sb_info *sbi, unsigned int segno)mutex_lock (&dirty_i->seglist_lock); - valid_blocks =get_valid_blocks (sbi, segno,0 ); + valid_blocks =get_valid_blocks (sbi, segno, false);if (valid_blocks ==0 ) {__locate_dirty_segment (sbi, segno,PRE );
@@ -1109,7 +1109,7 @@ void clear_prefree_segments(struct f2fs_sb_info *sbi, struct cp_control *cpc) secno =GET_SECNO (sbi, start); start_segno = secno * sbi->segs_per_sec;if (!IS_CURSEC (sbi, secno) && - !get_valid_blocks (sbi, start, sbi->segs_per_sec)) + !get_valid_blocks (sbi, start, true))f2fs_issue_discard (sbi,START_BLOCK (sbi, start_segno), sbi->segs_per_sec << sbi->log_blocks_per_seg);
@@ -2859,7 +2859,7 @@ static void init_dirty_segmap(struct f2fs_sb_info *sbi)if (segno >=MAIN_SEGS (sbi))break ; offset = segno +1 ; - valid_blocks =get_valid_blocks (sbi, segno,0 ); + valid_blocks =get_valid_blocks (sbi, segno, false);if (valid_blocks == sbi->blocks_per_seg || !valid_blocks)continue ;if (valid_blocks > sbi->blocks_per_seg) {
fs/f2fs/segment.h +4 -4
@@ -309,13 +309,13 @@ static inline struct sec_entry *get_sec_entry(struct f2fs_sb_info *sbi, }static inline unsigned int get_valid_blocks (struct f2fs_sb_info *sbi, -unsigned int segno,int section) +unsigned int segno,bool use_section) {/* * In order to get # of valid blocks in a section instantly from many * segments, f2fs manages two counting structures separately. */ -if (section >1 ) +if (use_section && sbi->segs_per_sec >1 )return get_sec_entry (sbi, segno)->valid_blocks;else return get_seg_entry (sbi, segno)->valid_blocks;
@@ -722,8 +722,8 @@ static inline block_t sum_blk_addr(struct f2fs_sb_info *sbi, int base, int type)static inline bool no_fggc_candidate (struct f2fs_sb_info *sbi,unsigned int secno) { -if (get_valid_blocks (sbi,GET_SEGNO_FROM_SECNO (sbi, secno), - sbi->segs_per_sec) >= sbi->fggc_threshold) +if (get_valid_blocks (sbi,GET_SEGNO_FROM_SECNO (sbi, secno), true) >= + sbi->fggc_threshold)return true;return false; }
fs/f2fs/super.c +2 -2
@@ -996,7 +996,7 @@ static int segment_info_seq_show(struct seq_file *seq, void *offset)if ((i %10 ) ==0 )seq_printf (seq,"%-10d" , i);seq_printf (seq,"%d|%-3u" , se->type, -get_valid_blocks (sbi, i,1 )); +get_valid_blocks (sbi, i, false));if ((i %10 ) ==9 || i == (total_segs -1 ))seq_putc (seq,'\n' );else
@@ -1022,7 +1022,7 @@ static int segment_bits_seq_show(struct seq_file *seq, void *offset)seq_printf (seq,"%-10d" , i);seq_printf (seq,"%d|%-3u|" , se->type, -get_valid_blocks (sbi, i,1 )); +get_valid_blocks (sbi, i, false));for (j =0 ; j <SIT_VBLOCK_MAP_SIZE ; j++)seq_printf (seq," %.2x" , se->cur_valid_map[j]);seq_putc (seq,'\n' );
Signature · 6 lines
2.11.0 ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
Jaegeuk Kim
maintainerPATCH 3/4 f2fs: clean up some macros in terms of GET_SEGNO
In reply to Jaegeuk KimThis patch cleans several macros by introducing:
- BLKS_PER_SEC
- GET_SEC_FROM_SEG
- GET_SEG_FROM_SEC
- GET_ZONE_FROM_SEC
- GET_ZONE_FROM_SEG
--- fs/f2fs/debug.c | 6 +++--- fs/f2fs/f2fs.h | 7 +++---- fs/f2fs/file.c | 3 +-- fs/f2fs/gc.c | 17 ++++++++--------- fs/f2fs/segment.c | 20 ++++++++++---------- fs/f2fs/segment.h | 34 ++++++++++++++++++++-------------- 6 files changed, 45 insertions(+), 42 deletions(-)
fs/f2fs/debug.c +3 -3
@@ -109,8 +109,8 @@ static void update_general_status(struct f2fs_sb_info *sbi)for (i =CURSEG_HOT_DATA ; i <=CURSEG_COLD_NODE ; i++) {struct curseg_info *curseg =CURSEG_I (sbi, i); si->curseg[i] = curseg->segno; - si->cursec[i] = curseg->segno / sbi->segs_per_sec; - si->curzone[i] = si->cursec[i] / sbi->secs_per_zone; + si->cursec[i] =GET_SEC_FROM_SEG (sbi, curseg->segno); + si->curzone[i] =GET_ZONE_FROM_SEC (sbi, si->cursec[i]); }for (i =0 ; i <2 ; i++) {
@@ -134,7 +134,7 @@ static void update_sit_info(struct f2fs_sb_info *sbi) bimodal =0 ; total_vblocks =0 ; - blks_per_sec = sbi->segs_per_sec * sbi->blocks_per_seg; + blks_per_sec =BLKS_PER_SEC (sbi); hblks_per_sec = blks_per_sec /2 ;for (segno =0 ; segno <MAIN_SEGS (sbi); segno += sbi->segs_per_sec) { vblocks =get_valid_blocks (sbi, segno, true);
fs/f2fs/f2fs.h +3 -4
@@ -135,12 +135,11 @@ enum {#define DEF_BATCHED_TRIM_SECTIONS 2048#define BATCHED_TRIM_SEGMENTS (sbi) \ - (SM_I(sbi)->trim_sections * (sbi)->segs_per_sec) + (GET_SEG_FROM_SEC(sbi, SM_I(sbi)->trim_sections))#define BATCHED_TRIM_BLOCKS (sbi) \ (BATCHED_TRIM_SEGMENTS(sbi) << (sbi)->log_blocks_per_seg) -#define MAX_DISCARD_BLOCKS (sbi) \ - ((1 << (sbi)->log_blocks_per_seg) * (sbi)->segs_per_sec) -#define DISCARD_ISSUE_RATE 8 +#define MAX_DISCARD_BLOCKS (sbi) BLKS_PER_SEC(sbi) +#define DISCARD_ISSUE_RATE 8#define DEF_CP_INTERVAL 60/* 60 secs */ #define DEF_IDLE_INTERVAL 5/* 5 secs */
fs/f2fs/file.c +1 -2
@@ -1892,7 +1892,6 @@ static int f2fs_defragment_range(struct f2fs_sb_info *sbi,pgoff_t pg_start, pg_end;unsigned int blk_per_seg = sbi->blocks_per_seg;unsigned int total =0 , sec_num; -unsigned int pages_per_sec = sbi->segs_per_sec * blk_per_seg;block_t blk_end =0 ;bool fragmented = false;int err;
@@ -1956,7 +1955,7 @@ static int f2fs_defragment_range(struct f2fs_sb_info *sbi, map.m_lblk = pg_start; map.m_len = pg_end - pg_start; - sec_num = (map.m_len + pages_per_sec -1 ) / pages_per_sec; + sec_num = (map.m_len +BLKS_PER_SEC (sbi) -1 ) /BLKS_PER_SEC (sbi);/* * make sure there are enough free section for LFS allocation, this can
fs/f2fs/gc.c +8 -9
@@ -211,7 +211,7 @@ static unsigned int check_bg_victims(struct f2fs_sb_info *sbi)continue ;clear_bit (secno, dirty_i->victim_secmap); -return secno * sbi->segs_per_sec; +return GET_SEG_FROM_SEC (sbi, secno); }return NULL_SEGNO ; }
@@ -219,8 +219,8 @@ static unsigned int check_bg_victims(struct f2fs_sb_info *sbi)static unsigned int get_cb_cost (struct f2fs_sb_info *sbi,unsigned int segno) {struct sit_info *sit_i =SIT_I (sbi); -unsigned int secno =GET_SECNO (sbi, segno); -unsigned int start = secno * sbi->segs_per_sec; +unsigned int secno =GET_SEC_FROM_SEG (sbi, segno); +unsigned int start =GET_SEG_FROM_SEC (sbi, secno);unsigned long long mtime =0 ;unsigned int vblocks;unsigned char age =0 ;
@@ -343,7 +343,7 @@ static int get_victim_by_default(struct f2fs_sb_info *sbi, nsearched++; } - secno =GET_SECNO (sbi, segno); + secno =GET_SEC_FROM_SEG (sbi, segno);if (sec_usage_check (sbi, secno)) goto next;
@@ -372,7 +372,7 @@ static int get_victim_by_default(struct f2fs_sb_info *sbi,if (p.min_segno !=NULL_SEGNO ) { got_it:if (p.alloc_mode ==LFS ) { - secno =GET_SECNO (sbi, p.min_segno); + secno =GET_SEC_FROM_SEG (sbi, p.min_segno);if (gc_type ==FG_GC ) sbi->cur_victim_sec = secno;else
@@ -1006,7 +1006,7 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync, bool background)void build_gc_manager (struct f2fs_sb_info *sbi) { -u64 main_count, resv_count, ovp_count, blocks_per_sec; +u64 main_count, resv_count, ovp_count;DIRTY_I (sbi)->v_ops = &default_v_ops;
@@ -1014,8 +1014,7 @@ void build_gc_manager(struct f2fs_sb_info *sbi) main_count =SM_I (sbi)->main_segments << sbi->log_blocks_per_seg; resv_count =SM_I (sbi)->reserved_segments << sbi->log_blocks_per_seg; ovp_count =SM_I (sbi)->ovp_segments << sbi->log_blocks_per_seg; - blocks_per_sec = sbi->blocks_per_seg * sbi->segs_per_sec; - sbi->fggc_threshold =div64_u64 ((main_count - ovp_count) * blocks_per_sec, - (main_count - resv_count)); + sbi->fggc_threshold =div64_u64 ((main_count - ovp_count) * +BLKS_PER_SEC (sbi), (main_count - resv_count)); }
fs/f2fs/segment.c +10 -10
@@ -637,7 +637,7 @@ static void __remove_dirty_segment(struct f2fs_sb_info *sbi, unsigned int segno, dirty_i->nr_dirty[t]--;if (get_valid_blocks (sbi, segno, true) ==0 ) -clear_bit (GET_SECNO (sbi, segno), +clear_bit (GET_SEC_FROM_SEG (sbi, segno), dirty_i->victim_secmap); } }
@@ -1106,8 +1106,8 @@ void clear_prefree_segments(struct f2fs_sb_info *sbi, struct cp_control *cpc)continue ; } next: - secno =GET_SECNO (sbi, start); - start_segno = secno * sbi->segs_per_sec; + secno =GET_SEC_FROM_SEG (sbi, start); + start_segno =GET_SEG_FROM_SEC (sbi, secno);if (!IS_CURSEC (sbi, secno) && !get_valid_blocks (sbi, start, true)) f2fs_issue_discard(sbi, START_BLOCK(sbi, start_segno),
@@ -1462,8 +1462,8 @@ static void get_new_segment(struct f2fs_sb_info *sbi,struct free_segmap_info *free_i =FREE_I (sbi);unsigned int segno, secno, zoneno;unsigned int total_zones =MAIN_SECS (sbi) / sbi->secs_per_zone; -unsigned int hint = *newseg / sbi->segs_per_sec; -unsigned int old_zoneno =GET_ZONENO_FROM_SEGNO (sbi, *newseg); +unsigned int hint =GET_SEC_FROM_SEG (sbi, *newseg); +unsigned int old_zoneno =GET_ZONE_FROM_SEG (sbi, *newseg);unsigned int left_start = hint;bool init = true;int go_left =0 ;
@@ -1473,8 +1473,8 @@ static void get_new_segment(struct f2fs_sb_info *sbi,if (!new_sec && ((*newseg +1 ) % sbi->segs_per_sec)) { segno =find_next_zero_bit (free_i->free_segmap, - (hint +1 ) * sbi->segs_per_sec, *newseg +1 ); -if (segno < (hint +1 ) * sbi->segs_per_sec) +GET_SEG_FROM_SEC (sbi, hint +1 ), *newseg +1 ); +if (segno <GET_SEG_FROM_SEC (sbi, hint +1 )) goto got_it; } find_other_zone:
@@ -1505,8 +1505,8 @@ static void get_new_segment(struct f2fs_sb_info *sbi, secno = left_start; skip_left: hint = secno; - segno = secno * sbi->segs_per_sec; - zoneno = secno / sbi->secs_per_zone; + segno =GET_SEG_FROM_SEC (sbi, secno); + zoneno =GET_ZONE_FROM_SEC (sbi, secno);/* give up on finding another zone */ if (!init)
@@ -1550,7 +1550,7 @@ static void reset_curseg(struct f2fs_sb_info *sbi, int type, int modified)struct summary_footer *sum_footer; curseg->segno = curseg->next_segno; - curseg->zone =GET_ZONENO_FROM_SEGNO (sbi, curseg->segno); + curseg->zone =GET_ZONE_FROM_SEG (sbi, curseg->segno); curseg->next_blkoff =0 ; curseg->next_segno =NULL_SEGNO ;
fs/f2fs/segment.h +20 -14
@@ -78,12 +78,16 @@ ((((blk_addr) ==NULL_ADDR ) || ((blk_addr) ==NEW_ADDR )) ? \NULL_SEGNO :GET_L2R_SEGNO (FREE_I (sbi), \ GET_SEGNO_FROM_SEG0(sbi, blk_addr))) -#define GET_SECNO (sbi, segno) \ +#define BLKS_PER_SEC (sbi) \ + ((sbi)->segs_per_sec * (sbi)->blocks_per_seg) +#define GET_SEC_FROM_SEG (sbi, segno) \ ((segno) / (sbi)->segs_per_sec) -#define GET_SEGNO_FROM_SECNO (sbi, secno) \ +#define GET_SEG_FROM_SEC (sbi, secno) \ ((secno) * (sbi)->segs_per_sec) -#define GET_ZONENO_FROM_SEGNO (sbi, segno) \ - (((segno) / (sbi)->segs_per_sec) / (sbi)->secs_per_zone) +#define GET_ZONE_FROM_SEC (sbi, secno) \ + ((secno) / (sbi)->secs_per_zone) +#define GET_ZONE_FROM_SEG (sbi, segno) \ + GET_ZONE_FROM_SEC(sbi, GET_SEC_FROM_SEG(sbi, segno))#define GET_SUM_BLOCK (sbi, segno) \ ((sbi)->sm_info->ssa_blkaddr + (segno))
@@ -305,7 +309,7 @@ static inline struct sec_entry *get_sec_entry(struct f2fs_sb_info *sbi, unsigned int segno) {struct sit_info *sit_i =SIT_I (sbi); -return &sit_i->sec_entries[GET_SECNO (sbi, segno)]; +return &sit_i->sec_entries[GET_SEC_FROM_SEG (sbi, segno)]; } static inline unsigned int get_valid_blocks(struct f2fs_sb_info *sbi,
@@ -360,8 +364,8 @@ static inline unsigned int find_next_inuse(struct free_segmap_info *free_i,static inline void __set_free (struct f2fs_sb_info *sbi,unsigned int segno) {struct free_segmap_info *free_i =FREE_I (sbi); -unsigned int secno = segno / sbi->segs_per_sec; -unsigned int start_segno = secno * sbi->segs_per_sec; +unsigned int secno =GET_SEC_FROM_SEG (sbi, segno); +unsigned int start_segno =GET_SEG_FROM_SEC (sbi, secno);unsigned int next;spin_lock (&free_i->segmap_lock);
@@ -381,7 +385,8 @@ static inline void __set_inuse(struct f2fs_sb_info *sbi, unsigned int segno) {struct free_segmap_info *free_i =FREE_I (sbi); -unsigned int secno = segno / sbi->segs_per_sec; +unsigned int secno =GET_SEC_FROM_SEG (sbi, segno); +set_bit (segno, free_i->free_segmap); free_i->free_segments--;if (!test_and_set_bit (secno, free_i->free_secmap))
@@ -392,8 +397,8 @@ static inline void __set_test_and_free(struct f2fs_sb_info *sbi, unsigned int segno) {struct free_segmap_info *free_i =FREE_I (sbi); -unsigned int secno = segno / sbi->segs_per_sec; -unsigned int start_segno = secno * sbi->segs_per_sec; +unsigned int secno =GET_SEC_FROM_SEG (sbi, segno); +unsigned int start_segno =GET_SEG_FROM_SEC (sbi, secno);unsigned int next;spin_lock (&free_i->segmap_lock);
@@ -414,7 +419,8 @@ static inline void __set_test_and_inuse(struct f2fs_sb_info *sbi, unsigned int segno) {struct free_segmap_info *free_i =FREE_I (sbi); -unsigned int secno = segno / sbi->segs_per_sec; +unsigned int secno =GET_SEC_FROM_SEG (sbi, segno); +spin_lock (&free_i->segmap_lock);if (!test_and_set_bit (segno, free_i->free_segmap)) { free_i->free_segments--;
@@ -479,12 +485,12 @@ static inline int overprovision_segments(struct f2fs_sb_info *sbi)static inline int overprovision_sections (struct f2fs_sb_info *sbi) { -return ((unsigned int )overprovision_segments (sbi)) / sbi->segs_per_sec; +return GET_SEC_FROM_SEG (sbi, (unsigned int )overprovision_segments (sbi)); }static inline int reserved_sections (struct f2fs_sb_info *sbi) { -return ((unsigned int )reserved_segments (sbi)) / sbi->segs_per_sec; +return GET_SEC_FROM_SEG (sbi, (unsigned int )reserved_segments (sbi)); }static inline bool need_SSR (struct f2fs_sb_info *sbi)
@@ -722,7 +728,7 @@ static inline block_t sum_blk_addr(struct f2fs_sb_info *sbi, int base, int type)static inline bool no_fggc_candidate (struct f2fs_sb_info *sbi,unsigned int secno) { -if (get_valid_blocks (sbi,GET_SEGNO_FROM_SECNO (sbi, secno), true) >= +if (get_valid_blocks (sbi,GET_SEG_FROM_SEC (sbi, secno), true) >= sbi->fggc_threshold)return true;return false;
Signature · 6 lines
2.11.0 ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
Jaegeuk Kim
maintainerPATCH 4/4 f2fs: avoid frequent checkpoint during f2fs_gc
In reply to Jaegeuk KimNow we're doing SSR aggressively more than ever before, so once we reach to the reserved_segment, f2fs_balance_fs will call f2fs_gc, which triggers checkpoint everytime. We actually must avoid that.
--- fs/f2fs/gc.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
fs/f2fs/gc.c +5 -1
@@ -966,7 +966,11 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync, bool background)* threshold, we can make them free by checkpoint. Then, we * secure free segments which doesn't need fggc any more. */ - ret =write_checkpoint (sbi, &cpc); +if (prefree_segments (sbi)) { + ret =write_checkpoint (sbi, &cpc); +if (ret) + goto stop; + }if (ret) goto stop;if (has_not_enough_free_secs (sbi,0 ,0 ))
Signature · 1 line
2.11.0
Re: [PATCH 4/4] f2fs: avoid frequent checkpoint during f2fs_gc
Quoted 15 lines · Jaegeuk Kim
Now we're doing SSR aggressively more than ever before, so once we reach to the
reserved_segment,f2fs_balance_fswill callf2fs_gc, which triggers checkpoint everytime. We actually must avoid that.Signed-off-by Jaegeuk Kim <[email protected]>--- fs/f2fs/gc.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)fs/f2fs/gc.c +0
-0@@ -966,7 +966,11 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync, bool background)* threshold, we can make them free by checkpoint. Then, we
fs/f2fs/gc.c int f2fs_gc(struct f2fs_sb_info *sbi, bool sync, bool background) · line 975
Quoted 10 lines
fs/f2fs/gc.c +5
-1* secure free segments which doesn't need fggc any more. */ - ret =write_checkpoint (sbi, &cpc); +if (prefree_segments (sbi)) { + ret =write_checkpoint (sbi, &cpc); +if (ret) + goto stop; + }if (ret) goto stop;
We don't need redundant check here?
Otherwise, this patchset looks good to me, anyway please add:
Thanks,
Quoted 2 lines
fs/f2fs/gc.c +0
-0if (has_not_enough_free_secs (sbi,0 ,0 ))
Jaegeuk Kim
maintainerRe: [PATCH 4/4] f2fs: avoid frequent checkpoint during f2fs_gc
Quoted 20 lines · Chao Yu
Quoted 19 lines · Jaegeuk Kim
Now we're doing SSR aggressively more than ever before, so once we reach to the
reserved_segment,f2fs_balance_fswill callf2fs_gc, which triggers checkpoint everytime. We actually must avoid that.Signed-off-by Jaegeuk Kim <[email protected]>--- fs/f2fs/gc.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)fs/f2fs/gc.c +1
-1@@ -966,7 +966,11 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync, bool background)* threshold, we can make them free by checkpoint. Then, we * secure free segments which doesn't need fggc any more. */ - ret =write_checkpoint (sbi, &cpc); +if (prefree_segments (sbi)) {
Quoted 8 lines
fs/f2fs/gc.c int f2fs_gc(struct f2fs_sb_info *sbi, bool sync, bool background) · line 975
Quoted 6 lines
fs/f2fs/gc.c +4
-0+ ret =write_checkpoint (sbi, &cpc); +if (ret) + goto stop; + }if (ret) goto stop;We don't need redundant check here?
Yup, will remove this. ;)
Quoted 4 lines
Otherwise, this patchset looks good to me, anyway please add:
Reviewed-by Chao Yu <[email protected]>
Thanks,
Quoted 5 lines
Thanks,
Quoted 2 lines
fs/f2fs/gc.c +0
-0if (has_not_enough_free_secs (sbi,0 ,0 ))