checkpatch: special audit for revert commit line
PATCH 1/1 checkpatch: special audit for revert commit line
From: Wei Wang <[email protected]>
Currently checkpatch.pl does not recognize revert commits and complains about the commit hash format.
Add special audit for revert commit to fix it.
Signed-off-by Wei Wang <[email protected]>
--- scripts/checkpatch.pl | 1 + 1 file changed, 1 insertion(+)
scripts/checkpatch.pl +1 -0
@@ -2539,6 +2539,7 @@ sub process { # Check for git id commit length and improperly formed commit descriptions if ($in_commit_log && !$commit_log_possible_stack_dump && $line !~ /^\s*(?:Link|Patchwork|http|https|BugLink):/i && + $line !~ /^This reverts commit [0-9a-f]{12,40}\./ && ($line =~ /\bcommit\s+[0-9a-f]{5,}\b/i || ($line =~ /(?:\s|^)[0-9a-f]{12,40}(?:[\s"'\(\[]|$)/i && $line !~ /[\<\[][0-9a-f]{12,40}[\>\]]/i &&
Signature · 1 line
2.12.2.715.g7642488e1d-goog
Joe Perches
maintainerQuoted 5 lines · Wei Wang
From: Wei Wang <[email protected]>
Currently checkpatch.pl does not recognize revert commits and complains about the commit hash format.
Add special audit for revert commit to fix it.
The commit wording seems a bit off, but I guess it's OK.
The 'This reverts commit <sha1>.' is git's default commit revert message.
There are many uses that contain additional content after the sha1 in git log so perhaps using
$line !~ /^This reverts commit [0-9a-f]{7,40}/is more robust/better.
$ git log --format=email --grep=revert -i -100000 | \
grep "This reverts commit" | \
sed -r 's/This reverts commit [0-9a-f]{12,40}\.?//' | \
sort | uniq
<a longish list of modified git revert commit messages>Quoted 17 lines
Signed-off-by Wei Wang <[email protected]>--- scripts/checkpatch.pl | 1 + 1 file changed, 1 insertion(+)scripts/checkpatch.pl +1
-0@@ -2539,6 +2539,7 @@ sub process { # Check for git id commit length and improperly formed commit descriptions if ($in_commit_log && !$commit_log_possible_stack_dump && $line !~ /^\s*(?:Link|Patchwork|http|https|BugLink):/i && + $line !~ /^This reverts commit [0-9a-f]{12,40}\./ && ($line =~ /\bcommit\s+[0-9a-f]{5,}\b/i || ($line =~ /(?:\s|^)[0-9a-f]{12,40}(?:[\s"'\(\[]|$)/i && $line !~ /[\<\[][0-9a-f]{12,40}[\>\]]/i &&