perf tool: build and usage hints

This change is a follow up of https://lkml.org/lkml/2017/2/2/16

The patch above avoided redefining CC, CXX and PKG_CONFIG in feature detection. The patch was not merged due to a unsolved concern with the -MD flag.

Later, commit c8c188679c ("tools build: Use the same CC for feature
detection and actual build")
did the change for CC and CXX but not PKG_CONFIG.

This patch makes PKG_CONFIG consistent with CC and CXX and moves the -MD to CFLAGS, as suggested by Jiri in the thread above.

Signed-off-by David Carrillo-Cisneros <[email protected]>

---
 tools/build/feature/Makefile | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

tools/build/feature/Makefile +5 -5

index 523e587fe05f..e35e4e5ad192 100644
@@ -53,17 +53,17 @@ FILES=                                          \
 
 FILES := $(addprefix $(OUTPUT),$(FILES))
 
-CC ?= $(CROSS_COMPILE)gcc -MD
-CXX ?= $(CROSS_COMPILE)g++ -MD
-PKG_CONFIG := $(CROSS_COMPILE)pkg-config
+CC ?= $(CROSS_COMPILE)gcc
+CXX ?= $(CROSS_COMPILE)g++
+PKG_CONFIG ?= $(CROSS_COMPILE)pkg-config
 LLVM_CONFIG ?= llvm-config
 
 all: $(FILES)
 
-__BUILD = $(CC) $(CFLAGS) -Wall -Werror -o $@ $(patsubst %.bin,%.c,$(@F)) $(LDFLAGS)
+__BUILD = $(CC) $(CFLAGS) -MD -Wall -Werror -o $@ $(patsubst %.bin,%.c,$(@F)) $(LDFLAGS)
   BUILD = $(__BUILD) > $(@:.bin=.make.output) 2>&1
 
-__BUILDXX = $(CXX) $(CXXFLAGS) -Wall -Werror -o $@ $(patsubst %.bin,%.cpp,$(@F)) $(LDFLAGS)
+__BUILDXX = $(CXX) $(CXXFLAGS) -MD -Wall -Werror -o $@ $(patsubst %.bin,%.cpp,$(@F)) $(LDFLAGS)
   BUILDXX = $(__BUILDXX) > $(@:.bin=.make.output) 2>&1
 
 ###############################

Signature · 1 line

2.12.2.715.g7642488e1d-goog

Quoted 1 line · David Carrillo-Cisneros

This change is a follow up of https://lkml.org/lkml/2017/2/2/16

hi,
there's another 2/6 in this patchset with same change but slightly different changelog

Quoted 4 lines · David Carrillo-Cisneros

Quoted 1 line

This change is a follow up of https://lkml.org/lkml/2017/2/2/16

Quoted 3 lines

hi,
there's another 2/6 in this patchset with same change but slightly different changelog

Uups, I did not rm the old version before sending. The other one is the latest version.

My fat-fingering of sort keys in .perfconfig was a common cause of perf report silently terminating without apparent error.

This was because 1) error in setup_sorting in cmd_report was ignored and 2) no message was log in UI browser that would prevent UI from exit before user prompt. Fix both.

Quoted 6 lines

My fat-fingering of sort keys in .perfconfig was a common cause of perf report silently terminating without apparent error.

This was because 1) error in setup_sorting in cmd_report was ignored and 2) no message was log in UI browser that would prevent UI from exit before user prompt. Fix both.

there's UI init ahead of this code.. I had to move it below your code to spot any error message

there's other errors further on.. perhaps we should move it even further ;-) or cancel the ui before the error is printed

jirka

---

tools/perf/builtin-report.c +5 -5

index 19a69ca0e9c9..abcf3aadca9e 100644
@@ -982,11 +982,6 @@ int cmd_report(int argc, const char **argv)
        if (report.header || report.header_only || report.show_threads)
                use_browser = 0;
 
-       if (strcmp(input_name, "-") != 0)
-               setup_browser(true);
-       else
-               use_browser = 0;
-
        ret = setup_sorting(session->evlist);
        if (ret < 0) {
                if (sort_order)

@@ -999,6 +994,11 @@ int cmd_report(int argc, const char **argv)
                goto error;
        }
 
+       if (strcmp(input_name, "-") != 0)
+               setup_browser(true);
+       else
+               use_browser = 0;
+
        if ((report.header || report.header_only) && !quiet) {
                perf_session__fprintf_info(session, stdout,
                                           report.show_full_info);

Quoted 8 lines · David Carrillo-Cisneros

Quoted 6 lines

My fat-fingering of sort keys in .perfconfig was a common cause of perf report silently terminating without apparent error.

This was because 1) error in setup_sorting in cmd_report was ignored and 2) no message was log in UI browser that would prevent UI from exit before user prompt. Fix both.

Quoted 5 lines

there's UI init ahead of this code.. I had to move it below your code to spot any error message

there's other errors further on.. perhaps we should move it even further ;-) or cancel the ui before the error is printed

Probably canceling ui on error is the more robust way to go. I will look into it.

The build of JVMTI depends on LIBELF (-lelf). Make Makefile.conf check this dependendancy and notify user when not present.

Signed-off-by David Carrillo-Cisneros <[email protected]>

---
 tools/perf/Makefile.config | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

tools/perf/Makefile.config +1 -0

index cfd6015229a2..279c303b2c22 100644
@@ -274,6 +274,7 @@ ifdef NO_LIBELF
   NO_LIBUNWIND := 1
   NO_LIBDW_DWARF_UNWIND := 1
   NO_LIBBPF := 1
+  NO_JVMTI := 1
 else
   ifeq ($(feature-libelf), 0)
     ifeq ($(feature-glibc), 1)

The build of JVMTI depends on LIBELF (-lelf). Make Makefile.conf check this dependendancy and notify user when not present.

v2: Comma nitpicking.

Signed-off-by David Carrillo-Cisneros <[email protected]>

---
 tools/perf/Makefile.config | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

tools/perf/Makefile.config +3 -1

index cfd6015229a2..279c303b2c22 100644
@@ -274,6 +274,7 @@ ifdef NO_LIBELF
   NO_LIBUNWIND := 1
   NO_LIBDW_DWARF_UNWIND := 1
   NO_LIBBPF := 1
+  NO_JVMTI := 1
 else
   ifeq ($(feature-libelf), 0)
     ifeq ($(feature-glibc), 1)

@@ -283,7 +284,7 @@ else
       LIBC_SUPPORT := 1
     endif
     ifeq ($(LIBC_SUPPORT),1)
-      msg := $(warning No libelf found, disables 'probe' tool and BPF support in 'perf record', please install libelf-dev, libelf-devel or elfutils-libelf-devel);
+      msg := $(warning No libelf found. Disables 'probe' tool, jvmti and BPF support in 'perf record'. Please install libelf-dev, libelf-devel or elfutils-libelf-devel);
 
       NO_LIBELF := 1
       NO_DWARF := 1

@@ -291,6 +292,7 @@ else
       NO_LIBUNWIND := 1
       NO_LIBDW_DWARF_UNWIND := 1
       NO_LIBBPF := 1
+      NO_JVMTI := 1
     else
       ifneq ($(filter s% -static%,$(LDFLAGS),),)
         msg := $(error No static glibc found, please install glibc-static);

Signature · 1 line

2.12.2.715.g7642488e1d-goog

Quoted 4 lines

The build of JVMTI depends on LIBELF (-lelf). Make Makefile.conf check this dependendancy and notify user when not present.

v2: Comma nitpicking.

I think Arnaldo would change that.. but thanks! ;-)

jirka

Quoted 38 lines

Signed-off-by David Carrillo-Cisneros <[email protected]>

---
 tools/perf/Makefile.config | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

tools/perf/Makefile.config +3 -1

index cfd6015229a2..279c303b2c22 100644
@@ -274,6 +274,7 @@ ifdef NO_LIBELF
   NO_LIBUNWIND := 1
   NO_LIBDW_DWARF_UNWIND := 1
   NO_LIBBPF := 1
+  NO_JVMTI := 1
 else
   ifeq ($(feature-libelf), 0)
     ifeq ($(feature-glibc), 1)

@@ -283,7 +284,7 @@ else
       LIBC_SUPPORT := 1
     endif
     ifeq ($(LIBC_SUPPORT),1)
-      msg := $(warning No libelf found, disables 'probe' tool and BPF support in 'perf record', please install libelf-dev, libelf-devel or elfutils-libelf-devel);
+      msg := $(warning No libelf found. Disables 'probe' tool, jvmti and BPF support in 'perf record'. Please install libelf-dev, libelf-devel or elfutils-libelf-devel);
 
       NO_LIBELF := 1
       NO_DWARF := 1

@@ -291,6 +292,7 @@ else
       NO_LIBUNWIND := 1
       NO_LIBDW_DWARF_UNWIND := 1
       NO_LIBBPF := 1
+      NO_JVMTI := 1
     else
       ifneq ($(filter s% -static%,$(LDFLAGS),),)
         msg := $(error No static glibc found, please install glibc-static);

Signature · 1 line

2.12.2.715.g7642488e1d-goog

The build of JVMTI depends on LIBELF (-lelf). Make Makefile.conf check this dependendancy and notify user when not present.

Signed-off-by David Carrillo-Cisneros <[email protected]>

---

Minor build fixes and error condition hints.

David Carrillo-Cisneros (6):
perf tools: pass PYTHON config to feature detection tools build: fix feature detection redefinion of build flags perf util: hint missing file when tool tips fail to load perf report: hint .perfconfig error when invalid sorting key perf tools: disable JVMTI if no ELF support available Revert "perf tools: Fix include of linux/mman.h"