ixgbe: Allow setting zero MAC address for VF
Subsystems (2)
Tony Nguyen
maintainerPATCH 1/1 ixgbe: Allow setting zero MAC address for VF
Currently, there is no logic that allows a VF's MAC address to be removed from the RAR table.
Allow the user to specify a zero MAC address in order to clear the VF's MAC address from the RAR table. This functionality is also utilized by libvirt when removing VFs.
--- drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 28 +++++++++++++++++--------- 1 file changed, 18 insertions(+), 10 deletions(-)
drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c +18 -10
@@ -1347,18 +1347,26 @@ void ixgbe_ping_all_vfs(struct ixgbe_adapter *adapter)int ixgbe_ndo_set_vf_mac (struct net_device *netdev,int vf,u8 *mac) {struct ixgbe_adapter *adapter =netdev_priv (netdev); -if (!is_valid_ether_addr (mac) || (vf >= adapter->num_vfs)) + +if (vf >= adapter->num_vfs) +return -EINVAL ; + +if (is_zero_ether_addr (mac)) { + adapter->vfinfo[vf].pf_set_mac = false; +dev_info (&adapter->pdev->dev,"removing MAC on VF %d\n" , vf); + }else if (is_valid_ether_addr (mac)) { + adapter->vfinfo[vf].pf_set_mac = true; +dev_info (&adapter->pdev->dev,"setting MAC %pM on VF %d\n" , + mac, vf); +dev_info (&adapter->pdev->dev,"Reload the VF driver to make this change effective." ); +if (test_bit (__IXGBE_DOWN, &adapter->state)) { +dev_warn (&adapter->pdev->dev,"The VF MAC address has been set, but the PF device is not up.\n" ); +dev_warn (&adapter->pdev->dev,"Bring the PF device up before attempting to use the VF device.\n" ); + } + }else {return -EINVAL ; - adapter->vfinfo[vf].pf_set_mac = true; -dev_info (&adapter->pdev->dev,"setting MAC %pM on VF %d\n" , mac, vf); -dev_info (&adapter->pdev->dev,"Reload the VF driver to make this" -" change effective." ); -if (test_bit (__IXGBE_DOWN, &adapter->state)) { -dev_warn (&adapter->pdev->dev,"The VF MAC address has been set," -" but the PF device is not up.\n" ); -dev_warn (&adapter->pdev->dev,"Bring the PF device up before" -" attempting to use the VF device.\n" ); } +return ixgbe_set_vf_mac (adapter, vf, mac); }
Signature · 1 line
2.9.3
Bowers
PATCH 1/1 ixgbe: Allow setting zero MAC address for VF
Quoted 15 lines
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On Behalf Of Tony Nguyen
Sent: Wednesday, April 12, 2017 1:35 PM
To: intel-wired-lan at lists.osuosl.org
Subject: [Intel-wired-lan] [PATCH] ixgbe: Allow setting zero MAC address for VFCurrently, there is no logic that allows a VF's MAC address to be removed from the RAR table.
Allow the user to specify a zero MAC address in order to clear the VF's MAC address from the RAR table. This functionality is also utilized by libvirt when removing VFs.
Quoted 5 lines
Signed-off-by Tony Nguyen <[email protected]>--- drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 28 +++++++++++++++++-- ------- 1 file changed, 18 insertions(+), 10 deletions(-)