Skip to contentSkip to conversation

selftests: Fix trivial nitpicks

PATCH Superseded SeongJae Park 2 participants 12 messages Apr 13, 2017 – Apr 27, 2017 Kselftest

lore
Share & tools
lore
#0 lore raw

cover selftests: Fix trivial nitpicks

This patchset fixes trivial nitpicks under selftests.

SeongJae Park (4):
selftests/Makefile: Add missed closing " in comment selftests/Makefile: Add missed PHONY targets selftests/vm/run_vmtests: Polish output text selftests/vm/run_vmtests: Fix wrong comment

 tools/testing/selftests/Makefile       |  4 ++--
 tools/testing/selftests/vm/run_vmtests | 26 +++++++++++++-------------
 2 files changed, 15 insertions(+), 15 deletions(-)
Signature · 1 line
2.12.0
#1 lore raw

PATCH 1/4 selftests/Makefile: Add missed closing `"` in comment

---
 tools/testing/selftests/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/Makefile +1 -1
index d8593f1251ec..395ab296c084 100644
@@ -39,7 +39,7 @@ TARGETS += x86
 TARGETS += zram
 #Please keep the TARGETS list alphabetically sorted
 # Run "make quicktest=1 run_tests" or
-# "make quicktest=1 kselftest from top level Makefile
+# "make quicktest=1 kselftest" from top level Makefile
 
 TARGETS_HOTPLUG = cpu-hotplug
 TARGETS_HOTPLUG += memory-hotplug
Signature · 1 line
2.12.0
maintainer
#2 lore raw

Re: [PATCH 1/4] selftests/Makefile: Add missed closing `"` in comment

Quoted 11 lines · SeongJae Park
---
 tools/testing/selftests/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/Makefile +0 -0
index d8593f1251ec..395ab296c084 100644

tools/testing/selftests/Makefile TARGETS += x86 · line 45

Quoted 8 lines
tools/testing/selftests/Makefile +1 -1
@@ -39,7 +39,7 @@ TARGETS += x86
 TARGETS += zram
 #Please keep the TARGETS list alphabetically sorted
 # Run "make quicktest=1 run_tests" or
-# "make quicktest=1 kselftest from top level Makefile
+# "make quicktest=1 kselftest" from top level Makefile
 
 TARGETS_HOTPLUG = cpu-hotplug
 TARGETS_HOTPLUG += memory-hotplug

This patch is missing changelog - please add and resend.

thanks,
-- Shuah

#3 lore raw

Re: [PATCH 1/4] selftests/Makefile: Add missed closing `"` in comment

Quoted 17 lines · Shuah Khan
Quoted 16 lines · SeongJae Park
---
 tools/testing/selftests/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/Makefile +1 -1
index d8593f1251ec..395ab296c084 100644
@@ -39,7 +39,7 @@ TARGETS += x86
 TARGETS += zram
 #Please keep the TARGETS list alphabetically sorted
 # Run "make quicktest=1 run_tests" or
-# "make quicktest=1 kselftest from top level Makefile
+# "make quicktest=1 kselftest" from top level Makefile
 
Quoted 5 lines

tools/testing/selftests/Makefile TARGETS += x86 · line 45

Quoted 3 lines
tools/testing/selftests/Makefile +0 -0
 TARGETS_HOTPLUG = cpu-hotplug
 TARGETS_HOTPLUG += memory-hotplug

This patch is missing changelog - please add and resend.

OK, I will resend it as a reply to this.

Thanks,
SeongJae Park

Quoted 3 lines

thanks,
-- Shuah

#4 lore raw

PATCH v2 1/1 selftests/Makefile: Add missed closing `"` in comment

A comment for make command usage in selftets/Makefile has opening " but no closing ". This commit adds the missed " in the comment.

---
 tools/testing/selftests/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/Makefile +1 -1
index d8593f1251ec..395ab296c084 100644
@@ -39,7 +39,7 @@ TARGETS += x86
 TARGETS += zram
 #Please keep the TARGETS list alphabetically sorted
 # Run "make quicktest=1 run_tests" or
-# "make quicktest=1 kselftest from top level Makefile
+# "make quicktest=1 kselftest" from top level Makefile
 
 TARGETS_HOTPLUG = cpu-hotplug
 TARGETS_HOTPLUG += memory-hotplug
Signature · 1 line
2.12.0
maintainer
#5 lore raw

Re: [PATCH v2] selftests/Makefile: Add missed closing `"` in comment

Quoted 14 lines · SeongJae Park

A comment for make command usage in selftets/Makefile has opening " but no closing ". This commit adds the missed " in the comment.

---
 tools/testing/selftests/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/Makefile +0 -0
index d8593f1251ec..395ab296c084 100644

tools/testing/selftests/Makefile TARGETS += x86 · line 45

Quoted 8 lines
tools/testing/selftests/Makefile +1 -1
@@ -39,7 +39,7 @@ TARGETS += x86
 TARGETS += zram
 #Please keep the TARGETS list alphabetically sorted
 # Run "make quicktest=1 run_tests" or
-# "make quicktest=1 kselftest from top level Makefile
+# "make quicktest=1 kselftest" from top level Makefile
 
 TARGETS_HOTPLUG = cpu-hotplug
 TARGETS_HOTPLUG += memory-hotplug

Applied to linux-kselftest next for 4.12-rc1

thanks for the patch.

-- Shuah

#6 lore raw

PATCH v2 1/1 selftests/Makefile: Add missed PHONY targets

In reply to SeongJae Park

selftests/Makefile is defining only install as entire PHONY target though there are few more PHONY targets including run_tests. This commit defines them as the PHONY targets.

---
 tools/testing/selftests/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/Makefile +1 -1
index 395ab296c084..26ce4f7168be 100644
@@ -133,4 +133,4 @@ clean:
 		make OUTPUT=$$BUILD_TARGET -C $$TARGET clean;\
 	done;
 
-.PHONY: install
+.PHONY: all run_tests hotplug run_hotplug clean_hotplug run_pstore_crash install clean
Signature · 1 line
2.12.0
#7 lore raw

PATCH 2/4 selftests/Makefile: Add missed PHONY targets

In reply to SeongJae Park
---
 tools/testing/selftests/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/Makefile +1 -1
index 395ab296c084..26ce4f7168be 100644
@@ -133,4 +133,4 @@ clean:
 		make OUTPUT=$$BUILD_TARGET -C $$TARGET clean;\
 	done;
 
-.PHONY: install
+.PHONY: all run_tests hotplug run_hotplug clean_hotplug run_pstore_crash install clean
Signature · 1 line
2.12.0
maintainer
#8 lore raw

Re: [PATCH 2/4] selftests/Makefile: Add missed PHONY targets

Quoted 11 lines · SeongJae Park
---
 tools/testing/selftests/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/Makefile +0 -0
index 395ab296c084..26ce4f7168be 100644

tools/testing/selftests/Makefile clean: · line 136

Quoted 5 lines
tools/testing/selftests/Makefile +1 -1
@@ -133,4 +133,4 @@ clean:
 		make OUTPUT=$$BUILD_TARGET -C $$TARGET clean;\
 	done;
 
-.PHONY: install
+.PHONY: all run_tests hotplug run_hotplug clean_hotplug run_pstore_crash install clean

Missing changelog - please add and resend.

thanks,
-- Shuah

#9 lore raw

Re: [PATCH 2/4] selftests/Makefile: Add missed PHONY targets

Quoted 14 lines · Shuah Khan
Quoted 13 lines · SeongJae Park
---
 tools/testing/selftests/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/Makefile +0 -0
index 395ab296c084..26ce4f7168be 100644
@@ -133,4 +133,4 @@ clean:
              make OUTPUT=$$BUILD_TARGET -C $$TARGET clean;\
      done;
 
Quoted 5 lines

tools/testing/selftests/Makefile clean: · line 136

Quoted 3 lines
tools/testing/selftests/Makefile +1 -1
-.PHONY: install
+.PHONY: all run_tests hotplug run_hotplug clean_hotplug run_pstore_crash install clean

Missing changelog - please add and resend.

Ok, I will send it as a reply to this.

Thanks,
SeongJae Park

Quoted 3 lines

thanks,
-- Shuah

#10 lore raw

PATCH v2 1/1 selftests/Makefile: Add missed PHONY targets

selftests/Makefile is defining only install as entire PHONY target though there are few more PHONY targets including run_tests. This commit defines them as the PHONY targets.

---
 tools/testing/selftests/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/Makefile +1 -1
index 395ab296c084..26ce4f7168be 100644
@@ -133,4 +133,4 @@ clean:
 		make OUTPUT=$$BUILD_TARGET -C $$TARGET clean;\
 	done;
 
-.PHONY: install
+.PHONY: all run_tests hotplug run_hotplug clean_hotplug run_pstore_crash install clean
Signature · 1 line
2.12.0
maintainer
#11 lore raw

Re: [PATCH v2] selftests/Makefile: Add missed PHONY targets

Quoted 15 lines · SeongJae Park

selftests/Makefile is defining only install as entire PHONY target though there are few more PHONY targets including run_tests. This commit defines them as the PHONY targets.

---
 tools/testing/selftests/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/Makefile +0 -0
index 395ab296c084..26ce4f7168be 100644

tools/testing/selftests/Makefile clean: · line 136

Quoted 5 lines
tools/testing/selftests/Makefile +1 -1
@@ -133,4 +133,4 @@ clean:
 		make OUTPUT=$$BUILD_TARGET -C $$TARGET clean;\
 	done;
 
-.PHONY: install
+.PHONY: all run_tests hotplug run_hotplug clean_hotplug run_pstore_crash install clean

Applied to linux-kselftest next for 4.12-rc1

thanks for the patch.

-- Shuah