selftests: Fix trivial nitpicks
cover selftests: Fix trivial nitpicks
This patchset fixes trivial nitpicks under selftests.
SeongJae Park (4):
selftests/Makefile: Add missed closing " in comment selftests/Makefile: Add missed PHONY targets selftests/vm/run_vmtests: Polish output text selftests/vm/run_vmtests: Fix wrong comment
tools/testing/selftests/Makefile | 4 ++-- tools/testing/selftests/vm/run_vmtests | 26 +++++++++++++------------- 2 files changed, 15 insertions(+), 15 deletions(-)
Signature · 1 line
2.12.0
PATCH 1/4 selftests/Makefile: Add missed closing `"` in comment
--- tools/testing/selftests/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/Makefile +1 -1
@@ -39,7 +39,7 @@ TARGETS += x86 TARGETS += zram #Please keep the TARGETS list alphabetically sorted # Run "make quicktest=1 run_tests" or -# "make quicktest=1 kselftest from top level Makefile +# "make quicktest=1 kselftest" from top level Makefile TARGETS_HOTPLUG = cpu-hotplug TARGETS_HOTPLUG += memory-hotplug
Signature · 1 line
2.12.0
Shuah Khan
maintainerRe: [PATCH 1/4] selftests/Makefile: Add missed closing `"` in comment
Quoted 11 lines · SeongJae Park
Signed-off-by SeongJae Park <[email protected]>--- tools/testing/selftests/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/testing/selftests/Makefile +0
-0
tools/testing/selftests/Makefile TARGETS += x86 · line 45
Quoted 8 lines
tools/testing/selftests/Makefile +1
-1@@ -39,7 +39,7 @@ TARGETS += x86 TARGETS += zram #Please keep the TARGETS list alphabetically sorted # Run "make quicktest=1 run_tests" or -# "make quicktest=1 kselftest from top level Makefile +# "make quicktest=1 kselftest" from top level Makefile TARGETS_HOTPLUG = cpu-hotplug TARGETS_HOTPLUG += memory-hotplug
This patch is missing changelog - please add and resend.
thanks,
-- Shuah
Re: [PATCH 1/4] selftests/Makefile: Add missed closing `"` in comment
Quoted 17 lines · Shuah Khan
Quoted 16 lines · SeongJae Park
Signed-off-by SeongJae Park <[email protected]>--- tools/testing/selftests/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/testing/selftests/Makefile +1
-1@@ -39,7 +39,7 @@ TARGETS += x86 TARGETS += zram #Please keep the TARGETS list alphabetically sorted # Run "make quicktest=1 run_tests" or -# "make quicktest=1 kselftest from top level Makefile +# "make quicktest=1 kselftest" from top level Makefile
Quoted 5 lines
tools/testing/selftests/Makefile TARGETS += x86 · line 45
Quoted 3 lines
tools/testing/selftests/Makefile +0
-0TARGETS_HOTPLUG = cpu-hotplug TARGETS_HOTPLUG += memory-hotplugThis patch is missing changelog - please add and resend.
OK, I will resend it as a reply to this.
Thanks,
SeongJae Park
Quoted 3 lines
thanks,
-- Shuah
PATCH v2 1/1 selftests/Makefile: Add missed closing `"` in comment
A comment for make command usage in selftets/Makefile has opening " but no closing ". This commit adds the missed " in the comment.
--- tools/testing/selftests/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/Makefile +1 -1
@@ -39,7 +39,7 @@ TARGETS += x86 TARGETS += zram #Please keep the TARGETS list alphabetically sorted # Run "make quicktest=1 run_tests" or -# "make quicktest=1 kselftest from top level Makefile +# "make quicktest=1 kselftest" from top level Makefile TARGETS_HOTPLUG = cpu-hotplug TARGETS_HOTPLUG += memory-hotplug
Signature · 1 line
2.12.0
Shuah Khan
maintainerRe: [PATCH v2] selftests/Makefile: Add missed closing `"` in comment
Quoted 14 lines · SeongJae Park
A comment for make command usage in
selftets/Makefilehas opening"but no closing". This commit adds the missed"in the comment.Signed-off-by SeongJae Park <[email protected]>--- tools/testing/selftests/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/testing/selftests/Makefile +0
-0
tools/testing/selftests/Makefile TARGETS += x86 · line 45
Quoted 8 lines
tools/testing/selftests/Makefile +1
-1@@ -39,7 +39,7 @@ TARGETS += x86 TARGETS += zram #Please keep the TARGETS list alphabetically sorted # Run "make quicktest=1 run_tests" or -# "make quicktest=1 kselftest from top level Makefile +# "make quicktest=1 kselftest" from top level Makefile TARGETS_HOTPLUG = cpu-hotplug TARGETS_HOTPLUG += memory-hotplug
Applied to linux-kselftest next for 4.12-rc1
thanks for the patch.
-- Shuah
PATCH v2 1/1 selftests/Makefile: Add missed PHONY targets
In reply to SeongJae Parkselftests/Makefile is defining only install as entire PHONY target though there are few more PHONY targets including run_tests. This commit defines them as the PHONY targets.
--- tools/testing/selftests/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/Makefile +1 -1
@@ -133,4 +133,4 @@ clean: make OUTPUT=$$BUILD_TARGET -C $$TARGET clean;\ done; -.PHONY: install +.PHONY: all run_tests hotplug run_hotplug clean_hotplug run_pstore_crash install clean
Signature · 1 line
2.12.0
PATCH 2/4 selftests/Makefile: Add missed PHONY targets
In reply to SeongJae Park--- tools/testing/selftests/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/Makefile +1 -1
@@ -133,4 +133,4 @@ clean: make OUTPUT=$$BUILD_TARGET -C $$TARGET clean;\ done; -.PHONY: install +.PHONY: all run_tests hotplug run_hotplug clean_hotplug run_pstore_crash install clean
Signature · 1 line
2.12.0
Shuah Khan
maintainerRe: [PATCH 2/4] selftests/Makefile: Add missed PHONY targets
Quoted 11 lines · SeongJae Park
Signed-off-by SeongJae Park <[email protected]>--- tools/testing/selftests/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/testing/selftests/Makefile +0
-0
tools/testing/selftests/Makefile clean: · line 136
Quoted 5 lines
tools/testing/selftests/Makefile +1
-1@@ -133,4 +133,4 @@ clean: make OUTPUT=$$BUILD_TARGET -C $$TARGET clean;\ done; -.PHONY: install +.PHONY: all run_tests hotplug run_hotplug clean_hotplug run_pstore_crash install clean
Missing changelog - please add and resend.
thanks,
-- Shuah
Re: [PATCH 2/4] selftests/Makefile: Add missed PHONY targets
Quoted 14 lines · Shuah Khan
Quoted 13 lines · SeongJae Park
Signed-off-by SeongJae Park <[email protected]>--- tools/testing/selftests/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/testing/selftests/Makefile +0
-0@@ -133,4 +133,4 @@ clean: make OUTPUT=$$BUILD_TARGET -C $$TARGET clean;\ done;
Quoted 5 lines
tools/testing/selftests/Makefile clean: · line 136
Quoted 3 lines
tools/testing/selftests/Makefile +1
-1-.PHONY: install +.PHONY: all run_tests hotplug run_hotplug clean_hotplug run_pstore_crash install cleanMissing changelog - please add and resend.
Ok, I will send it as a reply to this.
Thanks,
SeongJae Park
Quoted 3 lines
thanks,
-- Shuah
PATCH v2 1/1 selftests/Makefile: Add missed PHONY targets
selftests/Makefile is defining only install as entire PHONY target though there are few more PHONY targets including run_tests. This commit defines them as the PHONY targets.
--- tools/testing/selftests/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/Makefile +1 -1
@@ -133,4 +133,4 @@ clean: make OUTPUT=$$BUILD_TARGET -C $$TARGET clean;\ done; -.PHONY: install +.PHONY: all run_tests hotplug run_hotplug clean_hotplug run_pstore_crash install clean
Signature · 1 line
2.12.0
Shuah Khan
maintainerRe: [PATCH v2] selftests/Makefile: Add missed PHONY targets
Quoted 15 lines · SeongJae Park
selftests/Makefileis defining onlyinstallas entire PHONY target though there are few more PHONY targets includingrun_tests. This commit defines them as the PHONY targets.Signed-off-by SeongJae Park <[email protected]>--- tools/testing/selftests/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/testing/selftests/Makefile +0
-0
tools/testing/selftests/Makefile clean: · line 136
Quoted 5 lines
tools/testing/selftests/Makefile +1
-1@@ -133,4 +133,4 @@ clean: make OUTPUT=$$BUILD_TARGET -C $$TARGET clean;\ done; -.PHONY: install +.PHONY: all run_tests hotplug run_hotplug clean_hotplug run_pstore_crash install clean
Applied to linux-kselftest next for 4.12-rc1
thanks for the patch.
-- Shuah