Skip to contentSkip to conversation

drm/i915: checking for NULL instead of IS_ERR() in mock selftests

PATCH In review Dan Carpenter 3 participants 4 messages Apr 13, 2017

Subsystems (3)
DRM drivers Intel i915 Kernel janitors
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 drm/i915: checking for NULL instead of IS_ERR() in mock selftests

i915_gem_request_alloc() uses error pointers. It never returns NULLs.

Fixes 0daf0113cff6 ("drm/i915: Mock infrastructure for request emission")
Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/i915/selftests/mock_request.c +1 -1
index 0e8d2e7f8c70..8097e3693ec4 100644
@@ -35,7 +35,7 @@ mock_request(struct intel_engine_cs *engine,
 
 	/* NB the i915->requests slab cache is enlarged to fit mock_request */
 	request = i915_gem_request_alloc(engine, context);
-	if (!request)
+	if (IS_ERR(request))
 		return NULL;
 
 	mock = container_of(request, typeof(*mock), base);

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

CI
#2 lore raw

✓ Fi.CI.BAT: success for drm/i915: checking for NULL instead of IS_ERR() in mock selftests

In reply to Dan Carpenter
== Series Details ==

== Series Details ==

Series: drm/i915: checking for NULL instead of IS_ERR() in mock selftests
URL : https://patchwork.freedesktop.org/series/23040/
State : success

== Summary ==

Series 23040v1 drm/i915: checking for NULL instead of IS_ERR() in mock selftests
https://patchwork.freedesktop.org/api/1.0/series/23040/revisions/1/mbox/

fi-bdw-5557u     total:278  pass:267  dwarn:0   dfail:0   fail:0   skip:11  time:429s
fi-bdw-gvtdvm    total:278  pass:256  dwarn:8   dfail:0   fail:0   skip:14  time:433s
fi-bsw-n3050     total:278  pass:242  dwarn:0   dfail:0   fail:0   skip:36  time:577s
fi-bxt-j4205     total:278  pass:259  dwarn:0   dfail:0   fail:0   skip:19  time:504s
fi-bxt-t5700     total:278  pass:258  dwarn:0   dfail:0   fail:0   skip:20  time:549s
fi-byt-j1900     total:278  pass:254  dwarn:0   dfail:0   fail:0   skip:24  time:485s
fi-byt-n2820     total:278  pass:250  dwarn:0   dfail:0   fail:0   skip:28  time:480s
fi-hsw-4770      total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16  time:406s
fi-hsw-4770r     total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16  time:407s
fi-ilk-650       total:278  pass:228  dwarn:0   dfail:0   fail:0   skip:50  time:411s
fi-ivb-3520m     total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time:489s
fi-ivb-3770      total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time:480s
fi-kbl-7500u     total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time:459s
fi-kbl-7560u     total:278  pass:267  dwarn:1   dfail:0   fail:0   skip:10  time:573s
fi-skl-6260u     total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10  time:449s
fi-skl-6700hq    total:278  pass:261  dwarn:0   dfail:0   fail:0   skip:17  time:568s
fi-skl-6700k     total:278  pass:256  dwarn:4   dfail:0   fail:0   skip:18  time:466s
fi-skl-6770hq    total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10  time:492s
fi-skl-gvtdvm    total:278  pass:265  dwarn:0   dfail:0   fail:0   skip:13  time:432s
fi-snb-2520m     total:278  pass:250  dwarn:0   dfail:0   fail:0   skip:28  time:524s
fi-snb-2600      total:278  pass:249  dwarn:0   dfail:0   fail:0   skip:29  time:408s

0a54b7fee9ecda9257d34e5c3ac8de6516a60a90 drm-tip: 2017y-04m-13d-19h-12m-59s UTC integration manifest b5ac781 drm/i915: checking for NULL instead of IS_ERR() in mock selftests

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4506/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

Re: ✓ Fi.CI.BAT: success for drm/i915: checking for NULL instead of IS_ERR() in mock selftests

Quoted 10 lines · Patchwork

== Series Details ==

Series: drm/i915: checking for NULL instead of IS_ERR() in mock selftests
URL : https://patchwork.freedesktop.org/series/23040/
State : success

== Summary ==

Series 23040v1 drm/i915: checking for NULL instead of IS_ERR() in mock selftests
https://patchwork.freedesktop.org/api/1.0/series/23040/revisions/1/mbox/

Thanks for the patch, pushed.
-Chris

Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx