Skip to contentSkip to conversation

Make ANDROID a menuconfig to ease disabling it all

PATCH In review Vincent Legoll 2 participants 5 messages Apr 14, 2017 Android drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Make ANDROID a menuconfig to ease disabling it all

No need to get into the submenu to disable all ANDROID-related config entries

---
 drivers/android/Kconfig | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)
drivers/android/Kconfig +2 -10
index a82fc02..c2b6c37 100644
@@ -1,15 +1,11 @@
-menu "Android"
-
-config ANDROID
+menuconfig ANDROID
 	bool "Android Drivers"
 	---help---
 	  Enable support for various drivers needed on the Android platform
 
-if ANDROID
-
 config ANDROID_BINDER_IPC
 	bool "Android Binder IPC Driver"
-	depends on MMU
+	depends on ANDROID && MMU
 	default n
 	---help---
 	  Binder is used in Android for both communication between processes,
@@ -43,7 +39,3 @@ config ANDROID_BINDER_IPC_32BIT
 	  earlier).
 
 	  Note that enabling this will break newer Android user-space.
-
-endif # if ANDROID
-
-endmenu
Signature · 1 line
2.9.3
maintainer
#1 lore raw
Quoted 1 line · Vincent Legoll

No need to get into the submenu to disable all ANDROID-related config entries

I don't understand this, what exactly do you mean?

Quoted 29 lines
---
 drivers/android/Kconfig | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)
drivers/android/Kconfig +2 -6
index a82fc02..c2b6c37 100644
@@ -1,15 +1,11 @@
-menu "Android"
-
-config ANDROID
+menuconfig ANDROID
 	bool "Android Drivers"
 	---help---
 	  Enable support for various drivers needed on the Android platform
 
-if ANDROID
-
 config ANDROID_BINDER_IPC
 	bool "Android Binder IPC Driver"
-	depends on MMU
+	depends on ANDROID && MMU
 	default n
 	---help---
 	  Binder is used in Android for both communication between processes,

drivers/android/Kconfig config ANDROID_BINDER_IPC_32BIT · line 49

Quoted 7 lines
drivers/android/Kconfig +0 -4
@@ -43,7 +39,3 @@ config ANDROID_BINDER_IPC_32BIT
 	  earlier).
 
 	  Note that enabling this will break newer Android user-space.
-
-endif # if ANDROID
-
-endmenu

There are other ANDROID config options in the kernel other than right here, so having a "menu" is a bit odd, right?

thanks,

greg k-h

#2 lore raw

Hello,

Quoted 3 lines
Quoted 1 line

No need to get into the submenu to disable all ANDROID-related config entries

I don't understand this, what exactly do you mean?

This is intended for people using make menuconfig to tailor their kernel config to their need by disabling all options they don't need. In order to have a smaller kernel, for example, but also to get smaller build times.

So what this patch (and the others I also sent) is doing:

There was a "menu", under which you have some config entries. In order to disable any or all of those config entries, you have to enter the submenu to then select each one and disable it.

With a menuentry (and config options depending on it), you get a way to disable all those config entries at once without having to enter the menu.

Does that make sense ?
Is there a better way to achieve the disabling-easiness goal ?

Any input appreciated.

Thanks

Signature · 1 line
Vincent Legoll
maintainer
#3 lore raw
Quoted 10 lines · Vincent Legoll

Hello,

Quoted 3 lines
Quoted 1 line

No need to get into the submenu to disable all ANDROID-related config entries

I don't understand this, what exactly do you mean?

This is intended for people using make menuconfig to tailor their kernel config to their need by disabling all options they don't need. In order to have a smaller kernel, for example, but also to get smaller build times.

That's fine, but you aren't actually changing the functionality of any of the build options here. You are just adding a 'menu' and showing things a bit differently. You aren't changing any dependancies (which is what dictates what is and is not built), which does not make it easier, or harder, to disable/enable anything here.

I'm not against this, but you need to explain it a lot better as to what you are doing and why. The "why" isn't covered by the "this will make the kernel build smaller", as that's just not true :)

thanks,

greg k-h

#4 lore raw
Quoted 3 lines · Greg KH

That's fine, but you aren't actually changing the functionality of any of the build options here. You are just adding a 'menu' and showing things a bit differently.

Yes exactly, I did not intend to change functionality, only ease disabling options, by not having to enter the menu. I.e. nothing much, especially for this one where the new now-unconfigurable menu will only have a single config entry inside (in fact I assumed there would be more coming)

That's why I let it stay inside a menu, and not straight removing the menu and moved the config option one level up...

Quoted 3 lines

You aren't changing any dependancies (which
is what dictates what is and is not built), which does not make it easier, or harder, to disable/enable anything here.

I think I don't understand what you're telling here, I added a dep to ANDROID for the ANDROID_BINDER_IPC config entry.

Quoted 3 lines

I'm not against this, but you need to explain it a lot better as to what you are doing and why. The "why" isn't covered by the "this will make the kernel build smaller", as that's just not true :)

This is not intended to make the kernel build smaller, but to ease the tedious process of going through "make menuconfig" and disabling all the options you don't need.

The quantity of options has greatly increased, and when I could do a minimal kernel config in a few minutes years ago, I now have to take tens of minutes going through all. This work is a step trying to make this step quicker.

Is that better ?

Thanks

Signature · 1 line
Vincent Legoll