Skip to contentSkip to conversation

omxplayer: Bump to head and fix missing native dependency

PATCH Applied Andrei Gherzan 3 participants 5 messages Apr 17, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 omxplayer: Bump to head and fix missing native dependency

---
 recipes-multimedia/omxplayer/omxplayer_git.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
recipes-multimedia/omxplayer/omxplayer_git.bb +2 -2
index 72297d0..0e0f9ba 100644
@@ -7,10 +7,10 @@ SECTION = "console/utils"
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
 
-DEPENDS = "libpcre libav virtual/egl boost freetype dbus openssl samba libssh libomxil coreutils-native"
+DEPENDS = "libpcre libav virtual/egl boost freetype dbus openssl samba libssh libomxil coreutils-native curl-native"
 PR = "r4"
 
-SRCREV = "62fb580260adb9b01e5694bb4374fb9a5f6f1021"
+SRCREV = "061425a5eabf6e9ee43229911c073a863d144038"
 SRC_URI = "git://github.com/popcornmix/omxplayer.git;protocol=git;branch=master \
            file://0001-Remove-Makefile.include-which-includes-hardcoded.patch \
            file://0002-Libraries-and-headers-from-ffmpeg-are-installed-in-u.patch \
Signature · 1 line
2.12.2
#1 lore raw

PATCH 2/2 x264: Fix build for armv6 RaspberryPi boards

quant-a.S uses rbit thumb instruction unconditionally even though only from ARMV6T2 this is available (which is not the case for RPI1, RPI0 etc). Avoid this by disabling asm.

---
 recipes-multimedia/x264/x264_git.bbappend | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 recipes-multimedia/x264/x264_git.bbappend
recipes-multimedia/x264/x264_git.bbappend new file +1 -0
new file mode 100644
index 0000000..c1cb3bc
@@ -0,0 +1 @@
+EXTRA_OECONF_append_raspberrypi = " --disable-asm"
Signature · 1 line
2.12.2
#2 lore raw

Re: [meta-raspberrypi][PATCH 2/2] x264: Fix build for armv6 RaspberryPi boards

Quoted 3 lines · Andrei Gherzan

quant-a.S uses rbit thumb instruction unconditionally even though only from ARMV6T2 this is available (which is not the case for RPI1, RPI0 etc). Avoid this by disabling asm.

It would be bette to control it in component's own build system how much do we lose in performance if any do you know

Quoted 25 lines
---
 recipes-multimedia/x264/x264_git.bbappend | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 recipes-multimedia/x264/x264_git.bbappend
recipes-multimedia/x264/x264_git.bbappend new file +1 -1
new file mode 100644
index 0000000..c1cb3bc
@@ -0,0 +1 @@
+EXTRA_OECONF_append_raspberrypi = " --disable-asm"
--

2.12.2

--
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto

#3 lore raw

Re: [meta-raspberrypi][PATCH 2/2] x264: Fix build for armv6 RaspberryPi boards

Quoted 10 lines · Khem Raj
Quoted 3 lines · Andrei Gherzan

quant-a.S uses rbit thumb instruction unconditionally even though only from ARMV6T2 this is available (which is not the case for RPI1, RPI0 etc). Avoid this by disabling asm.

It would be bette to control it in component's own build system how much do we lose in performance if any do you know

I haven't tested myself but I know people who did and reported a 10% performance hit.

Now I see two more options - other than this one:
1. Deactivate in configure ASM if not HAVE_ARMV6T2 - don't see any fuctional difference
2. emulate rbit if not HAVE_ARMV6T2 - do you have any ideas on how to do this? I'd like this solution as rbit is the only instruction failing so we could take advantage of the other optimisations.

PS: in the meanwhile i merged it to unblock the builds.

--
Andrei Gherzan
gpg: rsa4096/D4D94F67AD0E9640 | t: @agherzan

#4 lore raw
In reply to Andrei Gherzan
Quoted 23 lines · Andrei Gherzan
---
 recipes-multimedia/omxplayer/omxplayer_git.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
recipes-multimedia/omxplayer/omxplayer_git.bb +2 -3
index 72297d0..0e0f9ba 100644
@@ -7,10 +7,10 @@ SECTION = "console/utils"
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
 
-DEPENDS = "libpcre libav virtual/egl boost freetype dbus openssl samba libssh libomxil coreutils-native"
+DEPENDS = "libpcre libav virtual/egl boost freetype dbus openssl samba libssh libomxil coreutils-native curl-native"
 PR = "r4"
 
-SRCREV = "62fb580260adb9b01e5694bb4374fb9a5f6f1021"
+SRCREV = "061425a5eabf6e9ee43229911c073a863d144038"
 SRC_URI = "git://github.com/popcornmix/omxplayer.git;protocol=git;branch=master \
            file://0001-Remove-Makefile.include-which-includes-hardcoded.patch \
            file://0002-Libraries-and-headers-from-ffmpeg-are-installed-in-u.patch \
--
Quoted 2 lines

2.12.2

Merged to master.

--
Andrei Gherzan
gpg: rsa4096/D4D94F67AD0E9640 | t: @agherzan