Skip to contentSkip to conversation

usb: gadget: remove redundant self assignment

PATCH In review Stefan Agner 3 participants 3 messages Apr 17, 2017 – Apr 19, 2017 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: gadget: remove redundant self assignment

The assignment ret = ret is redundant and can be removed.

---
A very similar patch has been applied already last year, but there is a second such assignment...

--
Stefan

 drivers/usb/gadget/udc/core.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/usb/gadget/udc/core.c +1 -3
index d685d82dcf48..b57bd53812fe 100644
@@ -139,10 +139,8 @@ int usb_ep_disable(struct usb_ep *ep)
 		goto out;
 
 	ret = ep->ops->disable(ep);
-	if (ret) {
-		ret = ret;
+	if (ret)
 		goto out;
-	}
 
 	ep->enabled = false;
 
Signature · 1 line
2.12.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 19 lines · Stefan Agner

The assignment ret = ret is redundant and can be removed.

---
A very similar patch has been applied already last year, but there is a second such assignment...

--
Stefan

 drivers/usb/gadget/udc/core.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/usb/gadget/udc/core.c +0 -0
index d685d82dcf48..b57bd53812fe 100644
@@ -139,10 +139,8 @@ int usb_ep_disable(struct usb_ep *ep)
 		goto out;

drivers/usb/gadget/udc/core.c int usb_ep_disable(struct usb_ep *ep) · line 146

Quoted 10 lines
drivers/usb/gadget/udc/core.c +1 -3
 
 	ret = ep->ops->disable(ep);
-	if (ret) {
-		ret = ret;
+	if (ret)
 		goto out;
-	}
 
 	ep->enabled = false;
 
Signature · 2 lines
Best Regards,
Peter Chen
Reviewed-by on v1 1/1
#2 lore raw
In reply to Stefan Agner
Quoted 20 lines · Stefan Agner

The assignment ret = ret is redundant and can be removed.

---
A very similar patch has been applied already last year, but there is a second such assignment...

--
Stefan

 drivers/usb/gadget/udc/core.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/usb/gadget/udc/core.c +0 -0
index d685d82dcf48..b57bd53812fe 100644
@@ -139,10 +139,8 @@ int usb_ep_disable(struct usb_ep *ep)
 		goto out;

drivers/usb/gadget/udc/core.c int usb_ep_disable(struct usb_ep *ep) · line 146

Quoted 10 lines
drivers/usb/gadget/udc/core.c +1 -3
 
 	ret = ep->ops->disable(ep);
-	if (ret) {
-		ret = ret;
+	if (ret)
 		goto out;
-	}
 
 	ep->enabled = false;
 
Signature · 3 lines
Krzysztof Opasiak
Samsung R&D Institute Poland
Samsung Electronics