usb: gadget: remove redundant self assignment
PATCH 1/1 usb: gadget: remove redundant self assignment
The assignment ret = ret is redundant and can be removed.
Signed-off-by Stefan Agner <[email protected]>
---
A very similar patch has been applied already last year, but there is a second such assignment...
--
Stefan
drivers/usb/gadget/udc/core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/usb/gadget/udc/core.c +1 -3
@@ -139,10 +139,8 @@ int usb_ep_disable(struct usb_ep *ep) goto out; ret = ep->ops->disable (ep); -if (ret) { - ret = ret; +if (ret) goto out; - } ep->enabled = false;
Signature · 1 line
2.12.2
Quoted 19 lines · Stefan Agner
The assignment ret = ret is redundant and can be removed.
Signed-off-by Stefan Agner <[email protected]>---
A very similar patch has been applied already last year, but there is a second such assignment...--
Stefandrivers/usb/gadget/udc/core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/usb/gadget/udc/core.c +0
-0@@ -139,10 +139,8 @@ int usb_ep_disable(struct usb_ep *ep) goto out;
drivers/usb/gadget/udc/core.c int usb_ep_disable(struct usb_ep *ep) · line 146
Quoted 10 lines
drivers/usb/gadget/udc/core.c +1
-3ret = ep->ops->disable (ep); -if (ret) { - ret = ret; +if (ret) goto out; - } ep->enabled = false;
Reviewed-by Peter Chen <[email protected]>
Signature · 2 lines
Best Regards, Peter Chen
Quoted 20 lines · Stefan Agner
The assignment ret = ret is redundant and can be removed.
Signed-off-by Stefan Agner <[email protected]>---
A very similar patch has been applied already last year, but there is a second such assignment...--
Stefandrivers/usb/gadget/udc/core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/usb/gadget/udc/core.c +0
-0@@ -139,10 +139,8 @@ int usb_ep_disable(struct usb_ep *ep) goto out;
drivers/usb/gadget/udc/core.c int usb_ep_disable(struct usb_ep *ep) · line 146
Quoted 10 lines
drivers/usb/gadget/udc/core.c +1
-3ret = ep->ops->disable (ep); -if (ret) { - ret = ret; +if (ret) goto out; - } ep->enabled = false;
Reviewed-by Krzysztof Opasiak <[email protected]>
Signature · 3 lines
Krzysztof Opasiak Samsung R&D Institute Poland Samsung Electronics