drivers/staging/vt6656/main_usb.c: usb_device_reset
cover drivers/staging/vt6656/main_usb.c: usb_device_reset
Hi,
This is a simple patch as a part of learning about kernel device driver in the Eudyptula challenge. thanks again for your time!
linsh
Chewie Lin (1):
drivers/staging/vt6656/main_usb.c: usb_device_reset
drivers/staging/vt6656/main_usb.c | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-)
Signature · 1 line
2.12.2
PATCH 1/1 drivers/staging/vt6656/main_usb.c: usb_device_reset
Removed the usb_device_reset(), replace with call to usb_reset_device() directly. Plus it removes the confusing function name and addressed the checkpatch warning as well by swap string in the dev_warn() call with __func__ argument, instead of explicitly calling the function name in the string:
WARNING: Prefer using "%s", __func__ to embedded function names #417: FILE: main_usb.c:417:
+ "usb_device_reset fail status=%d\n", status);
total: 0 errors, 1 warnings, 1058 lines checked
And after fix:
main_usb.c has no obvious style problems and is ready for submission.
--- drivers/staging/vt6656/main_usb.c | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-)
drivers/staging/vt6656/main_usb.c +4 -11
@@ -407,16 +407,6 @@ static void vnt_free_rx_bufs(struct vnt_private *priv) } } -static void usb_device_reset (struct vnt_private *priv) -{ -int status; - - status =usb_reset_device (priv->usb); -if (status) -dev_warn (&priv->usb->dev, -"usb_device_reset fail status=%d\n" , status); -} -static void vnt_free_int_bufs (struct vnt_private *priv) {kfree (priv->int_buf.data_buf);
@@ -995,7 +985,10 @@ vt6656_probe(struct usb_interface *intf, const struct usb_device_id *id)SET_IEEE80211_DEV (priv->hw, &intf->dev); -usb_device_reset (priv); + rc =usb_reset_device (priv->usb); +if (rc) +dev_warn (&priv->usb->dev, +"%s reset fail status=%d\n" , __func__, rc);clear_bit (DEVICE_FLAGS_DISCONNECTED , &priv->flags);vnt_reset_command_timer (priv);
Signature · 1 line
2.12.2
Quoted 10 lines · Chewie Lin
Removed the
usb_device_reset(), replace with call tousb_reset_device()directly. Plus it removes the confusing function name and addressed the checkpatch warning as well by swap string in thedev_warn()call with__func__argument, instead of explicitly calling the function name in the string:WARNING: Prefer using "%s",
__func__to embedded function names #417: FILE: main_usb.c:417:
+ "usb_device_resetfail status=%d\n", status);
Quoted 8 lines
total: 0 errors, 1 warnings, 1058 lines checked
And after fix:
main_usb.chas no obvious style problems and is ready for submission.Signed-off-by Chewie Lin <[email protected]>
Your subject line is odd, don't you think? Compare it to other patches for this driver and please fix it up and resend.
And there's never a need for a 0/X email for a single patch submission, no need to do that again.
thanks,
greg k-h
Quoted 18 lines · Greg KH
Quoted 17 lines · Chewie Lin
Removed the
usb_device_reset(), replace with call tousb_reset_device()directly. Plus it removes the confusing function name and addressed the checkpatch warning as well by swap string in thedev_warn()call with__func__argument, instead of explicitly calling the function name in the string:WARNING: Prefer using "%s",
__func__to embedded function names #417: FILE: main_usb.c:417:
+ "usb_device_resetfail status=%d\n", status);total: 0 errors, 1 warnings, 1058 lines checked
And after fix:
main_usb.chas no obvious style problems and is ready for submission.
Quoted 7 lines
Quoted 1 line
Signed-off-by Chewie Lin <[email protected]>Your subject line is odd, don't you think? Compare it to other patches for this driver and please fix it up and resend.
And there's never a need for a 0/X email for a single patch submission, no need to do that again.
And __func__ here is vt6656_probe not usb_reset_device.
usb_reset_device is the function that failed.