rockchip: enable debug uart

U-Boot Eddie Cai 2 participants 3 messages Apr 18, 2017 – Apr 20, 2017

Subsystems (3)

Arm (32-bit) Arm sub-architectures Arm Rockchip

lore

Share & tools

lore

Eddie Cai

author

2017-04-18 11:17 UTC #0 lore raw

enable debug uart for rk3288 and print something to let people know where we are

Signed-off-by Eddie Cai <[email protected]>

---
 arch/arm/mach-rockchip/rk3288-board-spl.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

arch/arm/mach-rockchip/rk3288-board-spl.c +2 -4

index 74f3379..8ca6b1e 100644
@@ -164,7 +164,6 @@ void board_init_f(ulong dummy)
 	int ret;
 
 	/* Example code showing how to enable the debug UART on RK3288 */
-#ifdef EARLY_UART
 #include <asm/arch/grf_rk3288.h>
 	/* Enable early UART on the RK3288 */
 #define GRF_BASE	0xff770000

@@ -183,8 +182,7 @@ void board_init_f(ulong dummy)
 	 * printascii("string");
 	 */
 	debug_uart_init();
-#endif
-
+	debug("\nspl:debug uart enabled in %s\n", __func__);
 	ret = spl_early_init();
 	if (ret) {
 		debug("spl_early_init() failed: %d\n", ret);

@@ -205,7 +203,7 @@ void board_init_f(ulong dummy)
 		debug("Pinctrl init failed: %d\n", ret);
 		return;
 	}
-
+	debug("\nspl:init dram\n");
 	ret = uclass_get_device(UCLASS_RAM, 0, &dev);
 	if (ret) {
 		debug("DRAM init failed: %d\n", ret);

Signature · 1 line

2.10.2

Simon Glass

Reviewed-by

2017-04-19 00:12 UTC #1 lore raw

Quoted 8 lines · Eddie Cai

enable debug uart for rk3288 and print something to let people know where we are
Signed-off-by Eddie Cai <[email protected]>
---
 arch/arm/mach-rockchip/rk3288-board-spl.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Reviewed-by Simon Glass <[email protected]>

Simon Glass

2017-04-20 21:06 UTC #2 lore raw

Quoted 11 lines · Simon Glass

Quoted 8 lines · Eddie Cai
enable debug uart for rk3288 and print something to let people know where we are
Signed-off-by Eddie Cai <[email protected]>
---
 arch/arm/mach-rockchip/rk3288-board-spl.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
Reviewed-by Simon Glass <[email protected]>

Applied to u-boot-rockchip/next, thanks!