esp6: Fix esp6_gso_segment()

PATCH In review Dan Carpenter 2 participants 2 messages Apr 18, 2017 – Apr 19, 2017

Subsystems (3)

Networking Kernel janitors Networking IPsec

lore

Share & tools

lore

Dan Carpenter

author

2017-04-18 19:51 UTC #0 lore raw

PATCH 1/1 esp6: Fix esp6_gso_segment()

This NULL test is inverted so the function become a no-op.

Fix: 7862b4058b9f10 ("esp: Add gso handlers for esp4 and esp6")

Signed-off-by Dan Carpenter <[email protected]>

---
This is still in Steffen's git tree and not yet in the networking tree.

net/ipv6/esp6_offload.c +1 -1

index 1cceeee7cc33..95f10728abaa 100644
@@ -120,7 +120,7 @@ static struct sk_buff *esp6_gso_segment(struct sk_buff *skb,
 	netdev_features_t esp_features = features;
 	struct xfrm_offload *xo = xfrm_offload(skb);
 
-	if (xo)
+	if (!xo)
 		goto out;
 
 	seq = xo->seq.low;

Steffen Klassert

maintainer

2017-04-19 05:24 UTC #1 lore raw

Quoted 6 lines · Dan Carpenter

This NULL test is inverted so the function become a no-op.
Fix: 7862b4058b9f10 ("esp: Add gso handlers for esp4 and esp6")
Signed-off-by Dan Carpenter <[email protected]>
---
This is still in Steffen's git tree and not yet in the networking tree.

Same patch was already sent to netdev, so I took that one.

Thanks anyway!