Skip to contentSkip to conversation

drivers: staging: lustre: lustre: llite: file.c - fixed sparse warning about different fmode_t type

PATCH In review Andrea della Porta 2 participants 2 messages Apr 27, 2017 – Apr 28, 2017 Staging

lore
Share & tools
lore

Andrea della Porta

author
#0 lore raw

PATCH 1/1 drivers: staging: lustre: lustre: llite: file.c - fixed sparse warning about different fmode_t type

fixed a couple of sparse warning complaining about type mismatch.

Signed-off-by Andrea della Porta <[email protected]>
---
 drivers/staging/lustre/lustre/include/lustre_intent.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/lustre/lustre/include/lustre_intent.h +1 -1
index ed2b6c6..c036633 100644
@@ -38,7 +38,7 @@
 struct lookup_intent {
 	int		it_op;
 	int		it_create_mode;
-	__u64		it_flags;
+	fmode_t		it_flags;
 	int		it_disposition;
 	int		it_status;
 	__u64		it_lock_handle;
Signature · 1 line
2.4.10
maintainer
#1 lore raw
Quoted 1 line · Andrea della Porta

fixed a couple of sparse warning complaining about type mismatch.

That's really vague, please be specific.

Quoted 11 lines
Signed-off-by Andrea della Porta <[email protected]>
---
 drivers/staging/lustre/lustre/include/lustre_intent.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/lustre/lustre/include/lustre_intent.h +0 -0
index ed2b6c6..c036633 100644

drivers/staging/lustre/lustre/include/lustre_intent.h line 41

Quoted 5 lines
drivers/staging/lustre/lustre/include/lustre_intent.h +1 -1
@@ -38,7 +38,7 @@
 struct lookup_intent {
 	int		it_op;
 	int		it_create_mode;
-	__u64		it_flags;
+	fmode_t		it_flags;

Are you sure? Why? What exact warning did this "fix"?

thanks,

greg k-h