phy: qcom-qmp: fix return value check in qcom_qmp_phy_create()
PATCH 1/1 phy: qcom-qmp: fix return value check in qcom_qmp_phy_create()
From: Wei Yongjun <[email protected]>
In case of error, the function of_iomap() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test.
Fixes e78f3d15e115 ("phy: qcom-qmp: new qmp phy driver for qcom-chipsets")
Signed-off-by Wei Yongjun <[email protected]>
--- drivers/phy/phy-qcom-qmp.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/phy/phy-qcom-qmp.c +6 -6
@@ -983,16 +983,16 @@ int qcom_qmp_phy_create(struct device *dev, struct device_node *np, int id)* Resources are indexed as: tx -> 0; rx -> 1; pcs -> 2. */ qphy->tx =of_iomap (np,0 ); -if (IS_ERR (qphy->tx)) -return PTR_ERR (qphy->tx); +if (!qphy->tx) +return -ENOMEM ; qphy->rx =of_iomap (np,1 ); -if (IS_ERR (qphy->rx)) -return PTR_ERR (qphy->rx); +if (!qphy->rx) +return -ENOMEM ; qphy->pcs =of_iomap (np,2 ); -if (IS_ERR (qphy->pcs)) -return PTR_ERR (qphy->pcs); +if (!qphy->pcs) +return -ENOMEM ;/* * Get PHY's Pipe clock, if any. USB3 and PCIe are PIPE3
Quoted 8 lines · Wei Yongjun
From: Wei Yongjun <[email protected]>
In case of error, the function
of_iomap()returns NULL pointer notERR_PTR(). TheIS_ERR()test in the return value check should be replaced with NULL test.Fixes e78f3d15e115 ("phy: qcom-qmp: new qmp phy driver for qcom-chipsets")Signed-off-by Wei Yongjun <[email protected]>
Reviewed-by Vivek Gautam <[email protected]>
Quoted 32 lines
--- drivers/phy/phy-qcom-qmp.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)drivers/phy/phy-qcom-qmp.c +6
-6@@ -983,16 +983,16 @@ int qcom_qmp_phy_create(struct device *dev, struct device_node *np, int id)* Resources are indexed as: tx -> 0; rx -> 1; pcs -> 2. */ qphy->tx =of_iomap (np,0 ); -if (IS_ERR (qphy->tx)) -return PTR_ERR (qphy->tx); +if (!qphy->tx) +return -ENOMEM ; qphy->rx =of_iomap (np,1 ); -if (IS_ERR (qphy->rx)) -return PTR_ERR (qphy->rx); +if (!qphy->rx) +return -ENOMEM ; qphy->pcs =of_iomap (np,2 ); -if (IS_ERR (qphy->pcs)) -return PTR_ERR (qphy->pcs); +if (!qphy->pcs) +return -ENOMEM ;/* * Get PHY's Pipe clock, if any. USB3 and PCIe are PIPE3
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
Kishon Vijay Abraham I
AppliedQuoted 5 lines · Vivek Gautam
Quoted 2 lines · Wei Yongjun
From: Wei Yongjun <[email protected]>
Quoted 8 lines
Quoted 6 lines
In case of error, the function
of_iomap()returns NULL pointer notERR_PTR(). TheIS_ERR()test in the return value check should be replaced with NULL test.Fixes e78f3d15e115 ("phy: qcom-qmp: new qmp phy driver for qcom-chipsets")Signed-off-by Wei Yongjun <[email protected]>Reviewed-by Vivek Gautam <[email protected]>
merged, thanks.
-Kishon
Quoted 32 lines
Quoted 31 lines
--- drivers/phy/phy-qcom-qmp.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)drivers/phy/phy-qcom-qmp.c +6
-6@@ -983,16 +983,16 @@ int qcom_qmp_phy_create(struct device *dev, structdevice_node *np, int id) * Resources are indexed as: tx -> 0; rx -> 1; pcs -> 2. */ qphy->tx =of_iomap (np,0 ); -if (IS_ERR (qphy->tx)) -return PTR_ERR (qphy->tx); +if (!qphy->tx) +return -ENOMEM ; qphy->rx =of_iomap (np,1 ); -if (IS_ERR (qphy->rx)) -return PTR_ERR (qphy->rx); +if (!qphy->rx) +return -ENOMEM ; qphy->pcs =of_iomap (np,2 ); -if (IS_ERR (qphy->pcs)) -return PTR_ERR (qphy->pcs); +if (!qphy->pcs) +return -ENOMEM ;/* * Get PHY's Pipe clock, if any. USB3 and PCIe are PIPE3