Skip to contentSkip to conversation

swtpm-wrappers: fix naming convention violation

PATCH In review Patrick Ohly 2 participants 2 messages Apr 25, 2017 – Apr 26, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 swtpm-wrappers: fix naming convention violation

Native recipes must be called <foo>-native. This is more than just a recommendation, there's actual code which checks for the suffix.

Not following that rule broke swtpm-wrappers when using the "usrmerge" DISTRO_FEATURE, because the code in native.bbclass which cleans up DISTRO_FEATURES for native recipes was skipped and thus swtpm-wrappers ended up using different paths than the other native recipes.

---
 recipes-tpm/swtpm/{swtpm-wrappers.bb => swtpm-wrappers-native.bb} | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename recipes-tpm/swtpm/{swtpm-wrappers.bb => swtpm-wrappers-native.bb} (100%)
recipes-tpm/swtpm/swtpm-wrappers-native.bb renamed from recipes-tpm/swtpm/swtpm-wrappers.bb +0 -0
similarity index 100%
rename from recipes-tpm/swtpm/swtpm-wrappers.bb
rename to recipes-tpm/swtpm/swtpm-wrappers-native.bb
Signature · 1 line
2.11.0
#1 lore raw
Quoted 9 lines · Patrick Ohly

Native recipes must be called <foo>-native. This is more than just a recommendation, there's actual code which checks for the suffix.

Not following that rule broke swtpm-wrappers when using the "usrmerge" DISTRO_FEATURE, because the code in native.bbclass which cleans up DISTRO_FEATURES for native recipes was skipped and thus swtpm-wrappers ended up using different paths than the other native recipes.

merged.

thanks,
Armin

Quoted 9 lines
---
  recipes-tpm/swtpm/{swtpm-wrappers.bb => swtpm-wrappers-native.bb} | 0
  1 file changed, 0 insertions(+), 0 deletions(-)

rename recipes-tpm/swtpm/{swtpm-wrappers.bb => swtpm-wrappers-native.bb} (100%)

recipes-tpm/swtpm/swtpm-wrappers-native.bb renamed from recipes-tpm/swtpm/swtpm-wrappers.bb +0 -0
similarity index 100%
rename from recipes-tpm/swtpm/swtpm-wrappers.bb
rename to recipes-tpm/swtpm/swtpm-wrappers-native.bb