Skip to contentSkip to conversation

typec: tcpm/tcpci drivers acceptable for drivers/staging in v4.12 ?

DISCUSSION Guenter Roeck 2 participants 5 messages Apr 25, 2017

lore
Share & tools
lore
#0 lore raw

Hi Greg,

would you be open to accepting the tcpm [1] and tcpci [2] drivers into drivers/staging for v4.12 ?

The drivers are not ready for prime time, yet there is interest by others to have them available and to help improving the code. I could create a repository/branch at github to enable that, but drivers/staging seems to be a better approach.

Thanks,
Guenter

---
[1] https://patchwork.kernel.org/patch/9693861/
[2] https://patchwork.kernel.org/patch/9693863/

#1 lore raw
Quoted 4 lines · Guenter Roeck

Hi Greg,

would you be open to accepting the tcpm [1] and tcpci [2] drivers into drivers/staging for v4.12 ?

What's the rush?

Quoted 4 lines

The drivers are not ready for prime time, yet there is interest by others to have them available and to help improving the code. I could create a repository/branch at github to enable that, but drivers/staging seems to be a better approach.

Sure, if you want to maintain it in the kernel, and send me patches that way for changes, I'll be glad to take them into staging, just send me a patch that adds them to the tree and I'll merge them for 4.12-rc1.

thanks,

greg k-h

#2 lore raw
Quoted 8 lines · Greg Kroah-Hartman
Quoted 4 lines · Guenter Roeck

Hi Greg,

would you be open to accepting the tcpm [1] and tcpci [2] drivers into drivers/staging for v4.12 ?

What's the rush?

It has been a long time, and it avoids duplicate work and submissions, including for drivers depending on it, such as the fusb302 driver submitted by Hans de Goede [1] for which we have a (not yet published) driver based on tcpm as well. If for nothing else, it widens the audience.

Quoted 9 lines
Quoted 4 lines

The drivers are not ready for prime time, yet there is interest by others to have them available and to help improving the code. I could create a repository/branch at github to enable that, but drivers/staging seems to be a better approach.

Sure, if you want to maintain it in the kernel, and send me patches that way for changes, I'll be glad to take them into staging, just send me a patch that adds them to the tree and I'll merge them for 4.12-rc1.

Ok, will do.

Thanks,
Guenter

---
[1] https://lkml.org/lkml/2017/4/21/312

#3 lore raw
Quoted 7 lines · Guenter Roeck
Quoted 6 lines · Greg Kroah-Hartman
Quoted 4 lines · Guenter Roeck

Hi Greg,

would you be open to accepting the tcpm [1] and tcpci [2] drivers into drivers/staging for v4.12 ?

Quoted 7 lines
Quoted 2 lines

What's the rush?

It has been a long time, and it avoids duplicate work and submissions, including for drivers depending on it, such as the fusb302 driver submitted by Hans de Goede [1] for which we have a (not yet published) driver based on tcpm as well. If for nothing else, it widens the audience.

Ok, fair enough, send away!

And getting a sane fusb302 driver would be great. The ones I have seen are just so bad...

greg k-h

#4 lore raw
Quoted 16 lines · Greg Kroah-Hartman
Quoted 7 lines · Guenter Roeck
Quoted 6 lines · Greg Kroah-Hartman
Quoted 4 lines · Guenter Roeck

Hi Greg,

would you be open to accepting the tcpm [1] and tcpci [2] drivers into drivers/staging for v4.12 ?

Quoted 7 lines
Quoted 2 lines

What's the rush?

It has been a long time, and it avoids duplicate work and submissions, including for drivers depending on it, such as the fusb302 driver submitted by Hans de Goede [1] for which we have a (not yet published) driver based on tcpm as well. If for nothing else, it widens the audience.

Quoted 5 lines

Ok, fair enough, send away!

And getting a sane fusb302 driver would be great. The ones I have seen are just so bad...

It should hopefully be less insane :-). Looking forward to get your feedback. We are still trying to figure out if there is anything we have to watch out for before we can make it available; it is currently sitting in a private Android branch and we don't want to get into trouble. Most likely we are just over-cautious. Should hopefully be a matter of days.

Thanks,
Guenter