Skip to contentSkip to conversation

drm/i915/glk: Fix DSI "*ERROR* ULPS is still active" messages

PATCH In review Ander Conselvan de Oliveira 4 participants 6 messages Apr 28, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/glk: Fix DSI "*ERROR* ULPS is still active" messages

The sequence in glk_dsi_device_ready() enters ULPS then waits until it is *not* active to then disable it. The correct sequence according to the spec is to enter ULPS then wait until the GLK_ULPS_NOT_ACTIVE bit is zero, i.e., ULPS is active, and then disable ULPS.

Fixing the codition gets rid of the following spurious error messages:

[drm:glk_dsi_device_ready [i915]] *ERROR* ULPS is still active

Fixes 4644848369c0 ("drm/i915/glk: Add MIPIIO Enable/disable sequence")
Cc Deepak M <[email protected]>
Cc Madhav Chauhan <[email protected]>
Cc Jani Nikula <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Jani Nikula <[email protected]>
---
 drivers/gpu/drm/i915/intel_dsi.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/intel_dsi.c +3 -4
index 3ffe8b1..fc0ef49 100644
@@ -410,11 +410,10 @@ static void glk_dsi_device_ready(struct intel_encoder *encoder)
 		val |= (ULPS_STATE_ENTER | DEVICE_READY);
 		I915_WRITE(MIPI_DEVICE_READY(port), val);
 
-		/* Wait for ULPS Not active */
+		/* Wait for ULPS active */
 		if (intel_wait_for_register(dev_priv,
-				MIPI_CTRL(port), GLK_ULPS_NOT_ACTIVE,
-				GLK_ULPS_NOT_ACTIVE, 20))
-			DRM_ERROR("ULPS is still active\n");
+				MIPI_CTRL(port), GLK_ULPS_NOT_ACTIVE, 0, 20))
+			DRM_ERROR("ULPS not active\n");
 
 		/* Exit ULPS */
 		val = I915_READ(MIPI_DEVICE_READY(port));
Signature · 6 lines
2.9.3

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw
Quoted 12 lines

-----Original Message-----
From: Conselvan De Oliveira, Ander
Sent: Friday, April 28, 2017 1:32 PM
To: [email protected]
Cc: Conselvan De Oliveira, Ander <[email protected]>; Deepak M <[email protected]>; Chauhan, Madhav <[email protected]>; Nikula, Jani <[email protected]>; Vetter, Daniel <[email protected]>; Jani Nikula <[email protected]>; [email protected]
Subject: [PATCH] drm/i915/glk: Fix DSI "*ERROR* ULPS is still active" messages

Quoted 6 lines

The sequence in glk_dsi_device_ready() enters ULPS then waits until it is *not* active to then disable it. The correct sequence according to the spec is to enter ULPS then wait until the GLK_ULPS_NOT_ACTIVE bit is zero, i.e., ULPS is active, and then disable ULPS.

Fixing the codition gets rid of the following spurious error messages:

Please correct the typo error to "condition", otherwise looks good. Thanks for catching this.

Quoted 40 lines

[drm:glk_dsi_device_ready [i915]] *ERROR* ULPS is still active

Fixes 4644848369c0 ("drm/i915/glk: Add MIPIIO Enable/disable sequence")
Cc Deepak M <[email protected]>
Cc Madhav Chauhan <[email protected]>
Cc Jani Nikula <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Jani Nikula <[email protected]>
Signed-off-by Ander Conselvan de Oliveira

<[email protected]>

---
 drivers/gpu/drm/i915/intel_dsi.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/intel_dsi.c +3 -4
index 3ffe8b1..fc0ef49 100644
@@ -410,11 +410,10 @@ static void glk_dsi_device_ready(struct
 intel_encoder *encoder)
 		val |= (ULPS_STATE_ENTER | DEVICE_READY);
 		I915_WRITE(MIPI_DEVICE_READY(port), val);
 
-		/* Wait for ULPS Not active */
+		/* Wait for ULPS active */
 		if (intel_wait_for_register(dev_priv,
-				MIPI_CTRL(port), GLK_ULPS_NOT_ACTIVE,
-				GLK_ULPS_NOT_ACTIVE, 20))
-			DRM_ERROR("ULPS is still active\n");
+				MIPI_CTRL(port), GLK_ULPS_NOT_ACTIVE, 0,
 20))
+			DRM_ERROR("ULPS not active\n");
 
drivers/gpu/drm/i915/intel_dsi.c +0 -1
 		/* Exit ULPS */
 		val = I915_READ(MIPI_DEVICE_READY(port));
--
Quoted 1 line

2.9.3

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw
Quoted 17 lines · Madhav
Quoted 17 lines

-----Original Message-----
From: Conselvan De Oliveira, Ander
Sent: Friday, April 28, 2017 1:32 PM
To: [email protected]
Cc: Conselvan De Oliveira, Ander <[email protected]>; Deepak M <[email protected]>; Chauhan, Madhav <[email protected]>; Nikula, Jani <[email protected]>; Vetter, Daniel <[email protected]>; Jani Nikula <[email protected]>; [email protected]
Subject: [PATCH] drm/i915/glk: Fix DSI "*ERROR* ULPS is still active" messages

The sequence in glk_dsi_device_ready() enters ULPS then waits until it is *not* active to then disable it. The correct sequence according to the spec is to enter ULPS then wait until the GLK_ULPS_NOT_ACTIVE bit is zero, i.e., ULPS is active, and then disable ULPS.

Quoted 4 lines
Quoted 1 line

Fixing the codition gets rid of the following spurious error messages:

Please correct the typo error to "condition", otherwise looks good. Thanks for catching this.

If you upgrade the above statement to a Reviewed-by, I can fix the typo while merging?

Ander

Quoted 38 lines
Quoted 38 lines

[drm:glk_dsi_device_ready [i915]] *ERROR* ULPS is still active

Fixes 4644848369c0 ("drm/i915/glk: Add MIPIIO Enable/disable sequence")
Cc Deepak M <[email protected]>
Cc Madhav Chauhan <[email protected]>
Cc Jani Nikula <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Jani Nikula <[email protected]>
Signed-off-by Ander Conselvan de Oliveira

<[email protected]>

---
 drivers/gpu/drm/i915/intel_dsi.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/intel_dsi.c +3 -4
index 3ffe8b1..fc0ef49 100644
@@ -410,11 +410,10 @@ static void glk_dsi_device_ready(struct
 intel_encoder *encoder)
 		val |= (ULPS_STATE_ENTER | DEVICE_READY);
 		I915_WRITE(MIPI_DEVICE_READY(port), val);
 
-		/* Wait for ULPS Not active */
+		/* Wait for ULPS active */
 		if (intel_wait_for_register(dev_priv,
-				MIPI_CTRL(port), GLK_ULPS_NOT_ACTIVE,
-				GLK_ULPS_NOT_ACTIVE, 20))
-			DRM_ERROR("ULPS is still active\n");
+				MIPI_CTRL(port), GLK_ULPS_NOT_ACTIVE, 0,
 20))
+			DRM_ERROR("ULPS not active\n");
 
Quoted 6 lines
Quoted 4 lines
drivers/gpu/drm/i915/intel_dsi.c +0 -1
 		/* Exit ULPS */
 		val = I915_READ(MIPI_DEVICE_READY(port));
--

2.9.3

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by
#3 lore raw
Quoted 33 lines

-----Original Message-----
From: Ander Conselvan De Oliveira [mailto:[email protected]]
Sent: Friday, April 28, 2017 2:28 PM
To: Chauhan, Madhav <[email protected]>; intel- [email protected]
Cc: Deepak M <[email protected]>; Nikula, Jani <[email protected]>; Vetter, Daniel <[email protected]>; Jani Nikula <[email protected]>; [email protected]
Subject: Re: [PATCH] drm/i915/glk: Fix DSI "*ERROR* ULPS is still active" messages

Quoted 21 lines · Madhav
Quoted 20 lines

-----Original Message-----
From: Conselvan De Oliveira, Ander
Sent: Friday, April 28, 2017 1:32 PM
To: [email protected]
Cc: Conselvan De Oliveira, Ander <[email protected]>;
Deepak M <[email protected]>; Chauhan, Madhav <[email protected]>; Nikula, Jani <[email protected]>; Vetter, Daniel <[email protected]>; Jani Nikula <[email protected]>; [email protected]
Subject: [PATCH] drm/i915/glk: Fix DSI "*ERROR* ULPS is still active" messages

The sequence in glk_dsi_device_ready() enters ULPS then waits until it is
*not* active to then disable it. The correct sequence according to the spec is to enter ULPS then wait until the GLK_ULPS_NOT_ACTIVE bit is zero, i.e., ULPS is active, and then disable ULPS.

Fixing the codition gets rid of the following spurious error messages:

Quoted 23 lines
Quoted 2 lines

Please correct the typo error to "condition", otherwise looks good. Thanks for catching this.

If you upgrade the above statement to a Reviewed-by, I can fix the typo while merging?

Ander

Quoted 15 lines
Quoted 15 lines

[drm:glk_dsi_device_ready [i915]] *ERROR* ULPS is still active

Fixes 4644848369c0 ("drm/i915/glk: Add MIPIIO Enable/disable

sequence")
Cc: Deepak M <[email protected]>
Cc: Madhav Chauhan <[email protected]>
Cc: Jani Nikula <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: Jani Nikula <[email protected]>
Cc: [email protected]
Cc: <[email protected]>
Signed-off-by: Ander Conselvan de Oliveira
<[email protected]>

Quoted 24 lines
Quoted 24 lines
Quoted 24 lines
---
 drivers/gpu/drm/i915/intel_dsi.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/intel_dsi.c +3 -4
index 3ffe8b1..fc0ef49 100644
@@ -410,11 +410,10 @@ static void glk_dsi_device_ready(struct
 intel_encoder *encoder)
 		val |= (ULPS_STATE_ENTER | DEVICE_READY);
 		I915_WRITE(MIPI_DEVICE_READY(port), val);
 
-		/* Wait for ULPS Not active */
+		/* Wait for ULPS active */
 		if (intel_wait_for_register(dev_priv,
-				MIPI_CTRL(port), GLK_ULPS_NOT_ACTIVE,
-				GLK_ULPS_NOT_ACTIVE, 20))
-			DRM_ERROR("ULPS is still active\n");
+				MIPI_CTRL(port), GLK_ULPS_NOT_ACTIVE, 0,
 20))
+			DRM_ERROR("ULPS not active\n");
 
Quoted 6 lines
Quoted 6 lines
Quoted 4 lines
drivers/gpu/drm/i915/intel_dsi.c +0 -1
 		/* Exit ULPS */
 		val = I915_READ(MIPI_DEVICE_READY(port));
--

2.9.3

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw
Quoted 57 lines · Madhav
Quoted 33 lines

-----Original Message-----
From: Ander Conselvan De Oliveira [mailto:[email protected]]
Sent: Friday, April 28, 2017 2:28 PM
To: Chauhan, Madhav <[email protected]>; intel- [email protected]
Cc: Deepak M <[email protected]>; Nikula, Jani <[email protected]>; Vetter, Daniel <[email protected]>; Jani Nikula <[email protected]>; [email protected]
Subject: Re: [PATCH] drm/i915/glk: Fix DSI "*ERROR* ULPS is still active" messages

Quoted 21 lines · Madhav
Quoted 20 lines

-----Original Message-----
From: Conselvan De Oliveira, Ander
Sent: Friday, April 28, 2017 1:32 PM
To: [email protected]
Cc: Conselvan De Oliveira, Ander <[email protected]>;
Deepak M <[email protected]>; Chauhan, Madhav <[email protected]>; Nikula, Jani <[email protected]>; Vetter, Daniel <[email protected]>; Jani Nikula <[email protected]>; [email protected]
Subject: [PATCH] drm/i915/glk: Fix DSI "*ERROR* ULPS is still active" messages

The sequence in glk_dsi_device_ready() enters ULPS then waits until it is
*not* active to then disable it. The correct sequence according to the spec is to enter ULPS then wait until the GLK_ULPS_NOT_ACTIVE bit is zero, i.e., ULPS is active, and then disable ULPS.

Fixing the codition gets rid of the following spurious error messages:

Quoted 23 lines
Quoted 2 lines

Please correct the typo error to "condition", otherwise looks good. Thanks for catching this.

If you upgrade the above statement to a Reviewed-by, I can fix the typo while merging?

Ander

Quoted 15 lines
Quoted 15 lines

[drm:glk_dsi_device_ready [i915]] *ERROR* ULPS is still active

Fixes 4644848369c0 ("drm/i915/glk: Add MIPIIO Enable/disable

sequence")
Cc: Deepak M <[email protected]>
Cc: Madhav Chauhan <[email protected]>
Cc: Jani Nikula <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: Jani Nikula <[email protected]>
Cc: [email protected]
Cc: <[email protected]>
Signed-off-by: Ander Conselvan de Oliveira
<[email protected]>

Quoted 1 line

Pushed with the typo fixed. Thanks for reviewing.

Ander

Quoted 26 lines
Quoted 26 lines
Quoted 26 lines
Quoted 26 lines

---
 drivers/gpu/drm/i915/intel_dsi.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/intel_dsi.c +3 -4
index 3ffe8b1..fc0ef49 100644
@@ -410,11 +410,10 @@ static void glk_dsi_device_ready(struct
 intel_encoder *encoder)
 		val |= (ULPS_STATE_ENTER | DEVICE_READY);
 		I915_WRITE(MIPI_DEVICE_READY(port), val);
 
-		/* Wait for ULPS Not active */
+		/* Wait for ULPS active */
 		if (intel_wait_for_register(dev_priv,
-				MIPI_CTRL(port), GLK_ULPS_NOT_ACTIVE,
-				GLK_ULPS_NOT_ACTIVE, 20))
-			DRM_ERROR("ULPS is still active\n");
+				MIPI_CTRL(port), GLK_ULPS_NOT_ACTIVE, 0,
 20))
+			DRM_ERROR("ULPS not active\n");
 
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 4 lines
drivers/gpu/drm/i915/intel_dsi.c +0 -1
 		/* Exit ULPS */
 		val = I915_READ(MIPI_DEVICE_READY(port));
--

2.9.3

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw

✓ Fi.CI.BAT: success for drm/i915/glk: Fix DSI "*ERROR* ULPS is still active" messages

In reply to Ander Conselvan de Oliveira
== Series Details ==

== Series Details ==

Series: drm/i915/glk: Fix DSI "*ERROR* ULPS is still active" messages
URL : https://patchwork.freedesktop.org/series/23680/
State : success

== Summary ==

Series 23680v1 drm/i915/glk: Fix DSI "*ERROR* ULPS is still active" messages
https://patchwork.freedesktop.org/api/1.0/series/23680/revisions/1/mbox/

Test gem_exec_suspend:

        Subgroup basic-s4-devices:
                dmesg-warn -> PASS       (fi-kbl-7560u) fdo#100125
Test kms_flip:
        Subgroup basic-flip-vs-dpms:
                pass       -> DMESG-WARN (fi-byt-j1900) fdo#100652

fdo#100125 https://bugs.freedesktop.org/show_bug.cgi?id=100125
fdo#100652 https://bugs.freedesktop.org/show_bug.cgi?id=100652

fi-bdw-5557u     total:278  pass:267  dwarn:0   dfail:0   fail:0   skip:11  time:427s
fi-bdw-gvtdvm    total:278  pass:256  dwarn:8   dfail:0   fail:0   skip:14  time:429s
fi-bsw-n3050     total:278  pass:242  dwarn:0   dfail:0   fail:0   skip:36  time:579s
fi-bxt-j4205     total:278  pass:259  dwarn:0   dfail:0   fail:0   skip:19  time:509s
fi-bxt-t5700     total:278  pass:258  dwarn:0   dfail:0   fail:0   skip:20  time:542s
fi-byt-j1900     total:278  pass:253  dwarn:1   dfail:0   fail:0   skip:24  time:484s
fi-byt-n2820     total:278  pass:250  dwarn:0   dfail:0   fail:0   skip:28  time:478s
fi-hsw-4770      total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16  time:406s
fi-hsw-4770r     total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16  time:402s
fi-ilk-650       total:278  pass:228  dwarn:0   dfail:0   fail:0   skip:50  time:416s
fi-ivb-3520m     total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time:486s
fi-ivb-3770      total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time:471s
fi-kbl-7500u     total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time:456s
fi-kbl-7560u     total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10  time:563s
fi-skl-6260u     total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10  time:455s
fi-skl-6700hq    total:278  pass:261  dwarn:0   dfail:0   fail:0   skip:17  time:569s
fi-skl-6700k     total:278  pass:256  dwarn:4   dfail:0   fail:0   skip:18  time:456s
fi-skl-6770hq    total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10  time:493s
fi-skl-gvtdvm    total:278  pass:265  dwarn:0   dfail:0   fail:0   skip:13  time:429s
fi-snb-2520m     total:278  pass:250  dwarn:0   dfail:0   fail:0   skip:28  time:532s
fi-snb-2600      total:278  pass:249  dwarn:0   dfail:0   fail:0   skip:29  time:400s

86cc4197d2fa4c45b75bf54026765d27d86b84c8 drm-tip: 2017y-04m-28d-09h-14m-47s UTC integration manifest b7f9ab5 drm/i915/glk: Fix DSI "*ERROR* ULPS is still active" messages

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4575/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx