Skip to contentSkip to conversation

kvm-xfstests: unmount /results before shutting down

PATCH Applied Eric Biggers 2 participants 2 messages May 1, 2017 – May 2, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kvm-xfstests: unmount /results before shutting down

From: Eric Biggers <[email protected]>

kvm-xfstests shuts down the VM with 'poweroff -f', which with old versions of systemd's 'poweroff' command (including the version included in Debian Jessie) does not call sync(). This could cause data written to the /results filesystem to be lost. Work around this by unmounting /results before shutting down.

---
 kvm-xfstests/test-appliance/files/root/kvm-xfstests.boot | 1 +
 1 file changed, 1 insertion(+)
kvm-xfstests/test-appliance/files/root/kvm-xfstests.boot +1 -0
index 2eb3a2b..cd01ffd 100755
@@ -92,6 +92,7 @@ then
 	/bin/rm -f /run/gce-finalize-wait
     else
 	/root/runtests.sh
+	umount /results
 	poweroff -f > /dev/null 2>&1
     fi
 else
Signature · 1 line
2.13.0.rc0.306.g87b477812d-goog
#1 lore raw
Quoted 9 lines · Eric Biggers

From: Eric Biggers <[email protected]>

kvm-xfstests shuts down the VM with 'poweroff -f', which with old versions of systemd's 'poweroff' command (including the version included in Debian Jessie) does not call sync(). This could cause data written to the /results filesystem to be lost. Work around this by unmounting /results before shutting down.

Thanks, applied.

- Ted