Skip to contentSkip to conversation

target: remove dead code

PATCH Applied Gustavo A. R. Silva 3 participants 3 messages May 9, 2017 – May 24, 2017

Subsystems (2)
SCSI SCSI target
lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 target: remove dead code

Local variable _ret_ is assigned to a constant value and it is never updated again. Remove this variable and the dead code it guards.

Addresses-Coverity-ID: 140761

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/target/target_core_rd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/target/target_core_rd.c +2 -2
index ddc216c..6e8ef23 100644
@@ -568,7 +568,7 @@ static ssize_t rd_set_configfs_dev_params(struct se_device *dev,
 	struct rd_dev *rd_dev = RD_DEV(dev);
 	char *orig, *ptr, *opts;
 	substring_t args[MAX_OPT_ARGS];
-	int ret = 0, arg, token;
+	int arg, token;
 
 	opts = kstrdup(page, GFP_KERNEL);
 	if (!opts)

@@ -603,7 +603,7 @@ static ssize_t rd_set_configfs_dev_params(struct se_device *dev,
 	}
 
 	kfree(orig);
-	return (!ret) ? count : ret;
+	return count;
 }
 
 static ssize_t rd_show_configfs_dev_params(struct se_device *dev, char *b)
Signature · 1 line
2.5.0