Skip to contentSkip to conversation

Don't enable DRI3 without glamor

PATCH In review Michel Dänzer 2 participants 2 messages May 10, 2017 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Don't enable DRI3 without glamor

From: Michel Dänzer <[email protected]>

Can't work currently. Fixes crash when trying to run a DRI3 client when glamor isn't enabled.

Bugzilla: https://bugs.freedesktop.org/100968

---
 src/amdgpu_kms.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
src/amdgpu_kms.c +4 -1
index 0182cbe0a..4df81f993 100644
@@ -1741,7 +1741,10 @@ Bool AMDGPUScreenInit_KMS(SCREEN_INIT_ARGS_DECL)
 #endif
 
 	if (!amdgpu_is_gpu_screen(pScreen)) {
-		value = xorgGetVersion() >= XORG_VERSION_NUMERIC(1,18,3,0,0);
+		if (xorgGetVersion() >= XORG_VERSION_NUMERIC(1,18,3,0,0))
+			value = info->use_glamor;
+		else
+			value = FALSE;
 		from = X_DEFAULT;
 
 		if (info->use_glamor) {
Signature · 6 lines
2.11.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 20170510094838.7952-1-michel-otUistvHUpPR7s880joybQ@public.gmane.org

Reviewed-by Alex Deucher
#2 lore raw
Quoted 7 lines

-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Michel Dänzer
Sent: Wednesday, May 10, 2017 5:49 AM
To: [email protected]
Subject: [PATCH xf86-video-amdgpu] Don't enable DRI3 without glamor

Quoted 7 lines

From: Michel Dänzer <[email protected]>

Can't work currently. Fixes crash when trying to run a DRI3 client when glamor isn't enabled.

Bugzilla: https://bugs.freedesktop.org/100968

Quoted 26 lines
---
 src/amdgpu_kms.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
src/amdgpu_kms.c +4 -1
index 0182cbe0a..4df81f993 100644
@@ -1741,7 +1741,10 @@ Bool
 AMDGPUScreenInit_KMS(SCREEN_INIT_ARGS_DECL)
 #endif
 
 	if (!amdgpu_is_gpu_screen(pScreen)) {
-		value = xorgGetVersion() >=
 XORG_VERSION_NUMERIC(1,18,3,0,0);
+		if (xorgGetVersion() >=
 XORG_VERSION_NUMERIC(1,18,3,0,0))
+			value = info->use_glamor;
+		else
+			value = FALSE;
src/amdgpu_kms.c +0 -1
 		from = X_DEFAULT;
 
 		if (info->use_glamor) {
--

2.11.0

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx