Skip to contentSkip to conversation

net: can: peak: fix product-id endianness in error message

PATCH New Johan Hovold 1 participant 1 message May 12, 2017

Subsystems (3)
Networking Network drivers CAN network drivers
lore
Share & tools
lore

Johan Hovold

author
#0 lore raw

PATCH 1/1 net: can: peak: fix product-id endianness in error message

Make sure to use the USB device product-id stored in host-byte order in a probe error message.

Also remove a redundant reassignment of the local usb_dev variable which had already been used to retrieve the product id.

Signed-off-by Johan Hovold <[email protected]>
---
 drivers/net/can/usb/peak_usb/pcan_usb_core.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/net/can/usb/peak_usb/pcan_usb_core.c +1 -3
index 57913dbbae0a..1ca76e03e965 100644
@@ -908,8 +908,6 @@ static int peak_usb_probe(struct usb_interface *intf,
 	const struct peak_usb_adapter *peak_usb_adapter = NULL;
 	int i, err = -ENOMEM;
 
-	usb_dev = interface_to_usbdev(intf);
-
 	/* get corresponding PCAN-USB adapter */
 	for (i = 0; i < ARRAY_SIZE(peak_usb_adapters_list); i++)
 		if (peak_usb_adapters_list[i]->device_id == usb_id_product) {

@@ -920,7 +918,7 @@ static int peak_usb_probe(struct usb_interface *intf,
 	if (!peak_usb_adapter) {
 		/* should never come except device_id bad usage in this file */
 		pr_err("%s: didn't find device id. 0x%x in devices list\n",
-			PCAN_USB_DRIVER_NAME, usb_dev->descriptor.idProduct);
+			PCAN_USB_DRIVER_NAME, usb_id_product);
 		return -ENODEV;
 	}
Signature · 1 line
2.13.0