Skip to contentSkip to conversation

staging: fsl-dpaa2/eth: add ETHERNET dependency

PATCH In review Arnd Bergmann 2 participants 2 messages May 16, 2017 – May 17, 2017 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: fsl-dpaa2/eth: add ETHERNET dependency

The new driver cannot link correctly when the netdevice infrastructure is disabled:

ERROR: "netdev_info" [drivers/staging/fsl-dpaa2/ethernet/fsl-dpaa2-eth.ko] undefined!
ERROR: "skb_to_sgvec" [drivers/staging/fsl-dpaa2/ethernet/fsl-dpaa2-eth.ko] undefined!
ERROR: "napi_disable" [drivers/staging/fsl-dpaa2/ethernet/fsl-dpaa2-eth.ko] undefined!
ERROR: "napi_schedule_prep" [drivers/staging/fsl-dpaa2/ethernet/fsl-dpaa2-eth.ko] undefined!
ERROR: "__napi_schedule_irqoff" [drivers/staging/fsl-dpaa2/ethernet/fsl-dpaa2-eth.ko] undefined!
ERROR: "netif_carrier_on" [drivers/staging/fsl-dpaa2/ethernet/fsl-dpaa2-eth.ko] undefined!

This adds a dependency on NETDEVICES and ETHERNET.

Fixes 0352d1d85201 ("staging: fsl-dpaa2/eth: Add APIs for DPNI objects")
---
 drivers/staging/fsl-dpaa2/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/fsl-dpaa2/Kconfig +1 -0
index 2e325cb747ae..730fd6d4db33 100644
@@ -12,6 +12,7 @@ config FSL_DPAA2
 config FSL_DPAA2_ETH
 	tristate "Freescale DPAA2 Ethernet"
 	depends on FSL_DPAA2 && FSL_MC_DPIO
+	depends on NETDEVICES && ETHERNET
 	---help---
 	  Ethernet driver for Freescale DPAA2 SoCs, using the
 	  Freescale MC bus driver
Signature · 1 line
2.9.0
Acked-by on v1 1/1
#1 lore raw
Quoted 47 lines

-----Original Message-----
From: Arnd Bergmann [mailto:[email protected]]
Sent: Tuesday, May 16, 2017 2:30 PM
To: Greg Kroah-Hartman <[email protected]>; Arnd Bergmann <[email protected]>
Cc: Ruxandra Ioana Radulescu <[email protected]>; [email protected]; [email protected]
Subject: [PATCH] staging: fsl-dpaa2/eth: add ETHERNET dependency

The new driver cannot link correctly when the netdevice infrastructure is disabled:

ERROR: "netdev_info" [drivers/staging/fsl-dpaa2/ethernet/fsl-dpaa2-eth.ko] undefined!
ERROR: "skb_to_sgvec" [drivers/staging/fsl-dpaa2/ethernet/fsl-dpaa2- eth.ko] undefined!
ERROR: "napi_disable" [drivers/staging/fsl-dpaa2/ethernet/fsl-dpaa2- eth.ko] undefined!
ERROR: "napi_schedule_prep" [drivers/staging/fsl-dpaa2/ethernet/fsl- dpaa2-eth.ko] undefined!
ERROR: "__napi_schedule_irqoff" [drivers/staging/fsl-dpaa2/ethernet/fsl- dpaa2-eth.ko] undefined!
ERROR: "netif_carrier_on" [drivers/staging/fsl-dpaa2/ethernet/fsl-dpaa2- eth.ko] undefined!

This adds a dependency on NETDEVICES and ETHERNET.

Fixes 0352d1d85201 ("staging: fsl-dpaa2/eth: Add APIs for DPNI objects")
---
 drivers/staging/fsl-dpaa2/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/fsl- renamed from drivers/staging/fsl-dpaa2/Kconfig +0 -0

dpaa2/Kconfig
index 2e325cb747ae..730fd6d4db33 100644

drivers/staging/fsl-dpaa2/Kconfig +1 -1
@@ -12,6 +12,7 @@ config FSL_DPAA2
 config FSL_DPAA2_ETH
 	tristate "Freescale DPAA2 Ethernet"
 	depends on FSL_DPAA2 && FSL_MC_DPIO
+	depends on NETDEVICES && ETHERNET
 	---help---
 	  Ethernet driver for Freescale DPAA2 SoCs, using the
 	  Freescale MC bus driver
--
Quoted 1 line

2.9.0

Thanks!