Skip to contentSkip to conversation

rrdtool: add gettext-native dependency

PATCH In review Randy MacLeod 2 participants 3 messages May 17, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rrdtool: add gettext-native dependency

Add gettext-native dependency to use autopoint.

When building rrdtool for a 'tiny' distro, ie one that does not have internationalization support in glibc, configure fails with the error:
autoreconf: failed to run autopoint: No such file or directory
autopoint is part of gettext so add that native dependency. This must happen transitively for builds using a regular configuration of glibc.

---
 meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb +1 -1
index db2df28a0..160dea58d 100644
@@ -4,7 +4,7 @@ HOMEPAGE = "http://oss.oetiker.ch/rrdtool/"
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYRIGHT;md5=3349111ed0533471494beec99715bc9d"
 
-DEPENDS = "libpng zlib cairo pango glib-2.0 libxml2 groff-native"
+DEPENDS = "libpng zlib cairo pango glib-2.0 libxml2 groff-native gettext-native"
 
 SRCREV = "61f116744262c4c18922dcf806e496715f199669"
 PV = "1.6.0"
Signature · 1 line
2.11.0
#1 lore raw
Quoted 20 lines · Randy MacLeod

Add gettext-native dependency to use autopoint.

When building rrdtool for a 'tiny' distro, ie one that does not have internationalization support in glibc, configure fails with the error:
autoreconf: failed to run autopoint: No such file or directory
autopoint is part of gettext so add that native dependency. This must happen transitively for builds using a regular configuration of glibc.

---
 meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb +0 -0
index db2df28a0..160dea58d 100644

meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb HOMEPAGE = "http://oss.oetiker.ch/rrdtool/" · line 7

Quoted 5 lines
meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb +1 -1
@@ -4,7 +4,7 @@ HOMEPAGE = "http://oss.oetiker.ch/rrdtool/"
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYRIGHT;md5=3349111ed0533471494beec99715bc9d"
 
-DEPENDS = "libpng zlib cairo pango glib-2.0 libxml2 groff-native"
+DEPENDS = "libpng zlib cairo pango glib-2.0 libxml2 groff-native gettext-native"

perhaps inherit gettext is more appropriate ?

Quoted 11 lines
meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb +0 -1
 SRCREV = "61f116744262c4c18922dcf806e496715f199669"
 PV = "1.6.0"
--

2.11.0

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#2 lore raw
Quoted 25 lines · Khem Raj
Quoted 23 lines · Randy MacLeod

Add gettext-native dependency to use autopoint.

When building rrdtool for a 'tiny' distro, ie one that does not have internationalization support in glibc, configure fails with the error:
autoreconf: failed to run autopoint: No such file or directory
autopoint is part of gettext so add that native dependency. This must happen transitively for builds using a regular configuration of glibc.

---
 meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb +0 -0
index db2df28a0..160dea58d 100644
@@ -4,7 +4,7 @@ HOMEPAGE = "http://oss.oetiker.ch/rrdtool/"
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYRIGHT;md5=3349111ed0533471494beec99715bc9d"
 
Quoted 4 lines

meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb HOMEPAGE = "http://oss.oetiker.ch/rrdtool/" · line 7

Quoted 2 lines
meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb +1 -1
-DEPENDS = "libpng zlib cairo pango glib-2.0 libxml2 groff-native"
+DEPENDS = "libpng zlib cairo pango glib-2.0 libxml2 groff-native gettext-native"

perhaps inherit gettext is more appropriate ?

That's already there:

$ grep gettext `find * -name "rrdtoo*bb"`
inherit cpan autotools-brokensep gettext pythonnative python-dir systemd

and in meta/classes/gettext.bbclass:

def gettext_dependencies(d):
if d.getVar('INHIBIT_DEFAULT_DEPS') and not oe.utils.inherits(d,
'cross-canadian'):
return ""
if d.getVar('USE_NLS') == 'no':
return "gettext-minimal-native"
return d.getVar('DEPENDS_GETTEXT', False)

I could install autopoint as part of gettext-minimal-native but I need to dig a bit more and learn what the heck autopoint is being used for... maybe I need to fix rrdtool's configure script and/or see if that's done already in the newer version.

../Randy

Quoted 13 lines
Quoted 13 lines
meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb +0 -1
 SRCREV = "61f116744262c4c18922dcf806e496715f199669"
 PV = "1.6.0"
--

2.11.0

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Signature · 2 lines
# Randy MacLeod. SMTS, Linux, Wind River
Direct: 613.963.1350 | 350 Terry Fox Drive, Suite 200, Ottawa, ON, Canada, K2K 2W5