Skip to contentSkip to conversation

sysfs: remove signedness from sysfs_get_dirent

PATCH New Nick Desaulniers 1 participant 1 message May 21, 2017 Driver core

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sysfs: remove signedness from sysfs_get_dirent

sysfs_get_dirent is usually invoked with a string literal, which have the type char[]. While the toplevel Makefile disables -Wpointer-sign, other Makefiles like

arch/x86/boot/compressed/Makefile

redefine KBUILD_CFLAGS. Fixes the warning:

In file included from arch/x86/boot/compressed/kaslr.c:17:
In file included from ./include/linux/module.h:17:
In file included from ./include/linux/kobject.h:21:
./include/linux/sysfs.h:517:37: warning: passing 'const unsigned char *' to parameter of
type 'const char *' converts between pointers to integer types
with different sign

      [-Wpointer-sign]
        return kernfs_find_and_get(parent, name);
                                           ^~~~
./include/linux/kernfs.h:462:57: note: passing argument to parameter
'name' here
kernfs_find_and_get(struct kernfs_node *kn, const char *name)
                                                        ^

---
Alternatively, maybe
KBUILD_CFLAGS += $(call cc-disable-warning, pointer-sign) should be added elsewhere like

arch/x86/boot/compressed/Makefile

 include/linux/sysfs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/sysfs.h +1 -1
index c6f0f0d0e17e..7481fb72d927 100644
@@ -512,7 +512,7 @@ static inline void sysfs_notify_dirent(struct kernfs_node *kn)
 }
 
 static inline struct kernfs_node *sysfs_get_dirent(struct kernfs_node *parent,
-						   const unsigned char *name)
+	const char *name)
 {
 	return kernfs_find_and_get(parent, name);
 }
Signature · 1 line
2.11.0