drm/i915/gen3: Improve reset reliability
Subsystems (2)
PATCH 1/1 drm/i915/gen3: Improve reset reliability
We improved the reset reliablity on gen4 with
stopping all engines before commencing reset, in
commit 2c80353f3cd0 ("drm/i915/g4x: Improve gpu reset reliability")
Evidence indicates that this same trick works with gen3.
Testcase: igt/gem_busy/*-hang #blb-e6850
--- drivers/gpu/drm/i915/intel_uncore.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/gpu/drm/i915/intel_uncore.c +3 -0
@@ -1488,6 +1488,9 @@ static int g33_do_reset(struct drm_i915_private *dev_priv, unsigned engine_mask) {struct pci_dev *pdev = dev_priv->drm.pdev; +/* Stop engines. See g4x_do_reset() below why. */ +gen3_stop_rings (dev_priv); +pci_write_config_byte (pdev,I915_GDRST ,GRDOM_RESET_ENABLE );return wait_for (g4x_reset_complete (pdev),500 ); }
Signature · 6 lines
2.11.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 5 lines · Mika Kuoppala
We improved the reset reliablity on gen4 with
stopping all engines before commencing reset, in
commit2c80353f3cd0("drm/i915/g4x: Improve gpu reset reliability")Evidence indicates that this same trick works with gen3.
Note this is g33 which is a close cousin to g4x, not ye olde gen3 itself.
Quoted 5 lines
Testcase: igt/gem_busy/*-hang #blb-e6850
Cc Ville Syrjälä <[email protected]>Cc Chris Wilson <[email protected]>Cc Tomi Sarvela <[email protected]>Signed-off-by Mika Kuoppala <[email protected]>
-Chris
Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915/gen3: Improve reset reliability
In reply to Mika Kuoppala== Series Details ==
== Series Details ==
Series: drm/i915/gen3: Improve reset reliability
URL : https://patchwork.freedesktop.org/series/24777/
State : success
== Summary ==
Series 24777v1 drm/i915/gen3: Improve reset reliability
https://patchwork.freedesktop.org/api/1.0/series/24777/revisions/1/mbox/
Test gem_exec_flush:
Subgroup basic-batch-kernel-default-uc:
pass -> FAIL (fi-snb-2600) fdo#100007fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
fi-bdw-5557u total:278 pass:267 dwarn:0 dfail:0 fail:0 skip:11 time:443s fi-bdw-gvtdvm total:278 pass:256 dwarn:8 dfail:0 fail:0 skip:14 time:436s fi-bsw-n3050 total:278 pass:242 dwarn:0 dfail:0 fail:0 skip:36 time:585s fi-bxt-j4205 total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time:509s fi-byt-j1900 total:278 pass:254 dwarn:0 dfail:0 fail:0 skip:24 time:494s fi-byt-n2820 total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:484s fi-hsw-4770 total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:419s fi-hsw-4770r total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:409s fi-ilk-650 total:278 pass:228 dwarn:0 dfail:0 fail:0 skip:50 time:421s fi-ivb-3520m total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:493s fi-ivb-3770 total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:466s fi-kbl-7500u total:278 pass:255 dwarn:5 dfail:0 fail:0 skip:18 time:464s fi-skl-6260u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:461s fi-skl-6700hq total:278 pass:260 dwarn:1 dfail:0 fail:0 skip:17 time:573s fi-skl-6700k total:278 pass:256 dwarn:4 dfail:0 fail:0 skip:18 time:468s fi-skl-6770hq total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:506s fi-skl-gvtdvm total:278 pass:265 dwarn:0 dfail:0 fail:0 skip:13 time:437s fi-snb-2520m total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:531s fi-snb-2600 total:278 pass:248 dwarn:0 dfail:0 fail:1 skip:29 time:408s
f20cc05633fee08ea2a99cf544524735057592a1 drm-tip: 2017y-05m-22d-09h-11m-14s UTC integration manifest e3fabc8 drm/i915/gen3: Improve reset reliability
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4765/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx