perf tools: Fix to put caller above callee in children mode
Namhyung Kim
maintainerPATCH 1/1 perf tools: Fix to put caller above callee in children mode
The __hpp__sort_acc() sorts entries using callchain depth in order to put callers above in children mode. But it assumed the callchain order was callee-first. Now default (for children) is caller-first so the order of entries is reverted.
For example, consider following case.
$ perf report --no-children
..l
# Overhead Command Shared Object Symbol
# ........ ....... ................... ..........................
#
99.44% a.out a.out [.] main
|
---main
__libc_start_main
_startThen children mode should show 'start' above '__libc_start_main' since it's the caller (parent) of the __libc_start_main. But it's reversed:
# Children Self Command Shared Object Symbol
# ........ ........ ....... ............... .....................
#
99.61% 0.00% a.out libc-2.25.so [.] __libc_start_main
99.61% 0.00% a.out a.out [.] _start
99.54% 99.44% a.out a.out [.] mainThis patch fixes it.
# Children Self Command Shared Object Symbol
# ........ ........ ....... ............... .....................
#
99.61% 0.00% a.out a.out [.] _start
99.61% 0.00% a.out libc-2.25.so [.] __libc_start_main
99.54% 99.44% a.out a.out [.] main--- tools/perf/ui/hist.c | 2 ++ 1 file changed, 2 insertions(+)
tools/perf/ui/hist.c +2 -0
@@ -210,6 +210,8 @@ static int __hpp__sort_acc(struct hist_entry *a, struct hist_entry *b,return 0 ; ret = b->callchain->max_depth - a->callchain->max_depth; +if (callchain_param.order ==ORDER_CALLER ) + ret = -ret; }return ret; }
Signature · 1 line
2.13.0
Quoted 37 lines · Namhyung Kim
The
__hpp__sort_acc()sorts entries using callchain depth in order to put callers above in children mode. But it assumed the callchain order was callee-first. Now default (for children) is caller-first so the order of entries is reverted.For example, consider following case.
$ perf report --no-children ..l # Overhead Command Shared Object Symbol # ........ ....... ................... .......................... # 99.44% a.out a.out [.] main | ---main __libc_start_main _startThen children mode should show 'start' above '
__libc_start_main' since it's the caller (parent) of the__libc_start_main. But it's reversed:# Children Self Command Shared Object Symbol # ........ ........ ....... ............... ..................... # 99.61% 0.00% a.out libc-2.25.so [.] __libc_start_main 99.61% 0.00% a.out a.out [.] _start 99.54% 99.44% a.out a.out [.] mainThis patch fixes it.
# Children Self Command Shared Object Symbol # ........ ........ ....... ............... ..................... # 99.61% 0.00% a.out a.out [.] _start 99.61% 0.00% a.out libc-2.25.so [.] __libc_start_main 99.54% 99.44% a.out a.out [.] main
Quoted 3 lines
Cc Frederic Weisbecker <[email protected]>Cc Milian Wolff <[email protected]>Signed-off-by Namhyung Kim <[email protected]>
thanks,
jirka